From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web08.787.1606267672980919525 for ; Tue, 24 Nov 2020 17:27:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=brlMAc3+; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: jejb@linux.ibm.com) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0AP11GAv099084; Tue, 24 Nov 2020 20:27:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : reply-to : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=6+ECERII80NbrP+d78H755KEJ0OZS+I5Ea9VELZkjvY=; b=brlMAc3+el5P/McxCHWbdUx4SLBWFs0BVC4iv2CignJKIe/x8ssBvr2xRbV8rjmKsn6L +SCm2aR6CKahgDhcGhYpa1QOPyNgE7vS+Ftl/9V5yD58hVoOx9LMTc19s2Y0GL7TaF0P uhQVrFcI04/f/bI194uHB840mz7CClYrSeA9E32jBQgcbwk7gn60BBH84iktCcqdLye1 4JtSJRWXLreUKpVMO1Kc6q0rothwkqmVzF+WAzK2tJVxtfWZl49f9d9UiB9Z99oN1gbS 2Rv9f7eLn0neb7AHk99UCNugexNEC8m4QAEW6l7H5nZt94T8G/jrv+y7jo0fHQv97WcK 7g== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3513479txc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Nov 2020 20:27:50 -0500 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0AP1DVgu143756; Tue, 24 Nov 2020 20:27:49 -0500 Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0b-001b2d01.pphosted.com with ESMTP id 3513479tx3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Nov 2020 20:27:49 -0500 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0AP1LOB0020229; Wed, 25 Nov 2020 01:27:49 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma02wdc.us.ibm.com with ESMTP id 34xth93rwv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Nov 2020 01:27:49 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0AP1RdTY44368362 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Nov 2020 01:27:39 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1E0747805E; Wed, 25 Nov 2020 01:27:46 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CFF697805C; Wed, 25 Nov 2020 01:27:43 +0000 (GMT) Received: from jarvis.int.hansenpartnership.com (unknown [9.85.194.234]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 25 Nov 2020 01:27:43 +0000 (GMT) Message-ID: <93fdaca88b53d400670b338a06fd1410c1445a39.camel@linux.ibm.com> Subject: Re: [edk2-devel] [PATCH v2 2/6] OvmfPkg/AmdSev: add Grub Firmware Volume Package From: "James Bottomley" Reply-To: jejb@linux.ibm.com To: devel@edk2.groups.io, Laszlo Ersek , Bret Barkelew Cc: dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com, ashish.kalra@amd.com, brijesh.singh@amd.com, tobin@ibm.com, david.kaplan@amd.com, jon.grimm@amd.com, thomas.lendacky@amd.com, frankeh@us.ibm.com, "Dr . David Alan Gilbert" Date: Tue, 24 Nov 2020 17:27:42 -0800 In-Reply-To: References: <20201120184521.19437-1-jejb@linux.ibm.com> <20201120184521.19437-3-jejb@linux.ibm.com> <28e99174-79b3-e805-b977-5fed0071a702@redhat.com> <06b9425507ab8c1b35d377cf9bba155b0cc44147.camel@linux.ibm.com> <3b7899fa-fa52-7652-2d2a-d4ec67ece34d@redhat.com> <1c871b56-f459-5ac4-3b8d-a55d978eac06@redhat.com> User-Agent: Evolution 3.34.4 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-24_07:2020-11-24,2020-11-24 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=2 lowpriorityscore=0 malwarescore=0 clxscore=1011 priorityscore=1501 spamscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011240121 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2020-11-24 at 15:42 -0800, James Bottomley wrote: > On Wed, 2020-11-25 at 00:22 +0100, Laszlo Ersek wrote: [...] > > There are some others that should be possible to remove (pls. refer > > to the rest of that email). > > Heh, well, I spoke too soon. Even though the OVMF this produces > boots to grub and decrypts an encrypted volume, the kernel boot > panics because of something missing in the runtime ... it looks like > it's tripping over gRT->SetVariable, so I'm going to have to start > putting some stuff back again ... Actually, this isn't me. I can't get the vanilla OVMF package to boot either. It looks to be a problem with the variable policy stuff since the last known good boot was before they were added. I've attached the boot log with vanilla OVMF. There's rather a lot of policy commits to try reverting. What's the best way to debug this? James --- Loading Linux 5.5.0-2-amd64 ... Loading initial ramdisk ... [ 0.000000] Linux version 5.5.0-2-amd64 (debian-kernel@lists.debian.org) (gcc version 9.3.0 (Debian 9.3.0-10)) #1 SMP Debian 5.5.17-1 (2020-04-15) [ 0.000000] Command line: BOOT_IMAGE=/boot/vmlinuz-5.5.0-2-amd64 root=UUID=8ebba08b-ff72-4030-ba43-8ce252e2e5a4 ro console=ttyS0,115200n8 [ 0.000000] x86/fpu: x87 FPU will use FXSAVE [ 0.000000] BIOS-provided physical RAM map: [ 0.000000] BIOS-e820: [mem 0x0000000000000000-0x000000000009ffff] usable [ 0.000000] BIOS-e820: [mem 0x0000000000100000-0x00000000007fffff] usable [ 0.000000] BIOS-e820: [mem 0x0000000000800000-0x0000000000807fff] ACPI NVS [ 0.000000] BIOS-e820: [mem 0x0000000000808000-0x000000000080ffff] usable [ 0.000000] BIOS-e820: [mem 0x0000000000810000-0x00000000008fffff] ACPI NVS [ 0.000000] BIOS-e820: [mem 0x0000000000900000-0x000000007f8eefff] usable [ 0.000000] BIOS-e820: [mem 0x000000007f8ef000-0x000000007f9eefff] reserved [ 0.000000] BIOS-e820: [mem 0x000000007f9ef000-0x000000007faeefff] type 20 [ 0.000000] BIOS-e820: [mem 0x000000007faef000-0x000000007fb6efff] reserved [ 0.000000] BIOS-e820: [mem 0x000000007fb6f000-0x000000007fb7efff] ACPI data [ 0.000000] BIOS-e820: [mem 0x000000007fb7f000-0x000000007fbfefff] ACPI NVS [ 0.000000] BIOS-e820: [mem 0x000000007fbff000-0x000000007fef3fff] usable [ 0.000000] BIOS-e820: [mem 0x000000007fef4000-0x000000007ff77fff] reserved [ 0.000000] BIOS-e820: [mem 0x000000007ff78000-0x000000007fffffff] ACPI NVS [ 0.000000] BIOS-e820: [mem 0x00000000ffc00000-0x00000000ffffffff] reserved [ 0.000000] NX (Execute Disable) protection: active [ 0.000000] efi: EFI v2.70 by EDK II [ 0.000000] efi: SMBIOS=0x7f942000 ACPI=0x7fb7e000 ACPI 2.0=0x7fb7e014 MEMATTR=0x7ebe9018 [ 0.000000] secureboot: Secure boot could not be determined (mode 0) [ 0.000000] SMBIOS 2.8 present. [ 0.000000] DMI: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015 [ 0.000000] Hypervisor detected: KVM [ 0.000000] kvm-clock: Using msrs 4b564d01 and 4b564d00 [ 0.000000] kvm-clock: cpu 0, msr 28031001, primary cpu clock [ 0.000000] kvm-clock: using sched offset of 16414477727 cycles [ 0.000006] clocksource: kvm-clock: mask: 0xffffffffffffffff max_cycles: 0x1cd42e4dffb, max_idle_ns: 881590591483 ns [ 0.000018] tsc: Detected 2400.000 MHz processor [ 0.000169] last_pfn = 0x7fef4 max_arch_pfn = 0x400000000 [ 0.000220] x86/PAT: PAT not supported by CPU. [ 0.000227] x86/PAT: Configuration [0-7]: WB WT UC- UC WB WT UC- UC [ 0.015576] RAMDISK: [mem 0x34a09000-0x364fbfff] [ 0.015601] ACPI: Early table checksum verification disabled [ 0.015622] ACPI: RSDP 0x000000007FB7E014 000024 (v02 BOCHS ) [ 0.015627] ACPI: XSDT 0x000000007FB7D0E8 000044 (v01 BOCHS BXPCFACP 00000001 01000013) [ 0.015639] ACPI: FACP 0x000000007FB7A000 000074 (v01 BOCHS BXPCFACP 00000001 BXPC 00000001) [ 0.015645] ACPI: DSDT 0x000000007FB7B000 00140B (v01 BOCHS BXPCDSDT 00000001 BXPC 00000001) [ 0.015656] ACPI: FACS 0x000000007FBDD000 000040 [ 0.015659] ACPI: APIC 0x000000007FB79000 000078 (v01 BOCHS BXPCAPIC 00000001 BXPC 00000001) [ 0.015663] ACPI: HPET 0x000000007FB78000 000038 (v01 BOCHS BXPCHPET 00000001 BXPC 00000001) [ 0.015669] ACPI: BGRT 0x000000007FB77000 000038 (v01 INTEL EDK2 00000002 01000013) [ 0.016057] No NUMA configuration found [ 0.016058] Faking a node at [mem 0x0000000000000000-0x000000007fef3fff] [ 0.016066] NODE_DATA(0) allocated [mem 0x7fe7f000-0x7fe83fff] [ 0.016095] Zone ranges: [ 0.016100] DMA [mem 0x0000000000001000-0x0000000000ffffff] [ 0.016101] DMA32 [mem 0x0000000001000000-0x000000007fef3fff] [ 0.016102] Normal empty [ 0.016103] Device empty [ 0.016104] Movable zone start for each node [ 0.016105] Early memory node ranges [ 0.016106] node 0: [mem 0x0000000000001000-0x000000000009ffff] [ 0.016107] node 0: [mem 0x0000000000100000-0x00000000007fffff] [ 0.016108] node 0: [mem 0x0000000000808000-0x000000000080ffff] [ 0.016109] node 0: [mem 0x0000000000900000-0x000000007f8eefff] [ 0.016110] node 0: [mem 0x000000007fbff000-0x000000007fef3fff] [ 0.016459] Zeroed struct page in unavailable ranges: 1397 pages [ 0.016461] Initmem setup node 0 [mem 0x0000000000001000-0x000000007fef3fff] [ 0.019894] ACPI: PM-Timer IO Port: 0xb008 [ 0.019926] ACPI: LAPIC_NMI (acpi_id[0xff] dfl dfl lint[0x1]) [ 0.019972] IOAPIC[0]: apic_id 0, version 17, address 0xfec00000, GSI 0-23 [ 0.019975] ACPI: INT_SRC_OVR (bus 0 bus_irq 0 global_irq 2 dfl dfl) [ 0.019981] ACPI: INT_SRC_OVR (bus 0 bus_irq 5 global_irq 5 high level) [ 0.019982] ACPI: INT_SRC_OVR (bus 0 bus_irq 9 global_irq 9 high level) [ 0.019987] ACPI: INT_SRC_OVR (bus 0 bus_irq 10 global_irq 10 high level) [ 0.019988] ACPI: INT_SRC_OVR (bus 0 bus_irq 11 global_irq 11 high level) [ 0.019993] Using ACPI (MADT) for SMP configuration information [ 0.019995] ACPI: HPET id: 0x8086a201 base: 0xfed00000 [ 0.020024] smpboot: Allowing 1 CPUs, 0 hotplug CPUs [ 0.020051] PM: Registered nosave memory: [mem 0x00000000-0x00000fff] [ 0.020052] PM: Registered nosave memory: [mem 0x000a0000-0x000fffff] [ 0.020054] PM: Registered nosave memory: [mem 0x00800000-0x00807fff] [ 0.020055] PM: Registered nosave memory: [mem 0x00810000-0x008fffff] [ 0.020056] PM: Registered nosave memory: [mem 0x7e7e7000-0x7e7effff] [ 0.020057] PM: Registered nosave memory: [mem 0x7f8ef000-0x7f9eefff] [ 0.020058] PM: Registered nosave memory: [mem 0x7f9ef000-0x7faeefff] [ 0.020059] PM: Registered nosave memory: [mem 0x7faef000-0x7fb6efff] [ 0.020059] PM: Registered nosave memory: [mem 0x7fb6f000-0x7fb7efff] [ 0.020060] PM: Registered nosave memory: [mem 0x7fb7f000-0x7fbfefff] [ 0.020063] [mem 0x80000000-0xffbfffff] available for PCI devices [ 0.020064] Booting paravirtualized kernel on KVM [ 0.020069] clocksource: refined-jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645519600211568 ns [ 0.108622] setup_percpu: NR_CPUS:512 nr_cpumask_bits:512 nr_cpu_ids:1 nr_node_ids:1 [ 0.109877] percpu: Embedded 55 pages/cpu s187800 r8192 d29288 u2097152 [ 0.109918] KVM setup async PF for cpu 0 [ 0.109923] kvm-stealtime: cpu 0, msr 7c419500 [ 0.109931] Built 1 zonelists, mobility grouping on. Total pages: 512892 [ 0.109932] Policy zone: DMA32 [ 0.109934] Kernel command line: BOOT_IMAGE=/boot/vmlinuz-5.5.0-2-amd64 root=UUID=8ebba08b-ff72-4030-ba43-8ce252e2e5a4 ro console=ttyS0,115200n8 [ 0.111356] Dentry cache hash table entries: 262144 (order: 9, 2097152 bytes, linear) [ 0.111796] Inode-cache hash table entries: 131072 (order: 8, 1048576 bytes, linear) [ 0.111837] mem auto-init: stack:off, heap alloc:off, heap free:off [ 0.114998] Memory: 248380K/2091564K available (10243K kernel code, 1221K rwdata, 3972K rodata, 1672K init, 1980K bss, 120832K reserved, 0K cma-reserved) [ 0.115028] random: get_random_u64 called from __kmem_cache_create+0x3e/0x530 with crng_init=0 [ 0.115547] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=1, Nodes=1 [ 0.115575] Kernel/User page tables isolation: enabled [ 0.115617] ftrace: allocating 34294 entries in 134 pages [ 0.130489] ftrace: allocated 134 pages with 3 groups [ 0.130821] rcu: Hierarchical RCU implementation. [ 0.130823] rcu: RCU restricting CPUs from NR_CPUS=512 to nr_cpu_ids=1. [ 0.130826] rcu: RCU calculated value of scheduler-enlistment delay is 25 jiffies. [ 0.130827] rcu: Adjusting geometry for rcu_fanout_leaf=16, nr_cpu_ids=1 [ 0.133774] NR_IRQS: 33024, nr_irqs: 256, preallocated irqs: 16 [ 0.134031] Console: colour dummy device 80x25 [ 0.242024] printk: console [ttyS0] enabled [ 0.242695] ACPI: Core revision 20191018 [ 0.243470] clocksource: hpet: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 19112604467 ns [ 0.244954] APIC: Switch to symmetric I/O mode setup [ 0.246031] x2apic enabled [ 0.246800] Switched APIC routing to physical x2apic. [ 0.248946] ..TIMER: vector=0x30 apic1=0 pin1=2 apic2=-1 pin2=-1 [ 0.249892] clocksource: tsc-early: mask: 0xffffffffffffffff max_cycles: 0x22983777dd9, max_idle_ns: 440795300422 ns [ 0.251455] Calibrating delay loop (skipped) preset value.. 4800.00 BogoMIPS (lpj=9600000) [ 0.252873] pid_max: default: 32768 minimum: 301 [ 0.256847] BUG: unable to handle page fault for address: 000000007ed03020 [ 0.258328] #PF: supervisor read access in kernel mode [ 0.259304] #PF: error_code(0x0000) - not-present page [ 0.259452] PGD fd2d063 P4D fd2d063 PUD fd30063 PMD fd3f063 PTE fffff812fc060 [ 0.259452] Oops: 0000 [#1] SMP PTI [ 0.259452] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.5.0-2-amd64 #1 Debian 5.5.17-1 [ 0.259452] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015 [ 0.259452] RIP: 0010:0xfffffffeff6c6648 [ 0.259452] Code: 48 83 ec 20 e8 41 fd ff ff 48 85 c9 75 1c 84 c0 74 18 4c 8d 05 15 a1 00 00 48 8d 0d ec 93 00 00 ba ba 00 00 00 e8 c0 fe ff ff <48> 8b 03 48 83 c4 20 5b c3 55 57 56 53 48 89 d3 48 89 ce 48 83 ec [ 0.259452] RSP: 0000:ffffffffabc03b10 EFLAGS: 00010202 [ 0.259452] RAX: 0000000000000001 RBX: 000000007ed03020 RCX: 000000007ed03020 [ 0.259452] RDX: ffffffffabc03eb0 RSI: 000000007ed03020 RDI: ffffffffab809670 [ 0.259452] RBP: 0000000000000000 R08: 0000000000000007 R09: 0000000000000000 [ 0.259452] R10: 0000000000000000 R11: 800000007ff77063 R12: ffffffffabc03eb0 [ 0.259452] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 [ 0.259452] FS: 0000000000000000(0000) GS:ffff9becbc400000(0000) knlGS:0000000000000000 [ 0.259452] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 0.259452] CR2: 000000007ed03020 CR3: 000000000fd38000 CR4: 00000000000006b0 [ 0.259452] Call Trace: [ 0.259452] ? __raw_callee_save___native_queued_spin_unlock+0x11/0x1e [ 0.259452] ? prep_new_page+0x3e/0x150 [ 0.259452] ? get_page_from_freelist+0xfc1/0x1200 [ 0.259452] ? native_flush_tlb_global+0x97/0xa0 [ 0.259452] ? __flush_tlb_all+0x13/0x20 [ 0.259452] ? efi_call+0x58/0x90 [ 0.259452] ? virt_efi_set_variable_nonblocking+0xa0/0x120 [ 0.259452] ? efi_delete_dummy_variable+0x5e/0x80 [ 0.259452] ? efi_enter_virtual_mode+0x4f7/0x515 [ 0.259452] ? start_kernel+0x4cd/0x562 [ 0.259452] ? secondary_startup_64+0xa4/0xb0 [ 0.259452] Modules linked in: [ 0.259452] CR2: 000000007ed03020 [ 0.259452] ---[ end trace d144de23fcdf159d ]--- [ 0.259452] RIP: 0010:0xfffffffeff6c6648 [ 0.259452] Code: 48 83 ec 20 e8 41 fd ff ff 48 85 c9 75 1c 84 c0 74 18 4c 8d 05 15 a1 00 00 48 8d 0d ec 93 00 00 ba ba 00 00 00 e8 c0 fe ff ff <48> 8b 03 48 83 c4 20 5b c3 55 57 56 53 48 89 d3 48 89 ce 48 83 ec [ 0.259452] RSP: 0000:ffffffffabc03b10 EFLAGS: 00010202 [ 0.259452] RAX: 0000000000000001 RBX: 000000007ed03020 RCX: 000000007ed03020 [ 0.259452] RDX: ffffffffabc03eb0 RSI: 000000007ed03020 RDI: ffffffffab809670 [ 0.259452] RBP: 0000000000000000 R08: 0000000000000007 R09: 0000000000000000 [ 0.259452] R10: 0000000000000000 R11: 800000007ff77063 R12: ffffffffabc03eb0 [ 0.259452] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 [ 0.259452] FS: 0000000000000000(0000) GS:ffff9becbc400000(0000) knlGS:0000000000000000 [ 0.259452] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 0.259452] CR2: 000000007ed03020 CR3: 000000000fd38000 CR4: 00000000000006b0 [ 0.259452] Kernel panic - not syncing: Attempted to kill the idle task! [ 0.259452] ---[ end Kernel panic - not syncing: Attempted to kill the idle task! ]---