public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
	"Gao, Liming" <liming.gao@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"'afish@apple.com'" <afish@apple.com>
Subject: Re: [edk2-devel] Patch List for 201911 stable tag
Date: Thu, 21 Nov 2019 18:26:03 +0100	[thread overview]
Message-ID: <93fe2f86-a235-3254-37ed-eb033a7ffba8@redhat.com> (raw)
In-Reply-To: <20191121103751.GL7323@bivouac.eciton.net>

On 11/21/19 11:37, Leif Lindholm wrote:
> On Thu, Nov 21, 2019 at 08:57:12AM +0000, Gao, Liming wrote:
>> Hi Stewards and all:
>>   New bugs are for 201911 stable tag. Can you give the comments for them?
>>
>> Bug List (those all have pass code review):
>> https://edk2.groups.io/g/devel/message/50931 [PATCH] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore
> 
> This can wait until after the stable tag *unless* that causes serious
> issues for CI. (And I don't consider non-zero build failures for EBC
> to be serious.)
> The fix only addresses building the component standalone as part of
> MdeModulePkg, so it affects no real platforms.

I would have beem more permissive with this patch, but I'm OK with the
above resolution too.

> 
> I have some comments with regards to the implementation as well, but
> I'll give those on the actual patch email.
> 
>> https://edk2.groups.io/g/devel/message/50990 [PATCH V1 1/1] MdeModulePkg/Variable: Initialize local variable
> 
> Those two bugs are poster children for why long functions should be
> avoided.
> 
> OK for me to include in stable tag.

Agreed.

> 
>> https://edk2.groups.io/g/devel/message/50989 [PATCH V2] BaseTools:fix regression issue for platform .map file
> 
> OK for me to include *if* the commit message (and bugzilla) are
> updated to clarify the issue. "is missing" is passive language, and
> hence fails to convey what is causing the problem. Does this mean
> that the 'build' command fails to generate these lines?
> 
> Also, a comment on why this change (of moving this hunk 18 lines up)
> resolves the issue should be included.

Agreed; please add a reminder to the commit message (even on push) about
what the specific (missing) lines in the map files are good for in the
first place.

> 
>> https://edk2.groups.io/g/devel/message/50936 [PATCH] BaseTools:fixed Build failed issue for Non-English OS
> 
> I agree that a fix for this bug must be included in the stable tag.
> But both the BZ and the commit message need improving.
> And seeing a fix that consists solely of adding "errors='ignore'"
> worries me somewhat.
> 
> Please explain *what* goes wrong when using Non-English OS (and which
> OS), as well as why "errors='ignore'" does not cause further problems.

I think this patch is plain wrong. I'll comment on it in its own thread.

Thanks
Laszlo


  reply	other threads:[~2019-11-21 17:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19 14:25 Patch List for 201911 stable tag Liming Gao
2019-11-19 17:50 ` Laszlo Ersek
2019-11-19 19:01   ` Leif Lindholm
2019-11-20  1:46     ` [edk2-devel] " Wu, Hao A
2019-11-20 14:52     ` Liming Gao
     [not found]     ` <15D8E68889A9A669.17632@groups.io>
2019-11-21  8:57       ` Liming Gao
2019-11-21 10:37         ` Leif Lindholm
2019-11-21 17:26           ` Laszlo Ersek [this message]
2019-11-25  7:36             ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93fe2f86-a235-3254-37ed-eb033a7ffba8@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox