From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.27213.1574357169517827201 for ; Thu, 21 Nov 2019 09:26:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SX+Uvvot; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574357168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3/KAN8Nk1oy86kD/Ko7spRZrD6zwmttJPutozkoJf00=; b=SX+Uvvot/2Y3+1NPMYzw83k9Vp1H3BoxT3yhrgJeQ9HqujrpMl0lT5Yn7HQTIirFS6TQ8I cyGL5U6aQXlfUlMKd0+wzJ5ENDjhS9jub1pu8GIZVV+mkjjrE4AYGiOzYdIeUbB+B1rvS7 Of1VD06WK1NJPkiyjAT9yL19r1xqpVw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-91-PW2RV6Z_NJaTv065JrsyKA-1; Thu, 21 Nov 2019 12:26:06 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3DB4F107ACC4; Thu, 21 Nov 2019 17:26:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-197.ams2.redhat.com [10.36.116.197]) by smtp.corp.redhat.com (Postfix) with ESMTP id F20C9106F957; Thu, 21 Nov 2019 17:26:03 +0000 (UTC) Subject: Re: [edk2-devel] Patch List for 201911 stable tag To: Leif Lindholm , "Gao, Liming" Cc: "devel@edk2.groups.io" , "Kinney, Michael D" , "'afish@apple.com'" References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E5437BA@SHSMSX104.ccr.corp.intel.com> <48a7f95e-1028-ea52-9980-da7af871cef2@redhat.com> <20191119190151.GE7323@bivouac.eciton.net> <15D8E68889A9A669.17632@groups.io> <4A89E2EF3DFEDB4C8BFDE51014F606A14E545983@SHSMSX104.ccr.corp.intel.com> <20191121103751.GL7323@bivouac.eciton.net> From: "Laszlo Ersek" Message-ID: <93fe2f86-a235-3254-37ed-eb033a7ffba8@redhat.com> Date: Thu, 21 Nov 2019 18:26:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191121103751.GL7323@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: PW2RV6Z_NJaTv065JrsyKA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable On 11/21/19 11:37, Leif Lindholm wrote: > On Thu, Nov 21, 2019 at 08:57:12AM +0000, Gao, Liming wrote: >> Hi Stewards and all: >> New bugs are for 201911 stable tag. Can you give the comments for them= ? >> >> Bug List (those all have pass code review): >> https://edk2.groups.io/g/devel/message/50931 [PATCH] MdeModulePkg: LzmaC= ustomDecompressLib.inf don't support EBC anymore >=20 > This can wait until after the stable tag *unless* that causes serious > issues for CI. (And I don't consider non-zero build failures for EBC > to be serious.) > The fix only addresses building the component standalone as part of > MdeModulePkg, so it affects no real platforms. I would have beem more permissive with this patch, but I'm OK with the above resolution too. >=20 > I have some comments with regards to the implementation as well, but > I'll give those on the actual patch email. >=20 >> https://edk2.groups.io/g/devel/message/50990 [PATCH V1 1/1] MdeModulePkg= /Variable: Initialize local variable >=20 > Those two bugs are poster children for why long functions should be > avoided. >=20 > OK for me to include in stable tag. Agreed. >=20 >> https://edk2.groups.io/g/devel/message/50989 [PATCH V2] BaseTools:fix re= gression issue for platform .map file >=20 > OK for me to include *if* the commit message (and bugzilla) are > updated to clarify the issue. "is missing" is passive language, and > hence fails to convey what is causing the problem. Does this mean > that the 'build' command fails to generate these lines? >=20 > Also, a comment on why this change (of moving this hunk 18 lines up) > resolves the issue should be included. Agreed; please add a reminder to the commit message (even on push) about what the specific (missing) lines in the map files are good for in the first place. >=20 >> https://edk2.groups.io/g/devel/message/50936 [PATCH] BaseTools:fixed Bui= ld failed issue for Non-English OS >=20 > I agree that a fix for this bug must be included in the stable tag. > But both the BZ and the commit message need improving. > And seeing a fix that consists solely of adding "errors=3D'ignore'" > worries me somewhat. >=20 > Please explain *what* goes wrong when using Non-English OS (and which > OS), as well as why "errors=3D'ignore'" does not cause further problems. I think this patch is plain wrong. I'll comment on it in its own thread. Thanks Laszlo