From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 73CD57803CE for ; Thu, 10 Aug 2023 13:19:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=BcDkMrAe8amfMg863XzmjnKmUm6d5DFNnecfou07Cac=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1691673589; v=1; b=VFMwMIlCLTNU1Z02HOfA3QJUBvt5RWr4gE77GQZ4Ai86HNDudF+Jms0EciG4UhuMMorVKY3W 3PoSwX1WfcoV556XdpRPSyzoRADswjOUwUtJSEtSlYhR9BXVTRDL/hKeB9V608mFy9EjfKjE011 cxT7osq85snd2W2NuE3IPjxM= X-Received: by 127.0.0.2 with SMTP id fsJ9YY7687511xKOENUXUBkc; Thu, 10 Aug 2023 06:19:49 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.16897.1691673588214852190 for ; Thu, 10 Aug 2023 06:19:48 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C972D75; Thu, 10 Aug 2023 06:20:30 -0700 (PDT) X-Received: from [10.34.100.101] (e126645.nice.arm.com [10.34.100.101]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 34D293F64C; Thu, 10 Aug 2023 06:19:47 -0700 (PDT) Message-ID: <940a4419-5be4-a7dc-f677-2f0439235c7d@arm.com> Date: Thu, 10 Aug 2023 15:19:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [edk2-devel] [PATCH v5 8/9] SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib To: Sami Mujawar , devel@edk2.groups.io References: <20230718115156.1224842-9-pierre.gondois@arm.com> <16750.1691385409155473599@groups.io> From: "PierreGondois" In-Reply-To: <16750.1691385409155473599@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ifBkEsLMs5kkUvjQZoeH12RHx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=VFMwMIlC; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Sami, Yes indeed, this line should be removed, do you want me to send a new version of this patch ? Regards, Pierre On 8/7/23 07:16, Sami Mujawar wrote: > Hi Pierre, >=20 > Thank you for this patch. >=20 > On Tue, Jul 18, 2023 at 04:52 AM, PierreGondois wrote: >=20 > + gEfiRngAlgorithmArmRndr ## SOMETIMES_PRODUCES ## GUID =3D > # Unique ID of the algorithm for RNG >=20 > Can you check if the line above should be part of this patch, please? > Otherwise, this patch looks good to me. >=20 > In either case, > Reviewed-by: Sami Mujawar >=20 > Regards, >=20 > Sami Mujawar -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107688): https://edk2.groups.io/g/devel/message/107688 Mute This Topic: https://groups.io/mt/100213737/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-