From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0E959D80CA2 for ; Fri, 3 Nov 2023 07:32:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7EwYZw/e2PQUULzF20dxaz59ZSaDMQJRHKQZMM3bSI8=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1698996768; v=1; b=uFJ1h0eRCq/UWiWDIUdffFvKYbe/tgE9LbPpEA8IJ4mAeA8cx5v2rWCIaHtfgXswksrLsyUw ZP6irSfVeU7plUXUQPtvlYFmLdoqCu44sxXcBqut/EEA04A3xJwsZvNcJgqzGJroIhAc9cVcZ5m xBLSpqQ8Dy3VRQLWpIyc+oyc= X-Received: by 127.0.0.2 with SMTP id vibUYY7687511xLGq0yDtx1p; Fri, 03 Nov 2023 00:32:48 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.37682.1698996766612809122 for ; Fri, 03 Nov 2023 00:32:47 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8Cx77sbokRlvKs2AA--.48116S3; Fri, 03 Nov 2023 15:32:43 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxndwYokRlkQA5AA--.57637S3; Fri, 03 Nov 2023 15:32:40 +0800 (CST) Message-ID: <9454d383-210d-4f9b-829e-7324a79aff40@loongson.cn> Date: Fri, 3 Nov 2023 15:32:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 00/29] Enable LoongArch virtual machine in edk2 To: Laszlo Ersek , devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Eric Dong , Ray Ni , Rahul Kumar , Gerd Hoffmann , Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer , Sami Mujawar , Jiewen Yao , Jordan Justen References: <20231103010302.4052990-1-lichao@loongson.cn> <6e509596-e480-3256-ba54-964c1b47f0f5@redhat.com> From: "Chao Li" In-Reply-To: <6e509596-e480-3256-ba54-964c1b47f0f5@redhat.com> X-CM-TRANSID: AQAAf8AxndwYokRlkQA5AA--.57637S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAECGVEWKjEjgABsX X-Coremail-Antispam: 1Uk129KBj93XoW7Ww18WF1rKw17CFWDGFW7Awc_yoW8tFyxpr 43Kw4Fyrn5JF4IkF1xZw1fur95KrsrGFy5G34a9ws7K3Z8K3ZrWry0qw40ya4UZ39Fqr10 qa1DtryxWF98AagCm3ZEXasCq-sJn29KB7ZKAUJUUUU7529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUvCb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv67 AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_Cr1UM2kKe7AKxVWUXVWU AwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMcIj6xIIjx v20xvE14v26r126r1DMcIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1l F7xvr2IY64vIr41l7480Y4vEI4kI2Ix0rVAqx4xJMxAIw28IcxkI7VAKI48JMxC20s026x CaFVCjc4AY6r1j6r4UMxCIbckI1I0E14v26r1q6r43MI8I3I0E5I8CrVAFwI0_JrI_JrWl x2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVW8ZVWrXwCIc40Y0x0EwIxGrw CI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI 42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z2 80aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU8D8n5UUUUU== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1KYpdUIeBYByWPBz4xgtmgcgx7686176AA= Content-Type: multipart/alternative; boundary="------------UN2fgceizXzxcBhijuqbTjrV" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=uFJ1h0eR; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none --------------UN2fgceizXzxcBhijuqbTjrV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Laszlo, Sorry, the reason of some mail is not under cover letter is found, I will fix it at the V2. I don't think the code is **duplicated** since most code is architecture related, and maybe some code is referenced from others ARCH. As  the cover letter saied, most code is distributed in MdePkg, UefiCpuPkg, OvmfPkg. MdePkg is added some help functions for LoongArch. UefCpuPkg is added CpuTimerLib, CpuExceptionLib, CpuMmuLib, MpInitLib, CpuDxe. Each library and driver is not small. OvmfPkg adds the private code for LoongArch QEMU virtual machine instances, it override some architecture related library that cannot use the publice libraries, mostly for the PEI phase. Thanks, Chao 在 2023/11/3 15:07, Laszlo Ersek 写道: > On 11/3/23 02:03, Chao Li wrote: >> This patch set will enable LoongArch virtual machine in edk2, the new >> LoongArch virtual machine is located in OvmfPkg/LoongArchVirt/, it is a >> generic platform that dose not require any actual hardware. >> >> Patch1-Patch14: Submit the common library and driver for LoongArch >> virtual machine and real hardware. Such as base help functions, >> exception handel, MMU library, multiprocessor library etc. >> >> Patch15-Patch16: Add PrePiCpuIoSize for LoongArch64. and move ArmVirtPkg >> two PCDs into OvmfPkg for easier use by other architectures. >> >> Patch17-Patch29: LoongArch virtual machine private code, include SEC and >> PEI phase code, some library and drivers. >> >> Modfied modues: MdePkg, UefiCpuPkg, EmbeddedPkg, ArmVirtPkg, OvmfPkg. >> >> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=4584 >> > [...] > >> 127 files changed, 18478 insertions(+), 84 deletions(-) > 18478 lines seem overkill... Probably too much code added / duplicated > under UefiCpuPkg, as Ray says. > > Also: > > - Please make sure you post the patches with the "sendemail.thread" git > config item set to "true". "BaseTools/Scripts/SetupGit.py" takes care of > that. Otherwise, just as it has now happened, your patches are not > threaded under the cover letter; they fly apart as independent messages. > > - Whenever you post a (new or initial) version of a patch set, please > link the URL of the cover letter (from the mailing list archive) into > the Bugzilla ticket, in a new comment. > > Thanks > Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110613): https://edk2.groups.io/g/devel/message/110613 Mute This Topic: https://groups.io/mt/102355705/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------UN2fgceizXzxcBhijuqbTjrV Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Laszlo,

Sorry, the reason of some mail is not under cover letter is found, I will fix it at the V2.

I don't think the code is **duplicated** since most code is architecture related, and maybe some code is referenced from others ARCH. As  the cover letter saied, most code is distributed in MdePkg, UefiCpuPkg, OvmfPkg. MdePkg is added some help functions for LoongArch. UefCpuPkg is added CpuTimerLib, CpuExceptionLib, CpuMmuLib, MpInitLib, CpuDxe. Each library and driver is not small. OvmfPkg adds the private code for LoongArch QEMU virtual machine instances, it override some architecture related library that cannot use the publice  libraries, mostly for the PEI phase.


Thanks,
Chao
在 2023/11/3 15:07, Laszlo Ersek 写道:
On 11/3/23 02:03, Chao Li wrote:

This patch set will enable LoongArch virtual machine in edk2, the new
LoongArch virtual machine is located in OvmfPkg/LoongArchVirt/, it is a
generic platform that dose not require any actual hardware.

Patch1-Patch14: Submit the common library and driver for LoongArch
virtual machine and real hardware. Such as base help functions,
exception handel, MMU library, multiprocessor library etc.

Patch15-Patch16: Add PrePiCpuIoSize for LoongArch64. and move ArmVirtPkg
two PCDs into OvmfPkg for easier use by other architectures.

Patch17-Patch29: LoongArch virtual machine private code, include SEC and
PEI phase code, some library and drivers.

Modfied modues: MdePkg, UefiCpuPkg, EmbeddedPkg, ArmVirtPkg, OvmfPkg.

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584


[...]


 127 files changed, 18478 insertions(+), 84 deletions(-)

18478 lines seem overkill... Probably too much code added / duplicated
under UefiCpuPkg, as Ray says.

Also:

- Please make sure you post the patches with the "sendemail.thread" git
config item set to "true". "BaseTools/Scripts/SetupGit.py" takes care of
that. Otherwise, just as it has now happened, your patches are not
threaded under the cover letter; they fly apart as independent messages.

- Whenever you post a (new or initial) version of a patch set, please
link the URL of the cover letter (from the mailing list archive) into
the Bugzilla ticket, in a new comment.

Thanks
Laszlo
_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#110613) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------UN2fgceizXzxcBhijuqbTjrV--