Re: [edk2-devel] [PATCH v2 15/30] EmbeddedPkg: Add PcdPrePiCpuIoSize width for LOONGARCH64

["Leif Lindholm" <quic_llindhol@quicinc.com>]

On 2023-11-06 03:29, Chao Li wrote:
> Added LoongArch64 architecture CPU IO width.
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=4584
> 
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Signed-off-by: Chao Li <lichao@loongson.cn>

Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

I note that as a result of this we are now definining this token 
individually for 5 different architectures, in order to provide two 
different default values. We should probably look at consolidating 
those, but that responsibility doesn't have to land on this set.

/
     Leif

> ---
>   EmbeddedPkg/EmbeddedPkg.dec | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec
> index 341ef5e6a6..241d4f3acc 100644
> --- a/EmbeddedPkg/EmbeddedPkg.dec
> +++ b/EmbeddedPkg/EmbeddedPkg.dec
> @@ -165,6 +165,9 @@
>   [PcdsFixedAtBuild.X64]
>     gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|16|UINT8|0x00000011
>   
> +[PcdsFixedAtBuild.LOONGARCH64]
> +  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|16|UINT8|0x00000011
> +
>   [PcdsFixedAtBuild.common, PcdsDynamic.common]
>     #
>     # Value to add to a host address to obtain a device address, using



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111289): https://edk2.groups.io/g/devel/message/111289
Mute This Topic: https://groups.io/mt/102413876/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-