Re: [PATCH v3 2/4] Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf

[Laszlo Ersek <lersek@redhat.com>]

On 01/05/17 22:49, Leo Duran wrote:
> From: Brijesh Singh <brijesh.singh@amd.com>
> 
> This patch adds the new BaseIoFifoLib (IoFifoLib class) library
> consumed by the UefiCpuPkg/CpuIo2Dxe driver.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> Signed-off-by: Leo Duran  <leo.duran@amd.com>
> ---
>  CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc    | 3 +++
>  CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 3 +++
>  DuetPkg/DuetPkgIa32.dsc                          | 2 ++
>  DuetPkg/DuetPkgX64.dsc                           | 2 ++
>  OvmfPkg/OvmfPkgIa32.dsc                          | 2 ++
>  OvmfPkg/OvmfPkgIa32X64.dsc                       | 2 ++
>  OvmfPkg/OvmfPkgX64.dsc                           | 2 ++
>  QuarkPlatformPkg/Quark.dsc                       | 2 ++
>  QuarkPlatformPkg/QuarkMin.dsc                    | 2 ++
>  UefiCpuPkg/UefiCpuPkg.dsc                        | 2 ++
>  Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc          | 2 ++
>  Vlv2TbltDevicePkg/PlatformPkgIA32.dsc            | 2 ++
>  Vlv2TbltDevicePkg/PlatformPkgX64.dsc             | 2 ++
>  13 files changed, 28 insertions(+)

The OvmfPkg hunks look good to me, but I believe you missed my request
that the patch be split per top level Pkg directory (that is, into 6
patchets).

https://lists.01.org/pipermail/edk2-devel/2017-January/006193.html

(I do see you implemented the xfuncname configuration; thanks for that!)

Thanks!
Laszlo