public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Leo Duran <leo.duran@amd.com>, edk2-devel@ml01.01.org
Cc: ruiyu.ni@intel.com, brijesh.singh@amd.com,
	jordan.l.justen@intel.com, liming.gao@intel.com,
	michael.d.kinney@intel.com, jeff.fan@intel.com,
	prince.agyeman@intel.com, david.wei@intel.com
Subject: Re: [PATCH v3 2/4] Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
Date: Fri, 6 Jan 2017 12:23:30 +0100	[thread overview]
Message-ID: <946aac1b-4f8d-7257-8a10-12b32048ce0b@redhat.com> (raw)
In-Reply-To: <1483652965-14357-3-git-send-email-leo.duran@amd.com>

On 01/05/17 22:49, Leo Duran wrote:
> From: Brijesh Singh <brijesh.singh@amd.com>
> 
> This patch adds the new BaseIoFifoLib (IoFifoLib class) library
> consumed by the UefiCpuPkg/CpuIo2Dxe driver.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> Signed-off-by: Leo Duran  <leo.duran@amd.com>
> ---
>  CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc    | 3 +++
>  CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 3 +++
>  DuetPkg/DuetPkgIa32.dsc                          | 2 ++
>  DuetPkg/DuetPkgX64.dsc                           | 2 ++
>  OvmfPkg/OvmfPkgIa32.dsc                          | 2 ++
>  OvmfPkg/OvmfPkgIa32X64.dsc                       | 2 ++
>  OvmfPkg/OvmfPkgX64.dsc                           | 2 ++
>  QuarkPlatformPkg/Quark.dsc                       | 2 ++
>  QuarkPlatformPkg/QuarkMin.dsc                    | 2 ++
>  UefiCpuPkg/UefiCpuPkg.dsc                        | 2 ++
>  Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc          | 2 ++
>  Vlv2TbltDevicePkg/PlatformPkgIA32.dsc            | 2 ++
>  Vlv2TbltDevicePkg/PlatformPkgX64.dsc             | 2 ++
>  13 files changed, 28 insertions(+)

The OvmfPkg hunks look good to me, but I believe you missed my request
that the patch be split per top level Pkg directory (that is, into 6
patchets).

https://lists.01.org/pipermail/edk2-devel/2017-January/006193.html

(I do see you implemented the xfuncname configuration; thanks for that!)

Thanks!
Laszlo



  reply	other threads:[~2017-01-06 11:23 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-05 21:49 [PATCH v3 0/4] BaseIoFifoLib Leo Duran
2017-01-05 21:49 ` [PATCH v3 1/4] MdePkg: Add BaseIoFifoLib library Leo Duran
2017-01-05 21:49 ` [PATCH v3 2/4] Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf Leo Duran
2017-01-06 11:23   ` Laszlo Ersek [this message]
2017-01-06 15:28     ` Duran, Leo
2017-01-05 21:49 ` [PATCH v3 3/4] Modify UefiCpuPkg/CpuIo2Dxe to use new BaseIoFifoLib library Leo Duran
2017-01-05 21:49 ` [PATCH v3 4/4] Modify QemuFwCfgLib " Leo Duran
2017-01-06 11:36   ` Laszlo Ersek
2017-01-06 15:31     ` Duran, Leo
2017-01-06  6:02 ` [PATCH v3 0/4] BaseIoFifoLib Gao, Liming
2017-01-06 11:12   ` Laszlo Ersek
2017-01-06 15:23     ` Duran, Leo
2017-01-07  0:49       ` Jordan Justen
2017-01-07 17:16         ` Duran, Leo
2017-01-09  3:10           ` Gao, Liming
2017-01-09 14:22             ` Duran, Leo
2017-01-09 14:30               ` Duran, Leo
2017-01-09 14:36                 ` Duran, Leo
2017-01-09 15:13               ` Laszlo Ersek
2017-01-09 16:37                 ` Duran, Leo
2017-01-09 22:41                   ` Jordan Justen
2017-01-10  5:33               ` Gao, Liming
2017-01-10  5:48                 ` Duran, Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=946aac1b-4f8d-7257-8a10-12b32048ce0b@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox