From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 923A9819F7 for ; Fri, 6 Jan 2017 03:23:34 -0800 (PST) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1536C8F286; Fri, 6 Jan 2017 11:23:35 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-54.phx2.redhat.com [10.3.116.54]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v06BNVgx030185; Fri, 6 Jan 2017 06:23:32 -0500 To: Leo Duran , edk2-devel@ml01.01.org References: <1483652965-14357-1-git-send-email-leo.duran@amd.com> <1483652965-14357-3-git-send-email-leo.duran@amd.com> Cc: ruiyu.ni@intel.com, brijesh.singh@amd.com, jordan.l.justen@intel.com, liming.gao@intel.com, michael.d.kinney@intel.com, jeff.fan@intel.com, prince.agyeman@intel.com, david.wei@intel.com From: Laszlo Ersek Message-ID: <946aac1b-4f8d-7257-8a10-12b32048ce0b@redhat.com> Date: Fri, 6 Jan 2017 12:23:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1483652965-14357-3-git-send-email-leo.duran@amd.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 06 Jan 2017 11:23:35 +0000 (UTC) Subject: Re: [PATCH v3 2/4] Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2017 11:23:34 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 01/05/17 22:49, Leo Duran wrote: > From: Brijesh Singh > > This patch adds the new BaseIoFifoLib (IoFifoLib class) library > consumed by the UefiCpuPkg/CpuIo2Dxe driver. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Brijesh Singh > Signed-off-by: Leo Duran > --- > CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 3 +++ > CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 3 +++ > DuetPkg/DuetPkgIa32.dsc | 2 ++ > DuetPkg/DuetPkgX64.dsc | 2 ++ > OvmfPkg/OvmfPkgIa32.dsc | 2 ++ > OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ > OvmfPkg/OvmfPkgX64.dsc | 2 ++ > QuarkPlatformPkg/Quark.dsc | 2 ++ > QuarkPlatformPkg/QuarkMin.dsc | 2 ++ > UefiCpuPkg/UefiCpuPkg.dsc | 2 ++ > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 2 ++ > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 2 ++ > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 2 ++ > 13 files changed, 28 insertions(+) The OvmfPkg hunks look good to me, but I believe you missed my request that the patch be split per top level Pkg directory (that is, into 6 patchets). https://lists.01.org/pipermail/edk2-devel/2017-January/006193.html (I do see you implemented the xfuncname configuration; thanks for that!) Thanks! Laszlo