From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5AD5E7803DB for ; Wed, 22 Nov 2023 16:14:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gCkxdfysbA+v4BZNDbvk3kguenv7Wvu2FVNhxIggTHE=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700669639; v=1; b=jX66DZFX96pCvlyyekDFFuJtfUaPnK8iiD04+pw8VjWSV2AZHkBusC9g/lLJ/pEpZgABUvq+ tmRHhLU9GaAB9/rFIrwDFoCeUOSvbQHKYYGBfZgyS5TFf0G+g0PxsxoV0e/FzY137dlTknJaldJ 4vB4yOU8GLAvqgVytYpmLIE0= X-Received: by 127.0.0.2 with SMTP id kE2MYY7687511xCaUzfmNsp8; Wed, 22 Nov 2023 08:13:59 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.23609.1700669638393917060 for ; Wed, 22 Nov 2023 08:13:58 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-gNdrxRtmPh2BeXi_vm_6-w-1; Wed, 22 Nov 2023 11:13:54 -0500 X-MC-Unique: gNdrxRtmPh2BeXi_vm_6-w-1 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F2B68280D206; Wed, 22 Nov 2023 16:13:53 +0000 (UTC) X-Received: from [10.39.193.187] (unknown [10.39.193.187]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EDBBD5028; Wed, 22 Nov 2023 16:13:52 +0000 (UTC) Message-ID: <9472cbc9-7174-3e09-2f27-c900d3fb2359@redhat.com> Date: Wed, 22 Nov 2023 17:13:51 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v3 11/39] UefiCpuPkg: Add LoongArch64 CPU Timer library From: "Laszlo Ersek" To: devel@edk2.groups.io, lichao@loongson.cn Cc: Eric Dong , Ray Ni , Rahul Kumar , Gerd Hoffmann References: <20231117095742.3605778-1-lichao@loongs> <20231117100007.3609080-1-lichao@loongson.cn> <2e42db7c-a927-f47b-7d80-632895b11e1b@redhat.com> In-Reply-To: <2e42db7c-a927-f47b-7d80-632895b11e1b@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: BuWVOIxaGIJfi0gCugjSo5uNx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=jX66DZFX; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/22/23 17:12, Laszlo Ersek wrote: > On 11/17/23 11:00, Chao Li wrote: >> + >> + if (!BaseFreq || !ClockMultiplier || !ClockDivide) { >=20 > (13) The edk2 coding style does not like scalar types *other* than > BOOLEAN to be used in logical context. Please rewrite as: >=20 > (BaseFreq =3D=3D 0) || (ClockMultiplier =3D=3D 0) || (ClockDivide =3D= =3D 0) >=20 >> + DEBUG ((DEBUG_ERROR, "LoongArch Stable Timer is not available in th= e CPU, hence this library cannot be used.\n")); >=20 > (13) I think this line is a bit too long (117 chars). I think the > currently accepted limit (?) is 100 characters (but I'm unsure). >=20 > Recommend to break this up to multiple lines. >=20 >> + StableTimerFreq =3D 0; >=20 Sorry, this was a complex and long review; I messed up the comment numbering -- it seems I made two points (13). :) Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111614): https://edk2.groups.io/g/devel/message/111614 Mute This Topic: https://groups.io/mt/102644766/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-