public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Leif Lindholm <quic_llindhol@quicinc.com>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: fix typo in Arm SetJump
Date: Tue, 3 Oct 2023 14:33:20 +0200	[thread overview]
Message-ID: <949e1652-746e-4284-e38a-07575484148c@linaro.org> (raw)
In-Reply-To: <20231003103918.450453-1-quic_llindhol@quicinc.com>

On 3/10/23 12:39, Leif Lindholm wrote:
> RO -> R0
> 
> Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
> Reported-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> ---
>   MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
> index 15eb3dc28fb7..f89cfa231bbc 100644
> --- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
> +++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
> @@ -33,7 +33,7 @@
>   SetJump
>     MOV  R3, R13
>     STM  R0, {R3-R12,R14}
> -  MOV  RO, #0
> +  MOV  R0, #0

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thanks!


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109291): https://edk2.groups.io/g/devel/message/109291
Mute This Topic: https://groups.io/mt/101731199/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      parent reply	other threads:[~2023-10-03 15:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-03 10:39 [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: fix typo in Arm SetJump Leif Lindholm
2023-10-03 11:22 ` Sami Mujawar
2023-10-03 11:57   ` Leif Lindholm
2023-10-03 12:33 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=949e1652-746e-4284-e38a-07575484148c@linaro.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox