public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: fix typo in Arm SetJump
@ 2023-10-03 10:39 Leif Lindholm
  2023-10-03 11:22 ` Sami Mujawar
  2023-10-03 12:33 ` Philippe Mathieu-Daudé
  0 siblings, 2 replies; 4+ messages in thread
From: Leif Lindholm @ 2023-10-03 10:39 UTC (permalink / raw)
  To: devel; +Cc: Philippe Mathieu-Daudé, Ard Biesheuvel, Sami Mujawar

RO -> R0

Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
Reported-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
---
 MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
index 15eb3dc28fb7..f89cfa231bbc 100644
--- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
+++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
@@ -33,7 +33,7 @@
 SetJump
   MOV  R3, R13
   STM  R0, {R3-R12,R14}
-  MOV  RO, #0
+  MOV  R0, #0
   BX   LR
 
 ;/**
-- 
2.30.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109276): https://edk2.groups.io/g/devel/message/109276
Mute This Topic: https://groups.io/mt/101731199/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: fix typo in Arm SetJump
  2023-10-03 10:39 [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: fix typo in Arm SetJump Leif Lindholm
@ 2023-10-03 11:22 ` Sami Mujawar
  2023-10-03 11:57   ` Leif Lindholm
  2023-10-03 12:33 ` Philippe Mathieu-Daudé
  1 sibling, 1 reply; 4+ messages in thread
From: Sami Mujawar @ 2023-10-03 11:22 UTC (permalink / raw)
  To: Leif Lindholm, devel@edk2.groups.io
  Cc: Philippe Mathieu-Daudé, Ard Biesheuvel, nd

Hi Leif,

Thank you for this fix.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 03/10/2023, 11:39, "Leif Lindholm" <quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com>> wrote:


RO -> R0


Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com>>
Reported-by: Philippe Mathieu-Daudé <philmd@linaro.org <mailto:philmd@linaro.org>>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org <mailto:ardb+tianocore@kernel.org>>
Cc: Sami Mujawar <sami.mujawar@arm.com <mailto:sami.mujawar@arm.com>>
---
MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
index 15eb3dc28fb7..f89cfa231bbc 100644
--- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
+++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
@@ -33,7 +33,7 @@
SetJump
MOV R3, R13
STM R0, {R3-R12,R14}
- MOV RO, #0
+ MOV R0, #0
BX LR


;/**
-- 
2.30.2







-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109278): https://edk2.groups.io/g/devel/message/109278
Mute This Topic: https://groups.io/mt/101731199/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: fix typo in Arm SetJump
  2023-10-03 11:22 ` Sami Mujawar
@ 2023-10-03 11:57   ` Leif Lindholm
  0 siblings, 0 replies; 4+ messages in thread
From: Leif Lindholm @ 2023-10-03 11:57 UTC (permalink / raw)
  To: Sami Mujawar
  Cc: devel@edk2.groups.io, Philippe Mathieu-Daudé, Ard Biesheuvel,
	nd

On Tue, Oct 03, 2023 at 11:22:26 +0000, Sami Mujawar wrote:
> Hi Leif,
> 
> Thank you for this fix.
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Thanks!

Merged as 1497c4b07494.

/
    Leif

> Regards,
> 
> Sami Mujawar
> 
> On 03/10/2023, 11:39, "Leif Lindholm" <quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com>> wrote:
> 
> 
> RO -> R0
> 
> 
> Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com>>
> Reported-by: Philippe Mathieu-Daudé <philmd@linaro.org <mailto:philmd@linaro.org>>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org <mailto:ardb+tianocore@kernel.org>>
> Cc: Sami Mujawar <sami.mujawar@arm.com <mailto:sami.mujawar@arm.com>>
> ---
> MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
> index 15eb3dc28fb7..f89cfa231bbc 100644
> --- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
> +++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
> @@ -33,7 +33,7 @@
> SetJump
> MOV R3, R13
> STM R0, {R3-R12,R14}
> - MOV RO, #0
> + MOV R0, #0
> BX LR
> 
> 
> ;/**
> -- 
> 2.30.2
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109279): https://edk2.groups.io/g/devel/message/109279
Mute This Topic: https://groups.io/mt/101731199/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: fix typo in Arm SetJump
  2023-10-03 10:39 [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: fix typo in Arm SetJump Leif Lindholm
  2023-10-03 11:22 ` Sami Mujawar
@ 2023-10-03 12:33 ` Philippe Mathieu-Daudé
  1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-10-03 12:33 UTC (permalink / raw)
  To: Leif Lindholm, devel; +Cc: Ard Biesheuvel, Sami Mujawar

On 3/10/23 12:39, Leif Lindholm wrote:
> RO -> R0
> 
> Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
> Reported-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> ---
>   MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
> index 15eb3dc28fb7..f89cfa231bbc 100644
> --- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
> +++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
> @@ -33,7 +33,7 @@
>   SetJump
>     MOV  R3, R13
>     STM  R0, {R3-R12,R14}
> -  MOV  RO, #0
> +  MOV  R0, #0

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thanks!


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109291): https://edk2.groups.io/g/devel/message/109291
Mute This Topic: https://groups.io/mt/101731199/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-03 15:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-03 10:39 [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: fix typo in Arm SetJump Leif Lindholm
2023-10-03 11:22 ` Sami Mujawar
2023-10-03 11:57   ` Leif Lindholm
2023-10-03 12:33 ` Philippe Mathieu-Daudé

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox