From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id C5BC2740047 for ; Fri, 26 Jul 2024 11:05:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=vAnTZpVmbCXewFu+Ixl2925Tx6tqe9hBxD3saiHh0C0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1721991937; v=1; b=CgkANGxYIAaQbedacm2PtNgUd4NIN/q4pDbFar6yTqEKt6EHqO7XhP+FpF9ve17XYJ15Zif5 zmewztXLz7w8ym3E4BlT8waNnnqcGkaHQ1d3PGHFItDOBh/EkFA3ZIIbIe9otfZ6wGm/UKa9Xda VuRgxHWNrbIBLkUDvqtjyKZysUfJ0zkqwOmF8Ms1Jb/lUL4MyayAav4qPRl8cUIsyGlkebci65n ucWWiLVskCg4tSMWK2ovaTR3spS0OV4jhmMTe7xvIWcvYEx5kWV0qEYU9mvM86a8JGPT28ge+3z e3DEPtgsQulKLpVPcRox+tOx8lEM5elvlu58/km61elQw== X-Received: by 127.0.0.2 with SMTP id X3BZYY7687511xEgPskRLupk; Fri, 26 Jul 2024 04:05:36 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.58421.1721991935427221797 for ; Fri, 26 Jul 2024 04:05:35 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6562B1007; Fri, 26 Jul 2024 04:06:00 -0700 (PDT) X-Received: from [192.168.1.13] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D042C3F73F; Fri, 26 Jul 2024 04:05:33 -0700 (PDT) Message-ID: <949f9c80-7130-4744-93f6-337aaec6169c@arm.com> Date: Fri, 26 Jul 2024 13:05:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [platforms/devel-dynamictables-reorg PATCH V1 1/1] Platform/ARM/Morello: Check platform specific arch common namespace objects To: Himanshu Sharma , devel@edk2.groups.io Cc: Sami Mujawar , Yeo Reum Yun References: <20240717104300.3770463-1-Himanshu.Sharma@arm.com> From: "PierreGondois" In-Reply-To: <20240717104300.3770463-1-Himanshu.Sharma@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 26 Jul 2024 04:05:35 -0700 Resent-From: pierre.gondois@arm.com Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0AmXftZS0HQbkfUesqToFxUbx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=CgkANGxY; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Himanshu, Thanks for the patch: Reviewed-by: Pierre Gondois Pierre On 7/17/24 12:43, Himanshu Sharma wrote: > Add a check for platform specific arch common namespace object in > ConfigurationManager.c file. >=20 > Signed-off-by: Himanshu Sharma > --- > Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/Confi= gurationManagerFvp.h | 24 +++++++++- > Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/Confi= gurationManager.c | 49 +++++++++++--------- > 2 files changed, 51 insertions(+), 22 deletions(-) >=20 > diff --git a/Platform/ARM/Morello/ConfigurationManager/ConfigurationManag= erDxe/ConfigurationManagerFvp.h b/Platform/ARM/Morello/ConfigurationManager= /ConfigurationManagerDxe/ConfigurationManagerFvp.h > index 744b6095c16c..4a393195ef1a 100644 > --- a/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/C= onfigurationManagerFvp.h > +++ b/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/C= onfigurationManagerFvp.h > @@ -1,6 +1,6 @@ > /** @file > =20 > - Copyright (c) 2021, ARM Limited. All rights reserved.
> + Copyright (c) 2021 - 2024, ARM Limited. All rights reserved.
> =20 > SPDX-License-Identifier: BSD-2-Clause-Patent > =20 > @@ -75,6 +75,28 @@ typedef struct PlatformRepositoryInfo { > =20 > extern EDKII_COMMON_PLATFORM_REPOSITORY_INFO CommonPlatformInfo; > =20 > +/** Return platform specific arch common namespace object. > + > + @param [in] This Pointer to the Configuration Manager Prot= ocol. > + @param [in] CmObjectId The Configuration Manager Object ID. > + @param [in] Token An optional token identifying the object.= If > + unused this must be CM_NULL_TOKEN. > + @param [in, out] CmObject Pointer to the Configuration Manager Obje= ct > + descriptor describing the requested Objec= t. > + > + @retval EFI_SUCCESS Success. > + @retval EFI_INVALID_PARAMETER A parameter is invalid. > + @retval EFI_NOT_FOUND The required object information is not f= ound. > +**/ > +EFI_STATUS > +EFIAPI > +GetArchCommonNameSpaceObjectPlat ( > + IN CONST EDKII_CONFIGURATION_MANAGER_PROTOCOL *CONST This, > + IN CONST CM_OBJECT_ID CmObjectId, > + IN CONST CM_OBJECT_TOKEN Token OPTIONAL= , > + IN OUT CM_OBJ_DESCRIPTOR *CONST CmObject > + ); > + > /** Return platform specific ARM namespace object. > =20 > @param [in] This Pointer to the Configuration Manager Pro= tocol. > diff --git a/Platform/ARM/Morello/ConfigurationManager/ConfigurationManag= erDxe/ConfigurationManager.c b/Platform/ARM/Morello/ConfigurationManager/Co= nfigurationManagerDxe/ConfigurationManager.c > index d3624462aa8a..dce2c2e3801c 100644 > --- a/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/C= onfigurationManager.c > +++ b/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/C= onfigurationManager.c > @@ -800,7 +800,12 @@ GetArchCommonNameSpaceObject ( > PlatformRepo =3D This->PlatRepoInfo; > CommonPlatRepo =3D This->PlatRepoInfo->CommonPlatRepoInfo; > =20 > - switch (GET_CM_OBJECT_ID (CmObjectId)) { > + // Search for the FVP platform specific Arch Common namespace objects > + Status =3D GetArchCommonNameSpaceObjectPlat (This, CmObjectId, Token, = CmObject); > + > + // Get the object if not found in the platform specific search > + if (Status =3D=3D EFI_NOT_FOUND) { > + switch (GET_CM_OBJECT_ID (CmObjectId)) { > case EArchCommonObjPowerManagementProfileInfo: > Status =3D HandleCmObject ( > CmObjectId, > @@ -809,7 +814,7 @@ GetArchCommonNameSpaceObject ( > 1, > CmObject > ); > - break; > + break; > =20 > case EArchCommonObjConsolePortInfo: > Status =3D HandleCmObject ( > @@ -819,7 +824,7 @@ GetArchCommonNameSpaceObject ( > 1, > CmObject > ); > - break; > + break; > =20 > case EArchCommonObjSerialDebugPortInfo: > Status =3D HandleCmObject ( > @@ -829,9 +834,9 @@ GetArchCommonNameSpaceObject ( > 1, > CmObject > ); > - break; > + break; > =20 > -#ifdef HEADLESS_PLATFORM > + #ifdef HEADLESS_PLATFORM > case EArchCommonObjFixedFeatureFlags: > Status =3D HandleCmObject ( > CmObjectId, > @@ -840,8 +845,8 @@ GetArchCommonNameSpaceObject ( > 1, > CmObject > ); > - break; > -#endif > + break; > + #endif > =20 > case EArchCommonObjCmRef: > Status =3D HandleCmObjectSearchPlatformRepo ( > @@ -851,7 +856,7 @@ GetArchCommonNameSpaceObject ( > GetCmObjRefs, > CmObject > ); > - break; > + break; > =20 > case EArchCommonObjProcHierarchyInfo: > Status =3D HandleCmObject ( > @@ -861,7 +866,7 @@ GetArchCommonNameSpaceObject ( > PLAT_PROC_HIERARCHY_NODE_COUNT, > CmObject > ); > - break; > + break; > =20 > case EArchCommonObjCacheInfo: > Status =3D HandleCmObject ( > @@ -871,19 +876,21 @@ GetArchCommonNameSpaceObject ( > ARRAY_SIZE (CommonPlatRepo->CacheInfo), > CmObject > ); > - break; > + break; > =20 > - default: { > - Status =3D EFI_NOT_FOUND; > - DEBUG (( > - DEBUG_INFO, > - "INFO: Object 0x%x. Status =3D %r\n", > - CmObjectId, > - Status > - )); > - break; > - } > - } //switch > + default: > + { > + Status =3D EFI_NOT_FOUND; > + DEBUG (( > + DEBUG_INFO, > + "INFO: Object 0x%x. Status =3D %r\n", > + CmObjectId, > + Status > + )); > + break; > + } > + } // switch > + } // if > =20 > return Status; > } -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120046): https://edk2.groups.io/g/devel/message/120046 Mute This Topic: https://groups.io/mt/107268665/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-