From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nwk-aaemail-lapp01.apple.com (nwk-aaemail-lapp01.apple.com [17.151.62.66]) by mx.groups.io with SMTP id smtpd.web10.701.1590559539151179330 for ; Tue, 26 May 2020 23:05:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=Kd+4P6yu; spf=pass (domain: apple.com, ip: 17.151.62.66, mailfrom: afish@apple.com) Received: from pps.filterd (nwk-aaemail-lapp01.apple.com [127.0.0.1]) by nwk-aaemail-lapp01.apple.com (8.16.0.42/8.16.0.42) with SMTP id 04R5wKk0065100; Tue, 26 May 2020 23:05:34 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=20180706; bh=K5IdTOj5vcH6jGXcskT+z0QPDK1ESMcN0yJY73syyD4=; b=Kd+4P6yuBbskfobfMdx58/yfOj7NkZvV1wqE86X5M4hx7YzU+nT4v1PYG5BAky7bbXKa QH5Rtj/15jRewS4yiC+Arm7VPRKQoJJtYabdXeAE/fwS2+U7xpRfkJMHF+O2R9Iv5ZwI 4sz05bWYCcLhETEUGndXv1duYzIwbS/qx82hqT1SS8OKpT2y33gKAnqt5rhkytjBdA5k +3juNgShpyqS5XQeccEG3hQJCCRkfmem3BDkac0v/O9zPKSnCCpOiJf/1dmWR4ODoYuf IZmVgHpXIwBxczwwjkPqlTDhEtbXhw312v+gIV7grbF3cL9A9+sT1QPMOtps3xF02/ns TA== Received: from rn-mailsvcp-mta-lapp04.rno.apple.com (rn-mailsvcp-mta-lapp04.rno.apple.com [10.225.203.152]) by nwk-aaemail-lapp01.apple.com with ESMTP id 3172s06wby-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 26 May 2020 23:05:34 -0700 Received: from rn-mailsvcp-mmp-lapp02.rno.apple.com (rn-mailsvcp-mmp-lapp02.rno.apple.com [17.179.253.15]) by rn-mailsvcp-mta-lapp04.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPS id <0QAZ00P3O7LAV310@rn-mailsvcp-mta-lapp04.rno.apple.com>; Tue, 26 May 2020 23:05:34 -0700 (PDT) Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp02.rno.apple.com by rn-mailsvcp-mmp-lapp02.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) id <0QAZ00S007540U00@rn-mailsvcp-mmp-lapp02.rno.apple.com>; Tue, 26 May 2020 23:05:34 -0700 (PDT) X-Va-A: X-Va-T-CD: e0acb9dc03d22e4581b62f3d752335f3 X-Va-E-CD: 9f326c5a86eba6addfb60893380f57be X-Va-R-CD: 10bbc8ba876c475f86867ff677dae878 X-Va-CD: 0 X-Va-ID: eb942007-ee78-424c-9c11-5b46dad35c9e X-V-A: X-V-T-CD: e0acb9dc03d22e4581b62f3d752335f3 X-V-E-CD: 9f326c5a86eba6addfb60893380f57be X-V-R-CD: 10bbc8ba876c475f86867ff677dae878 X-V-CD: 0 X-V-ID: 4543b213-61cb-4689-88b5-db0af4211807 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-05-27_01:2020-05-26,2020-05-27 signatures=0 Received: from [17.235.11.158] (unknown [17.235.11.158]) by rn-mailsvcp-mmp-lapp02.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPSA id <0QAZ00LE87L9H000@rn-mailsvcp-mmp-lapp02.rno.apple.com>; Tue, 26 May 2020 23:05:34 -0700 (PDT) MIME-version: 1.0 (Mac OS X Mail 13.0 \(3594.4.17\)) Subject: Re: [edk2-devel] [PATCH 3/3] OvmfwPkg: Don't exclude XCODE Modules From: "Andrew Fish" In-reply-to: <1c4fd1f8-980d-1a18-bf65-34afea2bc2dc@redhat.com> Date: Tue, 26 May 2020 23:05:32 -0700 Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , =?utf-8?Q?Philippe_Mathieu-Daud=C3=A9?= Message-id: <94E14110-7944-40C9-9842-D534B0186878@apple.com> References: <215ac3c5d0c73779d06b6d7463000ee8d1d526fe.1590354726.git.afish@apple.com> <63bcf199-3937-040c-dc2f-26b1d577ede5@redhat.com> <9D1DBCDB-9B2D-4DB2-89C9-F89458C0AA72@apple.com> <1c4fd1f8-980d-1a18-bf65-34afea2bc2dc@redhat.com> To: edk2-devel-groups-io , lersek@redhat.com X-Mailer: Apple Mail (2.3594.4.17) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-05-27_01:2020-05-26,2020-05-27 signatures=0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: quoted-printable > On May 26, 2020, at 4:45 AM, Laszlo Ersek wrote: >=20 > On 05/26/20 06:10, Andrew Fish wrote: >>=20 >>=20 >>> On May 25, 2020, at 12:31 PM, Laszlo Ersek wrote: >>>=20 >>> Hi Andrew, >>>=20 >>> On 05/24/20 23:20, Andrew Fish via groups.io wrote= : >>>> With this BZ getting fixed we no longer need to special case XCODE. >>>>=20 >>>> Cc: Ard Biesheuvel >>>> Cc: Jiewen Yao >>>> Cc: Jordan Justen >>>> Cc: Philippe Mathieu-Daud=C3=A9 >>>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D557 >>>> Signed-off-by: Andrew Fish >>>>=20 >>>> Signed-off-by: Andrew Fish >>>> --- >>>> OvmfPkg/OvmfPkgIa32.dsc | 3 +-- >>>> OvmfPkg/OvmfPkgIa32.fdf | 2 -- >>>> OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++-- >>>> OvmfPkg/OvmfPkgIa32X64.fdf | 2 -- >>>> OvmfPkg/OvmfPkgX64.dsc | 3 +-- >>>> OvmfPkg/OvmfPkgX64.fdf | 2 -- >>>> OvmfPkg/OvmfXen.dsc | 3 +-- >>>> OvmfPkg/OvmfXen.fdf | 2 -- >>>> 8 files changed, 5 insertions(+), 16 deletions(-) >>>=20 >>=20 >> Laszlo, >>=20 >> Thanks for the feedback.=20 >>=20 >> Can I ask that you go to https://www.tianocore.org, click on How to Con= tribute and point me at the chain of links I did not follow, if I missed it= tit is likely due to too many links and too much information being vended. >=20 > You didn't miss anything, starting from that page, I think. I don't > remember ever clicking "How to Contribute" on that page. :) >=20 > In fact if I grep the current edk2-wiki project source, at commit > de8fae02bbcc ("Add acknowledgements page", 2020-05-21), I find no > references to "SetupGit.py". >=20 >> When people are starting out we should vend them the instructions that = work and let them opt in to learning more. >=20 > "Working instructions" is a moving target. When I wrote the unkempt > guide, it was serious work, I had to set aside resources. When we > changed the workflow to replace "git-push" (by maintainers) with github > PRs (to trigger CI), documenting that was again serious work (for Mike > -- Mike updated both the official workflow article and the unkempt > guide, as I couldn't volunteer for the latter). >=20 > The more documentation we add, the larger the burden to update them > grows. It's an on-going commitment. Given the constant scarcity of > developer (and reviewer) cycles, we can only choose between: >=20 > - "code, plus more or less up-to-date docs", and > - "code, plus no docs". >=20 > Leif wrote SetupGit.py in the first place to save people the effort of > going through some of the unkempt guide steps. >=20 > If we decide that no SetupGit.py (or similar utilities) should be > written without documenting them in the wiki, that won't force > contributors to document their workflow-related contributions; it will > cause them to not writing the utilities in the first place. >=20 > Open source development communities teach contributors the workflow by > doing. For example, I have contributed to two open source projects that > are *exclusively* managed on github.com, using "github native" pull > requests and such. (Namely, openssl, and "p11-glue/p11-kit".) I'm the > kind of guy that very carefully reads the documentation first, and > starts pushing the buttons only second, and I *still* got wrong my > initial contributions to both projects. >=20 > With OpenSSL, I missed details of how review worked and details about > the CLA. Maintainers taught me those bits on the PR, while they were > reviewing my code. >=20 > With p11-kit, I had missed that I was expected to write a unit test at > once, for the new code. Maintainers pointed that out in my PR. >=20 > I posit that virtually no up-to-date technical documentation exists > unless an organization treats that documentation as a *product* (with > its own resource allocations, technical writers, subject matter expert > reviewers, project managers, and so on). >=20 >>=20 >>> (1) Please run "BaseTools/Scripts/SetupGit.py" in your edk2 clone, >>> because right now, the patch is formatted/posted with too many CR >>> characters. >>>=20 >>=20 >> I filed https://bugzilla.tianocore.org/show_bug.cgi?id=3D2767 since I p= assed PatchCheck.py but did not run BaseTools/Scripts/SetupGit.py >=20 > Thanks. >=20 > For the record: I didn't reject your contribution (I'm very happy you > posted a patch series); instead, I asked for an update. >=20 Lazlo, I understand that is just a tooling issue on my side. Sorry for my delay i= n fixing up the patches but I have some higher priority work PRs I need to = get resolved and that is delaying me fixing up the patch set.=20 At my work we have a tradition of trying to update our documentation when = we onboard new people as that new set of eyes helps point out the small thi= ngs that could have saved people a lot of time. So I'm not so much complai= ning, but just trying to help.=20 > In particular, the number of empty lines inserted into the DSC files is > not consistent across the OVMF DSC files, and that fact has nothing to > do with git configuration -- it would need fixing identically even if > the series had been submitted via a github.com PR. >=20 My brain is a little dyslexic so I tend to miss symmetry things like this = when I review my own work, but that is why we review the code.=20 Thanks, Andrew Fish > Thanks > Laszlo >=20 >=20 >=20 >=20