From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DE28321E43B5B for ; Fri, 22 Sep 2017 07:50:36 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 73FD77F3E5; Fri, 22 Sep 2017 14:53:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 73FD77F3E5 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-219.rdu2.redhat.com [10.10.120.219]) by smtp.corp.redhat.com (Postfix) with ESMTP id 708FD6E703; Fri, 22 Sep 2017 14:53:43 +0000 (UTC) To: "Carsey, Jaben" , Ard Biesheuvel Cc: "Ni, Ruiyu" , "edk2-devel@lists.01.org" References: <20170922133456.8910-1-lersek@redhat.com> <49664C7F-F0AA-46AF-84A2-05F322BDB053@linaro.org> From: Laszlo Ersek Message-ID: <94ba0db6-b7b2-ac6f-58e5-1c8309061668@redhat.com> Date: Fri, 22 Sep 2017 16:53:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 22 Sep 2017 14:53:44 +0000 (UTC) Subject: Re: [PATCH] ShellPkg/DmpStore: fix GCC/CLANG build failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Sep 2017 14:50:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/22/17 16:00, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey Thank you both; pushed as commit ba30d5f05121. Laszlo >> -----Original Message----- >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> Sent: Friday, September 22, 2017 6:44 AM >> To: Laszlo Ersek >> Cc: edk2-devel@lists.01.org; Carsey, Jaben ; Ni, >> Ruiyu ; Shi, Steven >> Subject: Re: [PATCH] ShellPkg/DmpStore: fix GCC/CLANG build failure >> Importance: High >> >> >> >> On 22 Sep 2017, at 06:34, Laszlo Ersek wrote: >> >>>> ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c:525:66: >> error: >>>> passing argument 2 of 'gEfiShellProtocol->GetGuidName' from >> incompatible >>>> pointer type [-Werror=incompatible-pointer-types] >>>> >>>> Status = gEfiShellProtocol->GetGuidName(&FoundVarGuid, >> &GuidName); >>>> ^ >>>> ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c:525:66: >> note: >>>> expected 'const CHAR16 ** {aka const short unsigned int **}' but >>>> argument is of type 'CHAR16 ** {aka short unsigned int **}' >>> >>> Pointer-to-(pointer-to-CHAR16) and pointer-to-(pointer-to-const-CHAR16) >>> are incompatible types; GCC and CLANG are right to complain. >>> >>> Cc: Ard Biesheuvel >>> Cc: Jaben Carsey >>> Cc: Ruiyu Ni >>> Cc: Steven Shi >>> Reported-by: Jenkins Build Host >>> Reported-by: Steven Shi >>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=716 >>> Fixes: 09e8678380aaaf0a5ef59179ff59e0a045d1b0bf >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Laszlo Ersek >>> --- >>> >>> Notes: >>> I'm going to push this as soon as I get an R-b from anyone. >>> >> >> Reviewed-by: Ard Biesheuvel >> >>> Thanks >>> Laszlo >>> >>> ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c >> b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c >>> index 062ab5dc3a9a..5791da9acc8c 100644 >>> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c >>> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c >>> @@ -424,7 +424,7 @@ CascadeProcessVariables ( >>> CHAR16 *AttrString; >>> CHAR16 *HexString; >>> EFI_STATUS SetStatus; >>> - CHAR16 *GuidName; >>> + CONST CHAR16 *GuidName; >>> >>> if (ShellGetExecutionBreakFlag()) { >>> return (SHELL_ABORTED); >>> -- >>> 2.14.1.3.gb7cf6e02401b >>> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >