Re: [edk2-devel] [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64

["Rebecca Cran" <quic_rcran@quicinc.com>]

On 9/6/22 11:53, Ard Biesheuvel wrote:
> On Tue, 6 Sept 2022 at 19:01, Rebecca Cran <quic_rcran@quicinc.com> wrote:
>> My only concern is about the call in MpServicesTest:
>>
>> WriteBackDataCacheRange ((VOID *)&ApFunction, 32);
>>
>> Obviously the '32' is a magic number and should be something based on the size of ApFunction.
>> But I don't think there's a portable way to calculate what that value should be.
>>
> Why exactly do we need that call?
>
> I understand that some of the code needs to be clean to the PoC (on
> ARM) so that the AP can fetch instructions with the MMU and caches
> disabled. But the actual routine passed into the API is called with
> the MMU and caches on, right?

It's a leftover from the work you did on the code, before I changed it to have the MMU and caches enabled on the APs.
I'll go through and remove it and any others for the v2 patch which I'll send out later today (which will also fix the Usage text for MpServicesTest).

-- 
Rebecca Cran