From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 05CB62117D270 for ; Mon, 22 Oct 2018 22:46:16 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2018 22:46:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,414,1534834800"; d="scan'208";a="84800845" Received: from shzintpr02.sh.intel.com (HELO [10.7.209.51]) ([10.239.4.160]) by orsmga006.jf.intel.com with ESMTP; 22 Oct 2018 22:46:13 -0700 To: Paulo Alcantara , Hao Wu , edk2-devel@lists.01.org Cc: Ruiyu Ni , Jiewen Yao , star.zeng@intel.com References: <20181016072340.22068-1-hao.a.wu@intel.com> <877eia3v0i.fsf@paulo.ac> From: "Zeng, Star" Message-ID: <95020a46-058c-d19f-9d6b-bdcd8c778065@intel.com> Date: Tue, 23 Oct 2018 13:45:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <877eia3v0i.fsf@paulo.ac> Subject: Re: [PATCH v1 00/10] UDF: Bugfixes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 05:46:17 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2018/10/22 22:39, Paulo Alcantara wrote: > Hao Wu writes: > >> The series will address a couple of bugs within the UDF related codes. >> >> Please refer to the log message of each commit for more details. >> >> Cc: Paulo Alcantara >> Cc: Ruiyu Ni >> Cc: Jiewen Yao >> Cc: Star Zeng >> >> Hao Wu (10): >> MdeModulePkg/PartitionDxe: Add check for underlying device block size >> MdeModulePkg/UdfDxe: Refine boundary checks for file/path name string >> MdeModulePkg/UdfDxe: Add boundary check the read of FE/EFE >> MdeModulePkg/UdfDxe: Add boundary check for ComponentIdentifier decode >> MdeModulePkg/UdfDxe: Add boundary check for getting volume (free) size >> MdeModulePkg/UdfDxe: Correct behavior for UdfSetPosition() >> MdeModulePkg/UdfDxe: Fix a typo within SetFileInfo() >> MdeModulePkg/UdfDxe: Update GetInfo() for FS VolumeLabel info request >> MdeModulePkg/UdfDxe: Add more check when getting PD from LongAd >> MdeModulePkg/UdfDxe: Avoid possible use of already-freed data >> >> MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 28 +++ >> MdeModulePkg/Universal/Disk/UdfDxe/File.c | 96 ++++---- >> MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 253 ++++++++++++++++++-- >> MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 63 ++++- >> MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf | 1 + >> 5 files changed, 362 insertions(+), 79 deletions(-) > > For the series: > > Reviewed-by: Paulo Alcantara I could not review the in detail. Thanks Paulo's Reviewed-by. I have two minor feedback. 1. I saw some place using 'basic validations' and some place using 'basic validation', should they be aligned? 2. I think you can add "Copyright (c) 2018, Intel Corporation. All rights reserved.
" for every file you changed. Acked-by: Star Zeng Thanks, Star > > Thanks! > Paulo >