From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B482F8224E for ; Tue, 21 Feb 2017 18:41:04 -0800 (PST) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 46E5161D17; Wed, 22 Feb 2017 02:41:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-134.phx2.redhat.com [10.3.116.134]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1M2f4hW015487; Tue, 21 Feb 2017 21:41:04 -0500 To: Jordan Justen References: <20170221153812.1420-1-lersek@redhat.com> <148772868625.12591.11299125496281974778@jljusten-ivb> From: Laszlo Ersek Cc: edk2-devel-01 Message-ID: <95215212-5345-08e8-b941-417cd736b427@redhat.com> Date: Wed, 22 Feb 2017 03:41:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <148772868625.12591.11299125496281974778@jljusten-ivb> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 22 Feb 2017 02:41:05 +0000 (UTC) Subject: Re: [PATCH 0/6] OvmfPkg: AcpiPlatformDxe, QemuFwCfg: small cleanups after WRITE_POINTER X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2017 02:41:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 02/22/17 02:58, Jordan Justen wrote: > Good cleanups. Thanks for taking the extra time sort these out! You made good points, so thanks for those :) Also, stale comments are sometimes worse than no comments, so I wanted to clean up those too. > Reviewed-by: Jordan Justen Ha! I for one welcome another one of our ultra fast reviewer overlords! :) Series committed as b9d56d0b93ae..ed1a2d42d5d5. > Unfortunately, https://bugzilla.tianocore.org/show_bug.cgi?id=394 may > not be quite so 'fun'. :) Stay tuned, I'm already working on that :) Thanks! Laszlo > -Jordan > > On 2017-02-21 07:38:06, Laszlo Ersek wrote: >> Most of these were suggested by Jordan. >> >> Cc: Jordan Justen >> >> Repo: https://github.com/lersek/edk2.git >> Branch: write_pointer_followup >> >> Thanks! >> Laszlo >> >> Laszlo Ersek (6): >> OvmfPkg/AcpiPlatformDxe: drop double right shift in ADD/WRITE POINTER >> cmds >> OvmfPkg/AcpiPlatformDxe: update PointerValue comments in >> "BootScript.c" >> OvmfPkg/QemuFwCfgLib: move types/macros from lib class to >> IndustryStandard >> OvmfPkg/QemuFwCfg: introduce FW_CFG_IO_SELECTOR, adapt the package >> OvmfPkg/QemuFwCfg: introduce FW_CFG_IO_DATA, adapt the package >> OvmfPkg/QemuFwCfg: introduce FW_CFG_IO_DMA_ADDRESS, adapt the package >> >> OvmfPkg/Include/IndustryStandard/QemuFwCfg.h | 104 ++++++++++++++++++++ >> OvmfPkg/Include/Library/QemuFwCfgLib.h | 70 +------------ >> OvmfPkg/AcpiPlatformDxe/BootScript.c | 18 ++-- >> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 8 +- >> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 12 +-- >> OvmfPkg/SmmControl2Dxe/SmiFeatures.c | 6 +- >> 6 files changed, 128 insertions(+), 90 deletions(-) >> create mode 100644 OvmfPkg/Include/IndustryStandard/QemuFwCfg.h >> >> -- >> 2.9.3 >>