From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3697B9410EB for ; Thu, 3 Aug 2023 07:07:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=jFlGqMBB5VIO2PXjl47EyO4IU5BNZSxYh1SKoDrlmz8=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1691046477; v=1; b=ewMqRmF1sjz+BqAIW16kbE3323AMMg3gSZRHFmHqffq4wP44cMRd9jc8Uo/EInfRGmu2z8tE utLmXhXq3+n3AN5C3Mvy+TKFmfULg4W0SqkgpnlFTcG8sR+fOzUBAPjtMBhnzvdjDAEPL4IeD9J md/P849JZxwAkqN7vUOVPkyM= X-Received: by 127.0.0.2 with SMTP id kAISYY7687511xtT7xoLXbcY; Thu, 03 Aug 2023 00:07:57 -0700 Subject: Re: [edk2-devel] [PATCH v1 05/11] DynamicTablesPkg: Update MADT generator for ACPI 6.5 To: Jeshua Smith ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Bengaluru, Karnataka, IN (223.233.87.165) X-Originating-Platform: Mac Firefox 115 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Thu, 03 Aug 2023 00:07:57 -0700 References: In-Reply-To: Message-ID: <9522.1691046477373643013@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vAtRaJWhORwvpTd7xvVYfC3Px7686176AA= Content-Type: multipart/alternative; boundary="NdGx2ARPOSdRZXrzVc4a" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ewMqRmF1; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --NdGx2ARPOSdRZXrzVc4a Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Jeshua, Thank you for the feedback. On Tue, Aug 1, 2023 at 08:44 AM, Jeshua Smith wrote: >=20 > It looks like you are setting the wrong field here (should be > TrbeInterrupt, not SpeOverflowInterrupt): > + // Setting TrbeInterrupt to 0 ensures backward compatibility with > + // ACPI 6.4 > + Gicc->SpeOverflowInterrupt =3D 0; Indeed this is a bug. I will address this in the v2 series. Regards, Sami Mujawar -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107523): https://edk2.groups.io/g/devel/message/107523 Mute This Topic: https://groups.io/mt/100347387/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --NdGx2ARPOSdRZXrzVc4a Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Jeshua,

Thank you for the feedback.

On Tue, Aug 1,= 2023 at 08:44 AM, Jeshua Smith wrote:
It looks like you are setting the wrong field here (should be T= rbeInterrupt, not SpeOverflowInterrupt):
+ // Setting TrbeInterrupt to= 0 ensures backward compatibility with
+ // ACPI 6.4
+ Gicc->S= peOverflowInterrupt =3D 0;
Indeed this is a bug. I will address this in the v2 series.

Rega= rds,

Sami Mujawar
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#107523) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--NdGx2ARPOSdRZXrzVc4a--