Re: [PATCH V2 2/4] UefiCpuPkg/CpuDxe: Implement Cpu2 protocol

["Laszlo Ersek" <lersek@redhat.com>]

On 07/11/19 04:36, Gao, Zhichao wrote:
> 
> 
>> -----Original Message-----
>> From: Dong, Eric
>> Sent: Thursday, July 11, 2019 10:22 AM
>> To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
>> Cc: Sean Brogan <sean.brogan@microsoft.com>; Ni, Ray <ray.ni@intel.com>;
>> Laszlo Ersek <lersek@redhat.com>; Gao, Liming <liming.gao@intel.com>;
>> Michael Turner <Michael.Turner@microsoft.com>; Bret Barkelew
>> <Bret.Barkelew@microsoft.com>
>> Subject: RE: [PATCH V2 2/4] UefiCpuPkg/CpuDxe: Implement Cpu2 protocol
>>
>> Hi Zhizhao,
>>
>> The new add files don't have copyright info, is it ok?

Good catch!

> I forgot add file comment for Ia32/EnableInterruptsAndSleep.c. Also lose the BSD+Patent License. I would add them in the future.
> For the copyright:
> The code is contributed by Microsoft at https://github.com/Microsoft/mu_basecore/blob/release/201808/MdePkg/Library/BaseLib/X64/EnableInterrupts.nasm#L48
> I move the code from MdePkg to UefiCpuPkg to a single file. It is inappropriate to add both intel (not contributor) and Microsoft (they didn't add in the above link).
> So I keep the copyright blank. I don't know whether it is ok without copyright.

Every single source file must have both copyright notice(s) and
licensing information.

- Licensing information without copyright holder(s) makes zero sense --
the licensing terms are offered / dictated *by* the copyright holders.

- A copyright notice in itself, without a suitable license (including
the "no license" case) does not provide us with the necessary rights to
carry the source file in the edk2 project.

Regarding "EnableInterrupts.nasm". This looks like a tricky situation.
Under the above link, the file is currently missing a Microsoft (C)
notice (the last commit to modify the file is apparently from Microsoft,
b621971). So that should be addressed in Project Mu first, in my opinion.

Then, Microsoft should please relicense the file under BSD+Patent, from
pure 2-BSD. If they disagree, then the 2-BSD is still acceptable for edk2.

Then, the file could be imported into edk2, carrying
- the MS (C) notice,
- the Intel (C) notice (extended to 2019),
- the license -- BSD+Patent, or else 2-BSD --, expressed with an SPDX ID
(not open-coded license text).

Note: I'm not a lawyer; the above is just my opinion. CC'ing the other
stewards.

Thanks,
Laszlo

> 
> Hi Liming,
> 
> What's your opinion?
> 
> Thanks,
> Zhichao
> 
>>
>> Thanks,
>> Eric
>>
>>> -----Original Message-----
>>> From: Gao, Zhichao
>>> Sent: Tuesday, July 9, 2019 4:40 PM
>>> To: devel@edk2.groups.io
>>> Cc: Sean Brogan <sean.brogan@microsoft.com>; Dong, Eric
>>> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo Ersek
>>> <lersek@redhat.com>; Gao, Liming <liming.gao@intel.com>; Michael
>>> Turner <Michael.Turner@microsoft.com>; Bret Barkelew
>>> <Bret.Barkelew@microsoft.com>
>>> Subject: [PATCH V2 2/4] UefiCpuPkg/CpuDxe: Implement Cpu2 protocol
>>>
>>> From: Sean Brogan <sean.brogan@microsoft.com>
>>>
>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1400
>>>
>>> Implement Cp2 protocol: it has one interface to enable the interrupt
>>> and put cpu to sleep and wait for an interrupt.
>>>
>>> Cc: Eric Dong <eric.dong@intel.com>
>>> Cc: Ray Ni <ray.ni@intel.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Liming Gao <liming.gao@intel.com>
>>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>>> Cc: Michael Turner <Michael.Turner@microsoft.com>
>>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>>> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
>>> ---
>>>  UefiCpuPkg/CpuDxe/CpuDxe.c                    | 38 +++++++++++++++++++
>>>  UefiCpuPkg/CpuDxe/CpuDxe.h                    | 25 ++++++++++++
>>>  UefiCpuPkg/CpuDxe/CpuDxe.inf                  |  3 ++
>>>  .../CpuDxe/Ia32/EnableInterruptsAndSleep.c    | 24 ++++++++++++
>>>  .../CpuDxe/X64/EnableInterruptsAndSleep.nasm  | 31 +++++++++++++++
>>>  5 files changed, 121 insertions(+)
>>>  create mode 100644
>> UefiCpuPkg/CpuDxe/Ia32/EnableInterruptsAndSleep.c
>>>  create mode 100644
>>> UefiCpuPkg/CpuDxe/X64/EnableInterruptsAndSleep.nasm
>>>