From: Laszlo Ersek <lersek@redhat.com>
To: "Long, Qin" <qin.long@intel.com>, "Ye, Ting" <ting.ye@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v2 1/2] CryptoPkg/OpensslLib: Fix the documentation about submodule update
Date: Thu, 12 Apr 2018 14:05:00 +0200 [thread overview]
Message-ID: <9546947a-8d08-829b-c597-ab97e4e2c556@redhat.com> (raw)
In-Reply-To: <BF2CCE9263284D428840004653A28B6E540A2D18@SHSMSX103.ccr.corp.intel.com>
On 04/12/18 12:03, Long, Qin wrote:
>
> Ah, "it's wrong here" means "the existence of "--remote" in original suggested command is wrong".
> "It's important" looks also make sense to address the "update" goal. I can update that, if old message will cause confusion.
Ah, you used "for" in the sense of "because". :)
Yup, please clarify the commit message a little bit, I was indeed
confused by it.
Thanks!
Laszlo
>
>
> Best Regards & Thanks,
> LONG, Qin
>
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Thursday, April 12, 2018 5:56 PM
> To: Long, Qin <qin.long@intel.com>; Ye, Ting <ting.ye@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: Re: [PATCH v2 1/2] CryptoPkg/OpensslLib: Fix the documentation about submodule update
>
> Hello Qin,
>
> On 04/12/18 05:08, Long Qin wrote:
>> This patch is to drop "--remote" option from the original suggested
>> submodule update command ("$ git submodule update --recursive
>> --remote") in HOWTO document.
>>
>> "--remote" option will integrate changes from the upstream subproject
>> with the submodules's "current HEAD", instead of using the edk2
>> superproject's "recorded SHA-1". It is wrong here for the edk2
>
> The commit message makes sense, and the patch is good, but I think there's a significant typo in the commit message.
>
> Namely, the word "wrong" is wrong :) Instead, it should be "important".
>
> Or else, "it is the goal for the edk2 consumes to ...".
>
> Do you agree?
>
> (I'll come to the second patch sometime later.)
>
> Thanks!
> Laszlo
>
>> consumers to updating the working tree of the submodules to match the
>> commit / release tag that the superproject expects.
>>
>> Removing "--remote" option to fix the documentation issue here.
>>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ye Ting <ting.ye@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Long Qin <qin.long@intel.com>
>> ---
>> CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt
>> b/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt
>> index ac63d4c077..36f8e711dd 100644
>> --- a/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt
>> +++ b/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt
>> @@ -40,7 +40,7 @@ or
>> And use the following combined commands to pull the remote
>> submodule updates (e.g. Updating the new supported OpenSSL release tag):
>> $ git pull --recurse-submodules && \
>> - git submodule update --recursive --remote
>> + git submodule update --recursive
>>
>> =============================================================================
>> About process_files.pl
>>
>
next prev parent reply other threads:[~2018-04-12 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 3:07 [PATCH v2 0/2] Update OpenSSL version to 1.1.0h Long Qin
2018-04-12 3:08 ` [PATCH v2 1/2] CryptoPkg/OpensslLib: Fix the documentation about submodule update Long Qin
2018-04-12 9:55 ` Laszlo Ersek
2018-04-12 10:03 ` Long, Qin
2018-04-12 12:05 ` Laszlo Ersek [this message]
2018-04-13 20:03 ` Laszlo Ersek
2018-04-12 3:08 ` [PATCH v2 2/2] CryptoPkg/OpensslLib: Update OpenSSL version to 1.1.0h Long Qin
2018-04-13 20:07 ` Laszlo Ersek
2018-04-15 13:17 ` Long, Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9546947a-8d08-829b-c597-ab97e4e2c556@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox