From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.82]) by mx.groups.io with SMTP id smtpd.web11.13946.1670415908613966001 for ; Wed, 07 Dec 2022 04:25:09 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=WcpUud9q; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.82, mailfrom: alexey.kardashevskiy@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=juBHjDrGolOJbQFbxbf7UoPhRK4UvEGbjrJUNrfvwmWXbSyrbm+o28uQOxs5XYJCPL8g+di0NyDBBbEgP3QUy5S6rUkFo1iacEWNPJtZfeNm9TGGkWg+CR33bfQyyFdaPjEur55PbWkycxipHg9oxRBdVMUaqI2i6rJh70OoPUuMM0vEJn6mFOUOMRmhKqyyX2I9CevAQozzn/U2LzDy+GFWDCXhc+bbzR97iFL8wuHycJzs48Z9HGYEWCDbnSYnCof17GkACDhcK98aRh989jpY8ORfWM+ODVPMR00vmJdJrdAUAurepQgO1P+WFgpqNlpMsNSf4oPYKcu+Zyr8nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cd7RQ4CaVO7k5iNsJFvpxV1Elz3g++VNGxeVa1il100=; b=PFfVUNEEkhtHBiAW1+62ISigquecS6y4bOJogFsPRaFFlk0T2p5I+EZMpI3bov41XPYgiJo+fWRdzQzxOSiLJpLdcEDiuMxeisw35oiGpyP9MBTZSzNlSwEwYp1WYHdPCqDs51Vi3qoOnYkbxMyi6oQfUi89BTnmu6DJx1pRu6jIgOV9yLucZYRE8dC4PNpqcmoyCSh4Q9XcmP9euGk+3OFpDH4YSdMHTacimfaUqKKRjc6dqawRVOLzLhVO2za5scbIsh/KgXsi45mmDenFWTj7LNvY+vAhc32uk3h/CM/agwbCHRj/BeIL3TV82fDAQq0vHCr1a+gFA0ehFf1r9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cd7RQ4CaVO7k5iNsJFvpxV1Elz3g++VNGxeVa1il100=; b=WcpUud9q9H6Tv0pvgYorYrUXb8sc1rS8ufSBi7vWlOvMcUssalDw7vsVnYLSoc8zhYjiysrAG72eT7FucJf/PDdH1WqUSFNAOVoPg3hy64pDXDv+voPq5ICqyUmmRO73LoRU2f6XT5mmnRDSKXcvxzI8CZxDSQF6RgMYBO0X8F0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB2843.namprd12.prod.outlook.com (2603:10b6:5:48::24) by MW3PR12MB4490.namprd12.prod.outlook.com (2603:10b6:303:2f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 12:25:06 +0000 Received: from DM6PR12MB2843.namprd12.prod.outlook.com ([fe80::7dc4:8eb:cc3c:3cd4]) by DM6PR12MB2843.namprd12.prod.outlook.com ([fe80::7dc4:8eb:cc3c:3cd4%6]) with mapi id 15.20.5880.014; Wed, 7 Dec 2022 12:25:06 +0000 Message-ID: <9581bf9d-3e3c-f2f4-7967-a31799eb8f01@amd.com> Date: Wed, 7 Dec 2022 23:24:57 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCBvdm1mIDEvNV0gTWRlUGtnL1JlZ2lzdGVyL0FtZDogRGVmaW5lIGFsbCBiaXRzIGZyb20gTVNSX1NFVl9TVEFUVVNfUkVHSVNURVI=?= To: gaoliming , devel@edk2.groups.io CC: 'Ard Biesheuvel' , 'Jiewen Yao' , 'Jordan Justen' , 'Gerd Hoffmann' , 'Brijesh Singh' , 'Erdem Aktas' , 'James Bottomley' , 'Min Xu' , 'Tom Lendacky' References: <20221201023521.10028-1-aik@amd.com> <20221201023521.10028-2-aik@amd.com> <001101d909e1$84079000$8c16b000$@byosoft.com.cn> From: "Alexey Kardashevskiy" In-Reply-To: <001101d909e1$84079000$8c16b000$@byosoft.com.cn> X-ClientProxiedBy: SY3PR01CA0136.ausprd01.prod.outlook.com (2603:10c6:0:1b::21) To DM6PR12MB2843.namprd12.prod.outlook.com (2603:10b6:5:48::24) Return-Path: Alexey.Kardashevskiy@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB2843:EE_|MW3PR12MB4490:EE_ X-MS-Office365-Filtering-Correlation-Id: 0682fe33-d595-46b9-fbbd-08dad84e12f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +69jObOYNxkQ8E+GlK+OPt+fE/rAatEDPmKmeCqgSrbOyJbiOdkT6e+zIy357mFV4bQt9Y90cflMdt1vpbzO9vGv9AFS2Co+NAVXRNLUls1qLo5nXoPl2yYEndaw7UgBgXUAp/RH7hz3MLLXjbXNlqWpUUgjiHCG/Ywx6T1iKmaHIA1k0lAfH3faO6UQODfSmeNoVdt/Rod9Sf/Ag+ulEajlH6uqXY2UjUbJHNCZYfyv+XB1wXGI7XnUBtSOgVzI/JiXsXPs9/WK6cZnO3uGfkopY7SrMrN8uxy3r1Cfr69U5dFjZg4859IAHXJ2SCjKsWqG7fS4ebtZNXGns0dz5AArJGLP1B0i5MWv2/aws8+fWjsT/2sfg4c2mnZ9SUI4FkZUJptkFlFTCgvxpoT6sdfNzd9dx+MtW/9sqSZ4QfQCrmQiqIJSBIgov+iKYqd++pgtUpf20umJUs1f2TD7UMGgGlWUCnTlbfeqyBRuzNbwp/g62v7Jrmy3tfJuebNrRj1/w/e7LSdu5f7hudhrWuAotc8V+ov9AmMFWapJk4OPYVgVH7feMddMZ+t0KqAXRy/DcEjsbVDcg+MPRARCEEYrMobozne+spKhiz5qLePADjuXR9n3YMg9lYVKNrJNcnFf2AAMo0T7nGhNfuIma+ZQusqYNRl4MRuR3Z/qHZJ7b6f7KvQFvK8H1aQxxyVqbjuSc7Kcnx0JUez1VFQ8tzeKihmU7JcMhizsuue5IGMZEya6HK5LuqJKSSl7+aEq X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2843.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(39860400002)(136003)(346002)(376002)(451199015)(66899015)(31686004)(36756003)(2616005)(4326008)(66556008)(66946007)(66476007)(41300700001)(2906002)(31696002)(5660300002)(8936002)(316002)(224303003)(83380400001)(19627235002)(54906003)(6506007)(478600001)(26005)(6512007)(6666004)(53546011)(38100700002)(186003)(6486002)(966005)(45080400002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CApqtDHdsbb8WxcpD301FIzKYF2R/eosuWc0TUdwIjbSDG7S7T4yWqZYpDTK?= =?us-ascii?Q?d/4yrLJUvatDSzYTfIkkBEEOj/ac0dLlsk3YglMvD6Vuu3LoYRQJgOGeMg8w?= =?us-ascii?Q?wWZMPLlow/lvOoeOi8nEwhlMGwHzU8b1CWa1UeNc6WewWwEtVNZDx0PMdESR?= =?us-ascii?Q?n5XSDi+xHz1fYK/DPtyCSSCegEU+shPjHrWuERkJPcGlEj5vHHjeFf3L0uY0?= =?us-ascii?Q?/rtvATMNEM9GQMKDy+006M8dJ5UqwfwTDI9dvccg1ni2tjWpWLYSyPOTXkhA?= =?us-ascii?Q?IbsPPxzhqAyHuj+/ot43sfwpj+bNfeYH0Jsw5Tb2x5DSoRsFdLpmrGg0inxw?= =?us-ascii?Q?fzqTinc2n2teDqvaol+6V25UCzCg+EuuY/fjO2l2dIoMcP+sanT1Mc40N0He?= =?us-ascii?Q?cgTwcRjtfsTAxWifCI03xaoslweVX+Xf/aXLqa0PaDXz1RU9FZjam9EZXSK/?= =?us-ascii?Q?KY4YHjBqUvsp+fe6m7RC/ixRiTqudX0U1tGxdxsOdb7qJyI+8iGkOHmscbQS?= =?us-ascii?Q?H1XrilgVbKMkoVppm1uUV6EX6PIS9e20Fmn9RfSGKh0gss+o+hT21XlX1n7g?= =?us-ascii?Q?Ft08sYZ2uMBxoU67DiGXYUjMXUU5YdccJ7bmY5cDseV/vj9axVTUWE/iU3/e?= =?us-ascii?Q?M/g9JY/NLmLR93Ndm6tOTH37JDPAQgsoqvizw8KX9gXH5aN4Bn6C3sBxqKt5?= =?us-ascii?Q?tkB1LyjNEPXsFlrkecjIOrdMnEQy8wWl1VCmO8fi+LepaLjzHVtQ3vu/vP0M?= =?us-ascii?Q?4xdu3jUR11HcuxlZtbjH9lAxN7fg2wmmAv1CnFFRE/RepnpFSX6tcdaGXeQA?= =?us-ascii?Q?kVxRGfP3rzSGDrsa8eVZWfZCClcSMrxJ1Egnl85hHMnvyPbowolnQm5bJ6AT?= =?us-ascii?Q?k6/ylIJbuZRO3qlPmdQXaNyTCUoCW4hAao5JqHNLpKie5+uJE6g4mupfgLiM?= =?us-ascii?Q?5ti6Gq3NDhAkdzlQyL6PlrL69wVT2GGxsFESMWStW0qrQUcxArPUi+TQUUCO?= =?us-ascii?Q?PaxXLo4fgx8xT81D+CJuTwdo66sLik1KGTkFJgqdHZaeFasioDlzZDsWn4xo?= =?us-ascii?Q?spSpIfZTvCPkMrAimgBlW0pZogJ7JHMrKNPikkcEPfBxk9/DlvpQ/BkWbZMp?= =?us-ascii?Q?WquXXY34aezQl22d4PX5URFjueR/5Om2s9h3DaaXtQFCrBXV+RYIMC8cpk4U?= =?us-ascii?Q?pACxH/2q52y5jiwP/6uw1cUMM9bQBraSHQ3hQDeDPzpS1tgbIP6rCrNOJPXE?= =?us-ascii?Q?t9Cj4Xi1RYn2Gy2RQPVuDM2Z2PhstokdLRl28kfozKfHwLP5Bt35CrTJ0tKz?= =?us-ascii?Q?Ee6cK7cqoWysWMFQSu3VlZQWlXVsQvkZ1cTPRDs8j2mlxdUIJYPK8AZtJbwV?= =?us-ascii?Q?F4fVYK3XJPJXNAKb02ldU+7/W34KUZrS2IvmOu5awk+AZ6bUjJI1FPxs96Ul?= =?us-ascii?Q?+zL43yG9PM0eEoUNj2dD35OuNfeaWP5KNjuY/0I9axzg3EvckChM/k7KhDaS?= =?us-ascii?Q?Ea1VTyeKPip+dbGzhQc5GZx4YUXLwsCughlwLPt7IIKj5IEsXKYmndZM/ce+?= =?us-ascii?Q?gEou+j97RAIGViUuqo7GArUAWeU3cIIsdMrsy0zG?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0682fe33-d595-46b9-fbbd-08dad84e12f0 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2843.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2022 12:25:06.4584 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vqyfth+sAGMcR9AtHHwKTSwQ8cev3SIJNWGV34Y1rtwYjn8jdfUe0amS7owHJ0Jkl/vxq6SWptYf3B67UekdXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4490 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 7/12/22 13:13, gaoliming wrote: > Alexey: >=20 >=20 >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Alexey >> Kardashevskiy via groups.io >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B412=E6=9C=881=E6=97=A5= 10:35 >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io >> =E6=8A=84=E9=80=81: Ard Biesheuvel ; Jiewen Y= ao >> ; Jordan Justen ; Gerd >> Hoffmann ; Brijesh Singh ; >> Erdem Aktas ; James Bottomley >> ; Min Xu ; Tom Lendacky >> ; Alexey Kardashevskiy >> =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH ovmf 1/5] MdePkg/Register/Amd: D= efine all bits >> from MSR_SEV_STATUS_REGISTER >> >> We will need soon DebugSwap but others likely too. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> MdePkg/Include/Register/Amd/Fam17Msr.h | 57 +++++++++++++++++++- >> 1 file changed, 56 insertions(+), 1 deletion(-) >> >> diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h >> b/MdePkg/Include/Register/Amd/Fam17Msr.h >> index bb4e143e2456..f9474e6776f2 100644 >> --- a/MdePkg/Include/Register/Amd/Fam17Msr.h >> +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h >> @@ -121,7 +121,62 @@ typedef union { >> /// >> UINT32 SevSnpBit : 1; >> >> - UINT32 Reserved2 : 29; >> + /// >> + /// [Bit 3] The guest was run with the Virtual TOM feature enabled = in >> SEV_FEATURES[1] >> + /// >> + UINT32 vTOM_Enabled : 1; >> + > This name doesn't follow name convention. You can create pull request to = see > CI test result. It is though what 40332.pdf ("AMD64 Architecture Programmer=E2=80=99s Manua= l:=20 Volumes 1-5") uses and I find it _extremely_ useful when searching for a=20 feature in 3000+ pages PDF. What is the preferred way? Thanks, >=20 > Thanks > Liming >> + /// >> + /// [Bit 4] The guest was run with the ReflectVC feature enabled in >> SEV_FEATURES[2] >> + /// >> + UINT32 ReflectVC : 1; >> + >> + /// >> + /// [Bit 5] The guest was run with the Restricted Injection feature >> enabled in SEV_FEATURES[3] >> + /// >> + UINT32 RestrictedInjection : 1; >> + >> + /// >> + /// [Bit 6] The guest was run with the Alternate Injection feature >> enabled in SEV_FEATURES[4] >> + /// >> + UINT32 AlternateInjection : 1; >> + >> + /// >> + /// [Bit 7] This guest was run with debug register swapping enabled > in >> SEV_FEATURES[5] >> + /// >> + UINT32 DebugSwap : 1; >> + >> + /// >> + /// [Bit 8] This guest was run with the PreventHostIBS feature >> enabled in SEV_FEATURES[6] >> + /// >> + UINT32 PreventHostIBS : 1; >> + >> + /// >> + /// [Bit 9] The guest was run with the BTB isolation feature enable= d > in >> SEV_FEATURES[7] >> + /// >> + UINT32 SNPBTBIsolation : 1; >> + >> + /// >> + /// [Bit 10] >> + /// >> + UINT32 Reserved0 : 1; >> + >> + /// >> + /// [Bit 11] The guest was run with the Secure TSC feature enabled = in >> SEV_FEATURES[9] >> + /// >> + UINT32 SecureTsc : 1; >> + >> + /// >> + /// [Bits 12 13 14 15] >> + /// >> + UINT32 Reserved1 : 4; >> + >> + /// >> + /// [Bit 16] The guest was run with the VMSA Register Protection >> feature enabled in SEV_FEATURES[14] >> + /// >> + UINT32 VmsaRegProt_Enabled : 1; >> + >> + UINT32 Reserved2 : 15; >> } Bits; >> /// >> /// All bit fields as a 32-bit value >> -- >> 2.38.1 >> >> >> >>=20 >> >=20 >=20 >=20 --=20 Alexey