From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Andrew Goodbody <andrew.goodbody@linaro.org>, devel@edk2.groups.io
Cc: Leif Lindholm <leif@nuviainc.com>,
Graeme Gregory <graeme@nuviainc.com>,
Radoslaw Biernacki <rad@semihalf.com>,
Tanmay Jagdale <tanmay.jagdale@linaro.org>
Subject: Re: [PATCH] Platform/Qemu/Sbsa: Fix build break due to need for RngLib
Date: Mon, 5 Oct 2020 16:31:29 +0200 [thread overview]
Message-ID: <959ad250-8d62-1ee3-d19b-56fa0c34bd39@arm.com> (raw)
In-Reply-To: <20201005112658.42766-1-andrew.goodbody@linaro.org>
On 10/5/20 1:26 PM, Andrew Goodbody wrote:
> Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate
> entropy in rand_pool") introduced RngLib dependency for OpensslLib
> and caused QEMU platforms build to break for lack of an RngLib instance.
>
> Add the reference to RngLib to the SbsaQemu.dsc file
>
> Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Pushed as 8ef23e848b76..1288ede92a1c
Thanks,
>
> ---
> Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> index d42b9cd4de..0e6d738bee 100644
> --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> @@ -141,6 +141,7 @@ DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> #
> IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
>
> #
>
prev parent reply other threads:[~2020-10-05 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 11:26 [PATCH] Platform/Qemu/Sbsa: Fix build break due to need for RngLib Andrew Goodbody
2020-10-05 14:31 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=959ad250-8d62-1ee3-d19b-56fa0c34bd39@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox