public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Jaben Carsey <jaben.carsey@intel.com>
To: edk2-devel@lists.01.org
Cc: Bob Feng <bob.c.feng@intel.com>,
	Yonghong Zhu <yonghong.zhu@intel.com>,
	Liming Gao <liming.gao@intel.com>
Subject: [PATCH v2 6/7] BaseTools/GenFds: Remove duplicate function calls
Date: Fri, 28 Sep 2018 14:54:31 -0700	[thread overview]
Message-ID: <959c4e1a52653e0362a40afd42b00d62397d9fb4.1538171557.git.jaben.carsey@intel.com> (raw)
In-Reply-To: <cover.1538171557.git.jaben.carsey@intel.com>
In-Reply-To: <cover.1538171557.git.jaben.carsey@intel.com>

every call to GetAprioriSection() is duplicated on the line below.
remove one of the calls.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
 BaseTools/Source/Python/GenFds/FdfParser.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py b/BaseTools/Source/Python/GenFds/FdfParser.py
index d8fb9ce60161..5a59a0a0d854 100644
--- a/BaseTools/Source/Python/GenFds/FdfParser.py
+++ b/BaseTools/Source/Python/GenFds/FdfParser.py
@@ -2122,7 +2122,6 @@ class FdfParser:
             raise Warning("FvNameString found but FvNameGuid was not found", self.FileName, self.CurrentLineNumber)
 
         self._GetAprioriSection(FvObj)
-        self._GetAprioriSection(FvObj)
 
         while True:
             isInf = self._GetInfStatement(FvObj)
@@ -3781,7 +3780,6 @@ class FdfParser:
                 self._GetFvAlignment(FvObj)
                 self._GetFvAttributes(FvObj)
                 self._GetAprioriSection(FvObj)
-                self._GetAprioriSection(FvObj)
 
                 while True:
                     IsInf = self._GetInfStatement(FvObj)
-- 
2.16.2.windows.1



  parent reply	other threads:[~2018-09-28 21:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28 21:54 [PATCH v2 0/7] BaseTools/GenFds: cleanup GenFds Jaben Carsey
2018-09-28 21:54 ` [PATCH v2 1/7] " Jaben Carsey
2018-09-28 21:54 ` [PATCH v2 2/7] BaseTools/GenFds: change objects to sets Jaben Carsey
2018-09-28 21:54 ` [PATCH v2 3/7] Basetools/GenFds: refactor class FV Jaben Carsey
2018-09-28 21:54 ` [PATCH v2 4/7] BaseTools/GenFds: remove MacroDict parameter Jaben Carsey
2018-09-28 21:54 ` [PATCH v2 5/7] BaseTools/GenFds: refactor FdfParser warnings Jaben Carsey
2018-09-28 21:54 ` Jaben Carsey [this message]
2018-09-28 21:54 ` [PATCH v2 7/7] BaseTools/GenFds: create and use new variable in FdfParser Jaben Carsey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=959c4e1a52653e0362a40afd42b00d62397d9fb4.1538171557.git.jaben.carsey@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox