public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Javeed, Ashraf" <ashraf.javeed@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"Ni, Ray" <ray.ni@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"lersek@redhat.com" <lersek@redhat.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH] [MdePkg/Protocols]: New interface, EFI encodings to PCI Plat protocol
Date: Fri, 5 Jul 2019 05:23:41 +0000	[thread overview]
Message-ID: <95C5C2B113DE604FB208120C742E9824578B2D3F@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4A2ABE@SHSMSX104.ccr.corp.intel.com>

Hi,
Please note that these 2 tags are automatically added when the mail is sent with the formatted patch of the commit....
[edk2-devel] [PATCH]

I could add the branch name tag when I sent the commit in the Edk2-staging branch for review with the community - [Edk2-staging\Branch name]. This tags will be preceded with the above 2 tags in the subject line of that mail (too many prefix tags).

Can I get Reviewed-By to move this in to the Edk2-staging branch? Please note that this would require a PI Spec update.

Thanks
Ashraf

> -----Original Message-----
> From: Gao, Liming
> Sent: Friday, July 5, 2019 8:53 AM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; lersek@redhat.com;
> Javeed, Ashraf <ashraf.javeed@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH] [MdePkg/Protocols]: New interface, EFI
> encodings to PCI Plat protocol
> 
> Ray:
> 
> > -----Original Message-----
> > From: Ni, Ray
> > Sent: Friday, July 5, 2019 11:14 AM
> > To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io;
> > lersek@redhat.com; Javeed, Ashraf <ashraf.javeed@intel.com>
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > Subject: RE: [edk2-devel] [PATCH] [MdePkg/Protocols]: New interface,
> > EFI encodings to PCI Plat protocol
> >
> > Some unclear parts in the document:
> > 1. Document says title begins with "staging/branch". The "branch" means the
> "branch" word itself
> >      or should be replaced with a concrete branch name? I prefer "branch" word.
> Reasons in previous mail.
> >     NOTE: this affects the individual patch owner.
> I understand here is the specific branch name. The patch is required to be pushed
> into the specific branch instead of 'branch'.
> I think the patch owner should propose which branch to include his patch. He
> can propose new branch or use the existing branch.
> 
> > 2. Who owns the staging/master branch sync to edk2/master? Document says
> the staging/branch is
> >      based on staging/master but I guess usually staging patch owner creates
> staging/branch based on edk2/master.
> Yes. I think so.
> 
> Thanks
> Liming
> >
> > Thanks,
> > Ray
> >
> > > -----Original Message-----
> > > From: Gao, Liming
> > > Sent: Friday, July 5, 2019 10:49 AM
> > > To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io;
> > > lersek@redhat.com; Javeed, Ashraf <ashraf.javeed@intel.com>
> > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > > Subject: RE: [edk2-devel] [PATCH] [MdePkg/Protocols]: New interface,
> > > EFI encodings to PCI Plat protocol
> > >
> > > Ray:
> > >   Yes. Please see https://github.com/tianocore/edk2-staging
> > >
> > > Thanks
> > > Liming
> > > >-----Original Message-----
> > > >From: Ni, Ray
> > > >Sent: Friday, July 05, 2019 10:39 AM
> > > >To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io;
> > > >lersek@redhat.com; Javeed, Ashraf <ashraf.javeed@intel.com>
> > > >Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > > >Subject: RE: [edk2-devel] [PATCH] [MdePkg/Protocols]: New
> > > >interface, EFI encodings to PCI Plat protocol
> > > >
> > > >Liming,
> > > >I understand Laszlo's comment requiring repo name in the patch
> > > >title to tell everyone where the code will be.
> > > >But before the patch is pushed, the patch owner in theory cannot
> > > >guarantee the branch can be successfully created after the R-b is got.
> > > >Because someone may create a branch with the same name.
> > > >
> > > >Is there any public document for the patch which goes to staging repo?
> > > >
> > > >Thanks,
> > > >Ray
> > > >
> > > >> -----Original Message-----
> > > >> From: Gao, Liming
> > > >> Sent: Friday, July 5, 2019 10:13 AM
> > > >> To: devel@edk2.groups.io; lersek@redhat.com; Javeed, Ashraf
> > > >> <ashraf.javeed@intel.com>
> > > >> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ray
> > > >> <ray.ni@intel.com>
> > > >> Subject: RE: [edk2-devel] [PATCH] [MdePkg/Protocols]: New
> > > >> interface, EFI encodings to PCI Plat protocol
> > > >>
> > > >> And, please also specify branch name in edk2-staging.
> > > >>
> > > >> The subject title likes : [PATCH edk2-staging\BranchName]
> > > >> [MdePkg/Protocols]: New interface, EFI encodings to PCI Plat
> > > >> protocol
> > > >>
> > > >> >-----Original Message-----
> > > >> >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On
> > > >> >Behalf Of Laszlo Ersek
> > > >> >Sent: Friday, July 05, 2019 12:25 AM
> > > >> >To: devel@edk2.groups.io; Javeed, Ashraf
> > > >> ><ashraf.javeed@intel.com>
> > > >> >Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > > >> ><liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> > > >> >Subject: Re: [edk2-devel] [PATCH] [MdePkg/Protocols]: New
> > > >> >interface, EFI encodings to PCI Plat protocol
> > > >> >
> > > >> >On 07/04/19 15:20, Javeed, Ashraf wrote:
> > > >> >> Please note that this new feature change would be moved to
> > > >> >> Edk2-staging
> > > >> >after obtaining the Reviewed-By.
> > > >> >
> > > >> >If the feature targets edk2-staging, then please use the
> > > >> >following subject prefix:
> > > >> >
> > > >> >[PATCH edk2-staging]
> > > >> >
> > > >> >rather than just
> > > >> >
> > > >> >[PATCH].
> > > >> >
> > > >> >Thanks.
> > > >> >Laszlo
> > > >> >
> > > >> >


  reply	other threads:[~2019-07-05  5:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <15AE3668F84BF3B8.28761@groups.io>
2019-07-04 13:20 ` [edk2-devel] [PATCH] [MdePkg/Protocols]: New interface, EFI encodings to PCI Plat protocol Javeed, Ashraf
2019-07-04 16:25   ` Laszlo Ersek
2019-07-05  2:13     ` Liming Gao
2019-07-05  2:38       ` Ni, Ray
2019-07-05  2:48         ` Liming Gao
2019-07-05  3:13           ` Ni, Ray
2019-07-05  3:23             ` Liming Gao
2019-07-05  5:23               ` Javeed, Ashraf [this message]
2019-07-05 10:31                 ` Ni, Ray
2019-07-05 11:12                   ` Javeed, Ashraf
     [not found]                   ` <15AE7E6E11B2DE53.4080@groups.io>
2019-07-12 13:38                     ` Javeed, Ashraf
2019-07-05 15:35                 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95C5C2B113DE604FB208120C742E9824578B2D3F@BGSMSX101.gar.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox