From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.5750.1576728769152375396 for ; Wed, 18 Dec 2019 20:12:49 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ashraf.javeed@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 20:12:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,330,1571727600"; d="scan'208";a="365943357" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 18 Dec 2019 20:12:48 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Dec 2019 20:12:48 -0800 Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Dec 2019 20:12:47 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.143]) by BGSMSX102.gar.corp.intel.com ([169.254.2.130]) with mapi id 14.03.0439.000; Thu, 19 Dec 2019 09:42:45 +0530 From: "Javeed, Ashraf" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" Subject: Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 03/12] PciBusDxe: Separation of the PCI device registration and start Thread-Topic: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 03/12] PciBusDxe: Separation of the PCI device registration and start Thread-Index: AQHVkMZ7F0DOg8c0FUGhxv9UALvPWqeIghqAgDT1YACAAHdL4IACrF+AgACIVjA= Date: Thu, 19 Dec 2019 04:12:44 +0000 Message-ID: <95C5C2B113DE604FB208120C742E98245797C8FC@BGSMSX101.gar.corp.intel.com> References: <20191101150952.3340-1-ashraf.javeed@intel.com> <15D3127A98E21087.7420@groups.io> <95C5C2B113DE604FB208120C742E982457917197@BGSMSX101.gar.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C39FE01@SHSMSX104.ccr.corp.intel.com> <95C5C2B113DE604FB208120C742E98245797B7EF@BGSMSX101.gar.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C3A2614@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C3A2614@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDM2MWVhODgtYzFhMi00ZmM5LTk1YjEtYTg2MjM5NDNhZmI1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUG9FVmlMWUZmeXFUeUZFT1hpcUZPVXBsdzFDelwvRFpGc0xTeVF5ZzRadVpyMUZMcnJyTHBLc1FYTGJDTm9RcTkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.223.10.10] MIME-Version: 1.0 Return-Path: ashraf.javeed@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Ni, Ray > Sent: Thursday, December 19, 2019 7:04 AM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 03/12] > PciBusDxe: Separation of the PCI device registration and start >=20 > > > > > > 2 minor comments: > > > 1. StartPciRootPortsOnBridge() > > > Can it be renamed to EnablePciDevicesOnBridge()? > > > Because it basically calls PciIo.Attribute() to enable the > > > devices. And I am > > not > > > sure the enable only applies to PCI root ports. There could be PCI > > > devices > > behind > > > P2P bridge. > > It enables only Type 1 PCI devices (Root Port, PCIe-to-PCI Bridge, > > PCIe switch upstream/downstream ports), and no endpoint (Type 0) device= s. >=20 > I see. Then how about EnablePciBridges()? This will do.