From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.5535.1578628832194563520 for ; Thu, 09 Jan 2020 20:00:32 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ashraf.javeed@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 20:00:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,415,1571727600"; d="scan'208";a="224078802" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 09 Jan 2020 20:00:31 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 20:00:31 -0800 Received: from BGSMSX107.gar.corp.intel.com (10.223.4.191) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 20:00:30 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.21]) by BGSMSX107.gar.corp.intel.com ([169.254.9.46]) with mapi id 14.03.0439.000; Fri, 10 Jan 2020 09:30:26 +0530 From: "Javeed, Ashraf" To: "devel@edk2.groups.io" , "Javeed, Ashraf" CC: "Kinney, Michael D" , "Gao, Liming" , "Ni, Ray" Subject: Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V8] MdePkg/Protocols: New PCI Express Platform Protocol, EFI encodings Thread-Topic: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V8] MdePkg/Protocols: New PCI Express Platform Protocol, EFI encodings Thread-Index: AQHVx2nHlppc5A2PLUaXqgPOvkU+mKfjRTqQ Date: Fri, 10 Jan 2020 04:00:26 +0000 Message-ID: <95C5C2B113DE604FB208120C742E98245798B822@BGSMSX101.gar.corp.intel.com> References: <15E86A3985A56934.20149@groups.io> In-Reply-To: <15E86A3985A56934.20149@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDMxNTM2MGUtNWJhOC00NzVmLTlhOWMtMjU1NDkzYjNkZTRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoienc0QzJ0SjFISGk2WE54cCt5MkhMVmZKa2EyK2U4WEt0NXhiN3lQaVVNTmpIQ2dvSDFcL1k4OWhpXC9CUjNOV2NTIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.223.10.10] MIME-Version: 1.0 Return-Path: ashraf.javeed@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, You can also review this patch into the below edk2-staging repo:- https://github.com/ashrafj/edk2-staging/commit/84ec9f060bab7d5ec97b36367e8= 7124820694934 Thanks Ashraf > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Friday, January 10, 2020 9:24 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Ni, Ray > Subject: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V8] > MdePkg/Protocols: New PCI Express Platform Protocol, EFI encodings >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1954 >=20 > Three interfaces added to PCI Express Platform Protocol:- > (1) GetDevicePolicy() -> to retrieve device-specific platform policies > (2) NotifyDeviceState() -> to notify platform about device PCI Express > configuration state > (3) GetPolicy() -> to retrieve platform policy about the PCI Express > feature list > PCI Express Override Protocol is made alias to PCI Express Platform Prot= ocol. > EFI encodings introduced for the following PCI Express features, are: > 1. Maximum Payload Size (MPS) > 2. Maximum Read Request Size (MRRS) > 3. Extended Tag > 4. Relax Order Enable > 5. No Snoop Enable > 6. ASPM support > 7. Common Clock Configuration > 8. Extended SYNC > 9. Atomic Op > 10. LTR Enable > 11. PTM support > 12. CTO support > 13. CPM > 14. L1 PM Substates >=20 > New source files with unique definitions are: > MdePkg/Include/Protocol/PciExpressPlatform.h, > MdePkg/Include/Protocol/PciExpressOverride.h >=20 > Signed-off-by: Ashraf Javeed > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Ray Ni > --- >=20 > In V8: Code Syntax correction made. >=20 > In V7: Revised ECR to define additional interface GetPolicy() in the PCI= Express > Platform Protocol / PCI Express Override Protocol, Renamed > EFI_PCI_EXPRESS_PLATFORM_POLICY to EFI_PCI_EXPRESS_DEVICE_POLICY, > Removed the reserved fields from the EFI_PCI_EXPRESS_DEVICE_POLICY, adde= d > input parameter to give the length of input buffer in GetDevicePolicy(),= and > NotifyDeviceState(), introduced new data type > EFI_PCI_EXPRESS_PLATFORM_POLICY for the interface GetPolicy(). >=20 > In V6: renamed the protocol definition source files, remove PCD comments= , and > renamed NotifyDeviceConfiguration -> NotifyDeviceState >=20 > In V5: Revised ECR to define new PCI Platform Protocol to support the PC= I > Express capability features:- EFI_PCI_EXPRESS_PLATFORM_PROTOCOL, > EFI_PCI_EXPRESS_OVERRIDE_PROTOCOL. > Added new interface -> NotifyDeviceConfiguration Added new EFI encodings= / > data types for PCIe features:- CPM, L1 PM substates. > Enhance the definition of the PCIe feature AtomicOp to support additiona= l > attribute - Egress blocking of the port. >=20 > In V4: Redefinition of the existing interfaces in the EFI_PCI_PLATFORM_- > PROTOCOL2, to avoid type casting and to avoid further future change >=20 > In V3: License update in the header sections of source files >=20 > In V2: Correction made to header sections of source files > --- > MdePkg/Include/Protocol/PciExpressPlatform.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Include/Protocol/PciExpressPlatform.h > b/MdePkg/Include/Protocol/PciExpressPlatform.h > index 8a28418..dc58268 100644 > --- a/MdePkg/Include/Protocol/PciExpressPlatform.h > +++ b/MdePkg/Include/Protocol/PciExpressPlatform.h > @@ -643,11 +643,11 @@ typedef struct { > **/ > typedef > EFI_STATUS > -(EFIAPI * EFI_PCI_EXPRESS_GET_POLICY) { > +(EFIAPI * EFI_PCI_EXPRESS_GET_POLICY) ( > IN CONST EFI_PCI_EXPRESS_PLATFORM_PROTOCOL *This, > IN UINTN Size, > IN OUT EFI_PCI_EXPRESS_PLATFORM_POLICY *PlatformPolicy > -}; > +); >=20 > /// > /// This protocol provides the interface between the PCI bus driver/PCI= Host > -- > 2.21.0.windows.1 >=20 >=20 >=20