Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member

[Javeed, Ashraf]

This patch is also in the following repo for your review:-
https://github.com/ashrafj/edk2-staging/commit/cdcc078659a82536233c328c771507584235bcd0

Thanks
Ashraf

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Javeed,
> Ashraf
> Sent: Thursday, February 6, 2020 4:08 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH]
> MdePkg/Protocols: Code correction - removal of reserved member
> 
> Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  MdePkg/Include/Protocol/PciExpressPlatform.h | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/MdePkg/Include/Protocol/PciExpressPlatform.h
> b/MdePkg/Include/Protocol/PciExpressPlatform.h
> index dc58268..bb2c8c8 100644
> --- a/MdePkg/Include/Protocol/PciExpressPlatform.h
> +++ b/MdePkg/Include/Protocol/PciExpressPlatform.h
> @@ -360,14 +360,10 @@ struct _EFI_PCI_EXPRESS_L1PM_SUBSTATES {  };
> 
>  ///
> -/// Reserves for future use
> -///
> -typedef UINT8 EFI_PCI_EXPRESS_RESERVES;
> -
> -///
> -/// The EFI_PCI_EXPRESS_DEVICE_POLICY is altogether 128-byte size, with
> each -/// byte field representing one PCI standerd feature defined in the PCI
> Express Base -/// Specification 4.0, version 1.0.
> +/// The EFI_PCI_EXPRESS_DEVICE_POLICY size is fixed as per its
> +definition corresponding /// to its version, with each byte field
> +represents one PCI Express feature and /// its bitmask define the legal
> +combinations to represent all the valid combinations /// of its attributes,
> defined in the PCI Express Base Specification.
>  ///
>  typedef struct {
>    EFI_PCI_EXPRESS_MAX_PAYLOAD_SIZE  DeviceCtlMPS; @@ -384,7 +380,6
> @@ typedef struct {
>    EFI_PCI_EXPRESS_CTO_SUPPORT       CTOsupport;
>    EFI_PCI_EXPRESS_CPM               LinkCtlCPM;
>    EFI_PCI_EXPRESS_L1PM_SUBSTATES    L1PMSubstates;
> -  EFI_PCI_EXPRESS_RESERVES          Reserves[114];
>  } EFI_PCI_EXPRESS_DEVICE_POLICY;
> 
>  ///
> --
> 2.21.0.windows.1
> 
> 
>