From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.19195.1581323575666412403 for ; Mon, 10 Feb 2020 00:32:55 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ashraf.javeed@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Feb 2020 00:32:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,424,1574150400"; d="scan'208";a="405511432" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 10 Feb 2020 00:32:50 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 10 Feb 2020 00:32:49 -0800 Received: from bgsmsx151.gar.corp.intel.com (10.224.48.42) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 10 Feb 2020 00:32:49 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.159]) by BGSMSX151.gar.corp.intel.com ([169.254.3.195]) with mapi id 14.03.0439.000; Mon, 10 Feb 2020 14:02:45 +0530 From: "Javeed, Ashraf" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" Subject: Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 02/12] MdeModulePkg/PciBusDxe: Setup PCI Express init phase Thread-Topic: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 02/12] MdeModulePkg/PciBusDxe: Setup PCI Express init phase Thread-Index: AQHV3fIQbOuO9DDKrEu6zJtNcxXaxagQK1gAgAOGYwCAAGokUA== Date: Mon, 10 Feb 2020 08:32:45 +0000 Message-ID: <95C5C2B113DE604FB208120C742E9824579AB46F@BGSMSX101.gar.corp.intel.com> References: <20200207200447.10536-1-ashraf.javeed@intel.com> <15F137802DC889C4.7869@groups.io> <95C5C2B113DE604FB208120C742E9824579AAF7C@BGSMSX101.gar.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C42933D@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C42933D@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWE5OWRjY2MtMmQwYy00NjY0LWFmOTgtZTA4YTg0MDQyMmVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZSt0Tzl4Q2NEeHh3WmR2SlpVTkhaNFdpQ1NtSndoaVFDbWZPWTNhMWxJN3lmdEh3MlFXQXJxZ1o1aUFjZUF3aCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.223.10.10] MIME-Version: 1.0 Return-Path: ashraf.javeed@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Ashraf > -----Original Message----- > From: Ni, Ray > Sent: Monday, February 10, 2020 1:07 PM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 02/12] > MdeModulePkg/PciBusDxe: Setup PCI Express init phase >=20 > > > + Status =3D EnumeratePciExpressFeatures ( > 1. "enumerate" means "visit". But I think this function is not just visit= ing the > features but also > programming them. So, How about "ProgramPciExpressFeatures"? > (I gave a similar review comment in last time review in Dec.) >=20 Actually I have already used the "ProgramPciExpressFeatures" in one of the = sub-phases of the PCI Express initialization code...do you have any other n= ame for this? How about "ConfigurePciExpressFeatures"? > 2. In mail https://edk2.groups.io/g/devel/message/52399 I proposed to sim= plify > to 4 phases. > Did you find any issue with my proposal? I did simplify to 4 phases, please check. The fifth phase is to report out = the device state to the platform through the protocol interface "NotifyDevi= ceState". >=20 > Thanks, > Ray