From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web09.19149.1581323672147775262 for ; Mon, 10 Feb 2020 00:34:32 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ashraf.javeed@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Feb 2020 00:34:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,424,1574150400"; d="scan'208";a="251118700" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 10 Feb 2020 00:34:30 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 10 Feb 2020 00:34:30 -0800 Received: from bgsmsx103.gar.corp.intel.com (10.223.4.130) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 10 Feb 2020 00:34:30 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.159]) by BGSMSX103.gar.corp.intel.com ([169.254.4.133]) with mapi id 14.03.0439.000; Mon, 10 Feb 2020 14:04:27 +0530 From: "Javeed, Ashraf" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" Subject: Re: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 00/12] PciBusDxe: New PCI Express features Thread-Topic: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 00/12] PciBusDxe: New PCI Express features Thread-Index: AQHV3fHuM/LmOtLrAE+pg9n1gSvbG6gUDaQAgAAP52A= Date: Mon, 10 Feb 2020 08:34:26 +0000 Message-ID: <95C5C2B113DE604FB208120C742E9824579AB486@BGSMSX101.gar.corp.intel.com> References: <20200207200447.10536-1-ashraf.javeed@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C42936F@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C42936F@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTVhNmUxZjctMmRjMi00OTk3LTk3ZTMtNTg2OTU2ZjRiODMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSGxNeEU4QWdKcEFXNld4XC9nV1llK2ZWSnE3OVhreWN6Y3lPYktWR0ZzRk1lb1VoTmdKQTBqNVNoUHNOWUNcLzUyIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.223.10.10] MIME-Version: 1.0 Return-Path: ashraf.javeed@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ray, I have responded to your review comments. These patches has been changed accommodating your previous review comments. Please check. Thanks Ashraf > -----Original Message----- > From: Ni, Ray > Sent: Monday, February 10, 2020 1:10 PM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: RE: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 00/12] PciBusDxe: > New PCI Express features >=20 > Ashraf, > I reviewed the first and second patches. >=20 > Can you please check my review comments to your December's patches and > make sure either your new code changes followed the comments, or we > continue discuss the review comments if you don't agree? >=20 > I just found some code changes didn't follow as comments suggested. >=20 > Thanks, > Ray >=20 >=20 > > -----Original Message----- > > From: Javeed, Ashraf > > Sent: Saturday, February 8, 2020 4:05 AM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J ; Wu, Hao A > > ; Ni, Ray > > Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 00/12] PciBusDxe: New > > PCI Express features > > > > The PciBusDxe is enhanced to initialize 10 PCI Express features (patch > > index 3 to 12). > > All these PCI Express features attributes are defined based on the new > > PCI Express Platform Protocol definition (as per its ECR draft version > > 0.8): https://bugzilla.tianocore.org/show_bug.cgi?id=3D1954. > > For MPS, MRRS:- > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2194 > > For RO, NS, CTO:- > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2313 > > For AtomicOp, Extended Tag, LTR:- > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2499 > > For ASPM, CCC:- > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2500 > > > > Signed-off-by: Ashraf Javeed > > Cc: Jian J Wang > > Cc: Hao A Wu > > Cc: Ray Ni > > > > > > Ashraf Javeed (12): > > MdeModulePkg/PciBusDxe: Setup for PCI Express features > > MdeModulePkg/PciBusDxe: Setup PCI Express init phase > > PciBusDxe: New PCI Express feature Max_Payload_Size > > PciBusDxe: New PCI Express feature Max_Read_Req_Size > > PciBusDxe: New PCI Express feature Relax Ordering > > PciBusDxe: New PCI Express feature No-Snoop > > PciBusDxe: New PCI Express feature Completion Timeout > > PciBusDxe: New PCI Express feature AtomicOp > > PciBusDxe: New PCI Express feature LTR > > PciBusDxe: New PCI Express feature Extended Tag > > PciBusDxe: New PCI Express feature ASPM support > > PciBusDxe: New PCI Express feature Common CLock Config > > > > MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c | 6 ++- > > MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h | 25 +++++++++= +- > > MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf | 11 ++++- > > MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c | 181 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-- > --- > > ----------- > > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 12 +++++- > > MdeModulePkg/Bus/Pci/PciBusDxe/PciExpressFeatures.c | 2178 > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > +++++++++++++++++++++++++++ > > MdeModulePkg/Bus/Pci/PciBusDxe/PciExpressFeatures.h | 399 > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++++++++++++++++++++++++++++++++++++++++ > > MdeModulePkg/Bus/Pci/PciBusDxe/PciFeatureSupport.c | 1019 > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++++++++++++++++++++++++++++++++++++++++++++++ > > MdeModulePkg/Bus/Pci/PciBusDxe/PciFeatureSupport.h | 304 > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > + > > MdeModulePkg/Bus/Pci/PciBusDxe/PciPlatformSupport.c | 902 > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > MdeModulePkg/Bus/Pci/PciBusDxe/PciPlatformSupport.h | 119 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 11 files changed, 5116 insertions(+), 40 deletions(-) create mode > > 100644 MdeModulePkg/Bus/Pci/PciBusDxe/PciExpressFeatures.c > > create mode 100644 > > MdeModulePkg/Bus/Pci/PciBusDxe/PciExpressFeatures.h > > create mode 100644 MdeModulePkg/Bus/Pci/PciBusDxe/PciFeatureSupport.c > > create mode 100644 MdeModulePkg/Bus/Pci/PciBusDxe/PciFeatureSupport.h > > create mode 100644 > > MdeModulePkg/Bus/Pci/PciBusDxe/PciPlatformSupport.c > > create mode 100644 > > MdeModulePkg/Bus/Pci/PciBusDxe/PciPlatformSupport.h > > > > -- > > 2.21.0.windows.1