* Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
[not found] <15FD081950A8E1F5.25941@groups.io>
@ 2020-03-17 7:56 ` Javeed, Ashraf
0 siblings, 0 replies; 11+ messages in thread
From: Javeed, Ashraf @ 2020-03-17 7:56 UTC (permalink / raw)
To: devel@edk2.groups.io, Javeed, Ashraf
Cc: Kinney, Michael D, Gao, Liming, Liu, Zhiguang
Kindly ignore this as I have sent only the delta portion of previous patch.
I shall send the whole patch again.
Thanks
Ashraf
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Javeed,
> Ashraf
> Sent: Tuesday, March 17, 2020 1:22 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition
> missing
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598
>
> All registers definition of DVSEC are defined as per the PCI Express Base
> Specification 4.0 chapter 7.9.6.
>
> Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>
> V2: fixed the comment section description for DVSEC definitions
> ---
> MdePkg/Include/IndustryStandard/PciExpress40.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/PciExpress40.h
> b/MdePkg/Include/IndustryStandard/PciExpress40.h
> index 02c30a7757..0564d72861 100644
> --- a/MdePkg/Include/IndustryStandard/PciExpress40.h
> +++ b/MdePkg/Include/IndustryStandard/PciExpress40.h
> @@ -77,7 +77,11 @@ typedef struct {
> UINT32 Reserved;
>
> PCI_EXPRESS_REG_PHYSICAL_LAYER_16_0_LANE_EQUALIZATION_CONTRO
> L LaneEqualizationControl[1]; }
> PCI_EXPRESS_EXTENDED_CAPABILITIES_PHYSICAL_LAYER_16_0;
> +///@}
>
> +/// The Designated Vendor Specific Capability definitions /// Based on
> +section 7.9.6 of PCI Express Base Specification 4.0.
> +///@{
> typedef union {
> struct {
> UINT32 DvsecVendorId : 16; //bit 0..15
> --
> 2.21.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
@ 2020-03-17 8:04 Javeed, Ashraf
2020-03-17 8:08 ` Zhiguang Liu
2020-03-19 8:59 ` Ni, Ray
0 siblings, 2 replies; 11+ messages in thread
From: Javeed, Ashraf @ 2020-03-17 8:04 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Liming Gao, Zhiguang Liu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598
All registers definition of DVSEC are defined as per the PCI Express Base
Specification 4.0 chapter 7.9.6.
Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
V2: fixed the comment section description for DVSEC definitions
---
MdePkg/Include/IndustryStandard/PciExpress40.h | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/PciExpress40.h b/MdePkg/Include/IndustryStandard/PciExpress40.h
index 9d9b272546..0564d72861 100644
--- a/MdePkg/Include/IndustryStandard/PciExpress40.h
+++ b/MdePkg/Include/IndustryStandard/PciExpress40.h
@@ -4,6 +4,7 @@ Support for the PCI Express 4.0 standard.
This header file may not define all structures. Please extend as required.
Copyright (c) 2018, American Megatrends, Inc. All rights reserved.<BR>
+Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -78,6 +79,33 @@ typedef struct {
} PCI_EXPRESS_EXTENDED_CAPABILITIES_PHYSICAL_LAYER_16_0;
///@}
+/// The Designated Vendor Specific Capability definitions
+/// Based on section 7.9.6 of PCI Express Base Specification 4.0.
+///@{
+typedef union {
+ struct {
+ UINT32 DvsecVendorId : 16; //bit 0..15
+ UINT32 DvsecRevision : 4; //bit 16..19
+ UINT32 DvsecLength : 12; //bit 20..31
+ }Bits;
+ UINT32 Uint32;
+}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1;
+
+typedef union {
+ struct {
+ UINT16 DvsecId : 16; //bit 0..15
+ }Bits;
+ UINT16 Uint16;
+}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2;
+
+typedef struct {
+ PCI_EXPRESS_EXTENDED_CAPABILITIES_HEADER Header;
+ PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1 DesignatedVendorSpecificHeader1;
+ PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2 DesignatedVendorSpecificHeader2;
+ UINT8 DesignatedVendorSpecific[1];
+}PCI_EXPRESS_EXTENDED_CAPABILITIES_DESIGNATED_VENDOR_SPECIFIC;
+///@}
+
#pragma pack()
#endif
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
2020-03-17 8:04 [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing Javeed, Ashraf
@ 2020-03-17 8:08 ` Zhiguang Liu
2020-03-18 2:40 ` Liming Gao
2020-03-19 8:59 ` Ni, Ray
1 sibling, 1 reply; 11+ messages in thread
From: Zhiguang Liu @ 2020-03-17 8:08 UTC (permalink / raw)
To: Javeed, Ashraf, devel@edk2.groups.io; +Cc: Kinney, Michael D, Gao, Liming
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
-----Original Message-----
From: Javeed, Ashraf
Sent: Tuesday, March 17, 2020 4:04 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>
Subject: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598
All registers definition of DVSEC are defined as per the PCI Express Base
Specification 4.0 chapter 7.9.6.
Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
V2: fixed the comment section description for DVSEC definitions
---
MdePkg/Include/IndustryStandard/PciExpress40.h | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/PciExpress40.h b/MdePkg/Include/IndustryStandard/PciExpress40.h
index 9d9b272546..0564d72861 100644
--- a/MdePkg/Include/IndustryStandard/PciExpress40.h
+++ b/MdePkg/Include/IndustryStandard/PciExpress40.h
@@ -4,6 +4,7 @@ Support for the PCI Express 4.0 standard.
This header file may not define all structures. Please extend as required.
Copyright (c) 2018, American Megatrends, Inc. All rights reserved.<BR>
+Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -78,6 +79,33 @@ typedef struct {
} PCI_EXPRESS_EXTENDED_CAPABILITIES_PHYSICAL_LAYER_16_0;
///@}
+/// The Designated Vendor Specific Capability definitions
+/// Based on section 7.9.6 of PCI Express Base Specification 4.0.
+///@{
+typedef union {
+ struct {
+ UINT32 DvsecVendorId : 16; //bit 0..15
+ UINT32 DvsecRevision : 4; //bit 16..19
+ UINT32 DvsecLength : 12; //bit 20..31
+ }Bits;
+ UINT32 Uint32;
+}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1;
+
+typedef union {
+ struct {
+ UINT16 DvsecId : 16; //bit 0..15
+ }Bits;
+ UINT16 Uint16;
+}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2;
+
+typedef struct {
+ PCI_EXPRESS_EXTENDED_CAPABILITIES_HEADER Header;
+ PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1 DesignatedVendorSpecificHeader1;
+ PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2 DesignatedVendorSpecificHeader2;
+ UINT8 DesignatedVendorSpecific[1];
+}PCI_EXPRESS_EXTENDED_CAPABILITIES_DESIGNATED_VENDOR_SPECIFIC;
+///@}
+
#pragma pack()
#endif
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
2020-03-17 8:08 ` Zhiguang Liu
@ 2020-03-18 2:40 ` Liming Gao
2020-03-18 4:51 ` Javeed, Ashraf
0 siblings, 1 reply; 11+ messages in thread
From: Liming Gao @ 2020-03-18 2:40 UTC (permalink / raw)
To: Liu, Zhiguang, Javeed, Ashraf, devel@edk2.groups.io; +Cc: Kinney, Michael D
Ashraf:
The change is good. Have you verified the build with this patch?
Reviewed-by: Liming Gao <liming.gao@intel.com>
Thanks
Liming
-----Original Message-----
From: Liu, Zhiguang <zhiguang.liu@intel.com>
Sent: 2020年3月17日 16:08
To: Javeed, Ashraf <ashraf.javeed@intel.com>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: RE: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
-----Original Message-----
From: Javeed, Ashraf
Sent: Tuesday, March 17, 2020 4:04 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>
Subject: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598
All registers definition of DVSEC are defined as per the PCI Express Base Specification 4.0 chapter 7.9.6.
Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
V2: fixed the comment section description for DVSEC definitions
---
MdePkg/Include/IndustryStandard/PciExpress40.h | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/PciExpress40.h b/MdePkg/Include/IndustryStandard/PciExpress40.h
index 9d9b272546..0564d72861 100644
--- a/MdePkg/Include/IndustryStandard/PciExpress40.h
+++ b/MdePkg/Include/IndustryStandard/PciExpress40.h
@@ -4,6 +4,7 @@ Support for the PCI Express 4.0 standard.
This header file may not define all structures. Please extend as required.
Copyright (c) 2018, American Megatrends, Inc. All rights reserved.<BR>
+Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -78,6 +79,33 @@ typedef struct {
} PCI_EXPRESS_EXTENDED_CAPABILITIES_PHYSICAL_LAYER_16_0;
///@}
+/// The Designated Vendor Specific Capability definitions /// Based on
+section 7.9.6 of PCI Express Base Specification 4.0.
+///@{
+typedef union {
+ struct {
+ UINT32 DvsecVendorId : 16; //bit 0..15
+ UINT32 DvsecRevision : 4; //bit 16..19
+ UINT32 DvsecLength : 12; //bit 20..31
+ }Bits;
+ UINT32 Uint32;
+}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1;
+
+typedef union {
+ struct {
+ UINT16 DvsecId : 16; //bit 0..15
+ }Bits;
+ UINT16 Uint16;
+}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2;
+
+typedef struct {
+ PCI_EXPRESS_EXTENDED_CAPABILITIES_HEADER Header;
+ PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1 DesignatedVendorSpecificHeader1;
+ PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2 DesignatedVendorSpecificHeader2;
+ UINT8 DesignatedVendorSpecific[1];
+}PCI_EXPRESS_EXTENDED_CAPABILITIES_DESIGNATED_VENDOR_SPECIFIC;
+///@}
+
#pragma pack()
#endif
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
2020-03-18 2:40 ` Liming Gao
@ 2020-03-18 4:51 ` Javeed, Ashraf
2020-03-18 15:51 ` Liming Gao
[not found] ` <15FD70D8928FA969.21252@groups.io>
0 siblings, 2 replies; 11+ messages in thread
From: Javeed, Ashraf @ 2020-03-18 4:51 UTC (permalink / raw)
To: Gao, Liming, Liu, Zhiguang, devel@edk2.groups.io; +Cc: Kinney, Michael D
Yes, I verified the build with this patch by directly referencing the new data types in a source file.
Thanks
Ashraf
> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Wednesday, March 18, 2020 8:11 AM
> To: Liu, Zhiguang <zhiguang.liu@intel.com>; Javeed, Ashraf
> <ashraf.javeed@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
>
> Ashraf:
> The change is good. Have you verified the build with this patch?
>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
>
> Thanks
> Liming
> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: 2020年3月17日 16:08
> To: Javeed, Ashraf <ashraf.javeed@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: RE: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
>
> Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
>
> -----Original Message-----
> From: Javeed, Ashraf
> Sent: Tuesday, March 17, 2020 4:04 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598
>
> All registers definition of DVSEC are defined as per the PCI Express Base
> Specification 4.0 chapter 7.9.6.
>
> Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>
> V2: fixed the comment section description for DVSEC definitions
> ---
> MdePkg/Include/IndustryStandard/PciExpress40.h | 28
> ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/PciExpress40.h
> b/MdePkg/Include/IndustryStandard/PciExpress40.h
> index 9d9b272546..0564d72861 100644
> --- a/MdePkg/Include/IndustryStandard/PciExpress40.h
> +++ b/MdePkg/Include/IndustryStandard/PciExpress40.h
> @@ -4,6 +4,7 @@ Support for the PCI Express 4.0 standard.
> This header file may not define all structures. Please extend as required.
>
> Copyright (c) 2018, American Megatrends, Inc. All rights reserved.<BR>
> +Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -78,6 +79,33 @@ typedef struct {
> } PCI_EXPRESS_EXTENDED_CAPABILITIES_PHYSICAL_LAYER_16_0;
> ///@}
>
> +/// The Designated Vendor Specific Capability definitions /// Based on
> +section 7.9.6 of PCI Express Base Specification 4.0.
> +///@{
> +typedef union {
> + struct {
> + UINT32 DvsecVendorId : 16; //bit 0..15
> + UINT32 DvsecRevision : 4; //bit 16..19
> + UINT32 DvsecLength : 12; //bit 20..31
> + }Bits;
> + UINT32 Uint32;
> +}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1;
> +
> +typedef union {
> + struct {
> + UINT16 DvsecId : 16; //bit 0..15
> + }Bits;
> + UINT16 Uint16;
> +}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2;
> +
> +typedef struct {
> + PCI_EXPRESS_EXTENDED_CAPABILITIES_HEADER Header;
> + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1
> DesignatedVendorSpecificHeader1;
> + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2
> DesignatedVendorSpecificHeader2;
> + UINT8 DesignatedVendorSpecific[1];
> +}PCI_EXPRESS_EXTENDED_CAPABILITIES_DESIGNATED_VENDOR_SPECIFIC;
> +///@}
> +
> #pragma pack()
>
> #endif
> --
> 2.21.0.windows.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
2020-03-18 4:51 ` Javeed, Ashraf
@ 2020-03-18 15:51 ` Liming Gao
[not found] ` <15FD70D8928FA969.21252@groups.io>
1 sibling, 0 replies; 11+ messages in thread
From: Liming Gao @ 2020-03-18 15:51 UTC (permalink / raw)
To: Javeed, Ashraf, Liu, Zhiguang, devel@edk2.groups.io; +Cc: Kinney, Michael D
That's enough.
> -----Original Message-----
> From: Javeed, Ashraf <ashraf.javeed@intel.com>
> Sent: Wednesday, March 18, 2020 12:51 PM
> To: Gao, Liming <liming.gao@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
>
> Yes, I verified the build with this patch by directly referencing the new data types in a source file.
> Thanks
> Ashraf
>
> > -----Original Message-----
> > From: Gao, Liming <liming.gao@intel.com>
> > Sent: Wednesday, March 18, 2020 8:11 AM
> > To: Liu, Zhiguang <zhiguang.liu@intel.com>; Javeed, Ashraf
> > <ashraf.javeed@intel.com>; devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > Subject: RE: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
> >
> > Ashraf:
> > The change is good. Have you verified the build with this patch?
> >
> > Reviewed-by: Liming Gao <liming.gao@intel.com>
> >
> > Thanks
> > Liming
> > -----Original Message-----
> > From: Liu, Zhiguang <zhiguang.liu@intel.com>
> > Sent: 2020年3月17日 16:08
> > To: Javeed, Ashraf <ashraf.javeed@intel.com>; devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <liming.gao@intel.com>
> > Subject: RE: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
> >
> > Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> >
> > -----Original Message-----
> > From: Javeed, Ashraf
> > Sent: Tuesday, March 17, 2020 4:04 PM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <liming.gao@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>
> > Subject: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598
> >
> > All registers definition of DVSEC are defined as per the PCI Express Base
> > Specification 4.0 chapter 7.9.6.
> >
> > Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> >
> > V2: fixed the comment section description for DVSEC definitions
> > ---
> > MdePkg/Include/IndustryStandard/PciExpress40.h | 28
> > ++++++++++++++++++++++++++++
> > 1 file changed, 28 insertions(+)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/PciExpress40.h
> > b/MdePkg/Include/IndustryStandard/PciExpress40.h
> > index 9d9b272546..0564d72861 100644
> > --- a/MdePkg/Include/IndustryStandard/PciExpress40.h
> > +++ b/MdePkg/Include/IndustryStandard/PciExpress40.h
> > @@ -4,6 +4,7 @@ Support for the PCI Express 4.0 standard.
> > This header file may not define all structures. Please extend as required.
> >
> > Copyright (c) 2018, American Megatrends, Inc. All rights reserved.<BR>
> > +Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > **/
> > @@ -78,6 +79,33 @@ typedef struct {
> > } PCI_EXPRESS_EXTENDED_CAPABILITIES_PHYSICAL_LAYER_16_0;
> > ///@}
> >
> > +/// The Designated Vendor Specific Capability definitions /// Based on
> > +section 7.9.6 of PCI Express Base Specification 4.0.
> > +///@{
> > +typedef union {
> > + struct {
> > + UINT32 DvsecVendorId : 16; //bit 0..15
> > + UINT32 DvsecRevision : 4; //bit 16..19
> > + UINT32 DvsecLength : 12; //bit 20..31
> > + }Bits;
> > + UINT32 Uint32;
> > +}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1;
> > +
> > +typedef union {
> > + struct {
> > + UINT16 DvsecId : 16; //bit 0..15
> > + }Bits;
> > + UINT16 Uint16;
> > +}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2;
> > +
> > +typedef struct {
> > + PCI_EXPRESS_EXTENDED_CAPABILITIES_HEADER Header;
> > + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1
> > DesignatedVendorSpecificHeader1;
> > + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2
> > DesignatedVendorSpecificHeader2;
> > + UINT8 DesignatedVendorSpecific[1];
> > +}PCI_EXPRESS_EXTENDED_CAPABILITIES_DESIGNATED_VENDOR_SPECIFIC;
> > +///@}
> > +
> > #pragma pack()
> >
> > #endif
> > --
> > 2.21.0.windows.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
[not found] ` <15FD70D8928FA969.21252@groups.io>
@ 2020-03-19 2:02 ` Liming Gao
2020-03-19 6:57 ` Javeed, Ashraf
0 siblings, 1 reply; 11+ messages in thread
From: Liming Gao @ 2020-03-19 2:02 UTC (permalink / raw)
To: devel@edk2.groups.io, Gao, Liming, Javeed, Ashraf, Liu, Zhiguang
Cc: Kinney, Michael D
Merge @1b6b4a83e1d85e48837068dfe409f5557b50d71d
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao
Sent: 2020年3月18日 23:52
To: Javeed, Ashraf <ashraf.javeed@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
That's enough.
> -----Original Message-----
> From: Javeed, Ashraf <ashraf.javeed@intel.com>
> Sent: Wednesday, March 18, 2020 12:51 PM
> To: Gao, Liming <liming.gao@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition
> missing
>
> Yes, I verified the build with this patch by directly referencing the new data types in a source file.
> Thanks
> Ashraf
>
> > -----Original Message-----
> > From: Gao, Liming <liming.gao@intel.com>
> > Sent: Wednesday, March 18, 2020 8:11 AM
> > To: Liu, Zhiguang <zhiguang.liu@intel.com>; Javeed, Ashraf
> > <ashraf.javeed@intel.com>; devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > Subject: RE: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition
> > missing
> >
> > Ashraf:
> > The change is good. Have you verified the build with this patch?
> >
> > Reviewed-by: Liming Gao <liming.gao@intel.com>
> >
> > Thanks
> > Liming
> > -----Original Message-----
> > From: Liu, Zhiguang <zhiguang.liu@intel.com>
> > Sent: 2020年3月17日 16:08
> > To: Javeed, Ashraf <ashraf.javeed@intel.com>; devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <liming.gao@intel.com>
> > Subject: RE: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition
> > missing
> >
> > Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> >
> > -----Original Message-----
> > From: Javeed, Ashraf
> > Sent: Tuesday, March 17, 2020 4:04 PM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <liming.gao@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>
> > Subject: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598
> >
> > All registers definition of DVSEC are defined as per the PCI Express
> > Base Specification 4.0 chapter 7.9.6.
> >
> > Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> >
> > V2: fixed the comment section description for DVSEC definitions
> > ---
> > MdePkg/Include/IndustryStandard/PciExpress40.h | 28
> > ++++++++++++++++++++++++++++
> > 1 file changed, 28 insertions(+)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/PciExpress40.h
> > b/MdePkg/Include/IndustryStandard/PciExpress40.h
> > index 9d9b272546..0564d72861 100644
> > --- a/MdePkg/Include/IndustryStandard/PciExpress40.h
> > +++ b/MdePkg/Include/IndustryStandard/PciExpress40.h
> > @@ -4,6 +4,7 @@ Support for the PCI Express 4.0 standard.
> > This header file may not define all structures. Please extend as required.
> >
> > Copyright (c) 2018, American Megatrends, Inc. All rights
> > reserved.<BR>
> > +Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > **/
> > @@ -78,6 +79,33 @@ typedef struct {
> > } PCI_EXPRESS_EXTENDED_CAPABILITIES_PHYSICAL_LAYER_16_0;
> > ///@}
> >
> > +/// The Designated Vendor Specific Capability definitions /// Based
> > +on section 7.9.6 of PCI Express Base Specification 4.0.
> > +///@{
> > +typedef union {
> > + struct {
> > + UINT32 DvsecVendorId : 16; //bit 0..15
> > + UINT32 DvsecRevision : 4; //bit 16..19
> > + UINT32 DvsecLength : 12; //bit 20..31
> > + }Bits;
> > + UINT32 Uint32;
> > +}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1;
> > +
> > +typedef union {
> > + struct {
> > + UINT16 DvsecId : 16; //bit 0..15
> > + }Bits;
> > + UINT16 Uint16;
> > +}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2;
> > +
> > +typedef struct {
> > + PCI_EXPRESS_EXTENDED_CAPABILITIES_HEADER Header;
> > + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1
> > DesignatedVendorSpecificHeader1;
> > + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2
> > DesignatedVendorSpecificHeader2;
> > + UINT8 DesignatedVendorSpecific[1];
> > +}PCI_EXPRESS_EXTENDED_CAPABILITIES_DESIGNATED_VENDOR_SPECIFIC;
> > +///@}
> > +
> > #pragma pack()
> >
> > #endif
> > --
> > 2.21.0.windows.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
2020-03-19 2:02 ` [edk2-devel] " Liming Gao
@ 2020-03-19 6:57 ` Javeed, Ashraf
0 siblings, 0 replies; 11+ messages in thread
From: Javeed, Ashraf @ 2020-03-19 6:57 UTC (permalink / raw)
To: Gao, Liming, devel@edk2.groups.io, Liu, Zhiguang; +Cc: Kinney, Michael D
Thanks Liming!
Ashraf
> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Thursday, March 19, 2020 7:32 AM
> To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Javeed,
> Ashraf <ashraf.javeed@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC
> definition missing
>
> Merge @1b6b4a83e1d85e48837068dfe409f5557b50d71d
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming
> Gao
> Sent: 2020年3月18日 23:52
> To: Javeed, Ashraf <ashraf.javeed@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC
> definition missing
>
> That's enough.
>
> > -----Original Message-----
> > From: Javeed, Ashraf <ashraf.javeed@intel.com>
> > Sent: Wednesday, March 18, 2020 12:51 PM
> > To: Gao, Liming <liming.gao@intel.com>; Liu, Zhiguang
> > <zhiguang.liu@intel.com>; devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > Subject: RE: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition
> > missing
> >
> > Yes, I verified the build with this patch by directly referencing the new
> data types in a source file.
> > Thanks
> > Ashraf
> >
> > > -----Original Message-----
> > > From: Gao, Liming <liming.gao@intel.com>
> > > Sent: Wednesday, March 18, 2020 8:11 AM
> > > To: Liu, Zhiguang <zhiguang.liu@intel.com>; Javeed, Ashraf
> > > <ashraf.javeed@intel.com>; devel@edk2.groups.io
> > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > > Subject: RE: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition
> > > missing
> > >
> > > Ashraf:
> > > The change is good. Have you verified the build with this patch?
> > >
> > > Reviewed-by: Liming Gao <liming.gao@intel.com>
> > >
> > > Thanks
> > > Liming
> > > -----Original Message-----
> > > From: Liu, Zhiguang <zhiguang.liu@intel.com>
> > > Sent: 2020年3月17日 16:08
> > > To: Javeed, Ashraf <ashraf.javeed@intel.com>; devel@edk2.groups.io
> > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > > <liming.gao@intel.com>
> > > Subject: RE: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition
> > > missing
> > >
> > > Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > >
> > > -----Original Message-----
> > > From: Javeed, Ashraf
> > > Sent: Tuesday, March 17, 2020 4:04 PM
> > > To: devel@edk2.groups.io
> > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > > <liming.gao@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>
> > > Subject: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
> > >
> > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598
> > >
> > > All registers definition of DVSEC are defined as per the PCI Express
> > > Base Specification 4.0 chapter 7.9.6.
> > >
> > > Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <liming.gao@intel.com>
> > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > >
> > > V2: fixed the comment section description for DVSEC definitions
> > > ---
> > > MdePkg/Include/IndustryStandard/PciExpress40.h | 28
> > > ++++++++++++++++++++++++++++
> > > 1 file changed, 28 insertions(+)
> > >
> > > diff --git a/MdePkg/Include/IndustryStandard/PciExpress40.h
> > > b/MdePkg/Include/IndustryStandard/PciExpress40.h
> > > index 9d9b272546..0564d72861 100644
> > > --- a/MdePkg/Include/IndustryStandard/PciExpress40.h
> > > +++ b/MdePkg/Include/IndustryStandard/PciExpress40.h
> > > @@ -4,6 +4,7 @@ Support for the PCI Express 4.0 standard.
> > > This header file may not define all structures. Please extend as
> required.
> > >
> > > Copyright (c) 2018, American Megatrends, Inc. All rights
> > > reserved.<BR>
> > > +Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> > > SPDX-License-Identifier: BSD-2-Clause-Patent
> > >
> > > **/
> > > @@ -78,6 +79,33 @@ typedef struct {
> > > } PCI_EXPRESS_EXTENDED_CAPABILITIES_PHYSICAL_LAYER_16_0;
> > > ///@}
> > >
> > > +/// The Designated Vendor Specific Capability definitions /// Based
> > > +on section 7.9.6 of PCI Express Base Specification 4.0.
> > > +///@{
> > > +typedef union {
> > > + struct {
> > > + UINT32 DvsecVendorId : 16; //bit 0..15
> > > + UINT32 DvsecRevision : 4; //bit 16..19
> > > + UINT32 DvsecLength : 12; //bit 20..31
> > > + }Bits;
> > > + UINT32 Uint32;
> > > +}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1;
> > > +
> > > +typedef union {
> > > + struct {
> > > + UINT16 DvsecId : 16; //bit 0..15
> > > + }Bits;
> > > + UINT16 Uint16;
> > > +}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2;
> > > +
> > > +typedef struct {
> > > + PCI_EXPRESS_EXTENDED_CAPABILITIES_HEADER Header;
> > > + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1
> > > DesignatedVendorSpecificHeader1;
> > > + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2
> > > DesignatedVendorSpecificHeader2;
> > > + UINT8 DesignatedVendorSpecific[1];
> > >
> +}PCI_EXPRESS_EXTENDED_CAPABILITIES_DESIGNATED_VENDOR_SPECIFIC;
> > > +///@}
> > > +
> > > #pragma pack()
> > >
> > > #endif
> > > --
> > > 2.21.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
2020-03-17 8:04 [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing Javeed, Ashraf
2020-03-17 8:08 ` Zhiguang Liu
@ 2020-03-19 8:59 ` Ni, Ray
2020-03-19 10:00 ` Javeed, Ashraf
1 sibling, 1 reply; 11+ messages in thread
From: Ni, Ray @ 2020-03-19 8:59 UTC (permalink / raw)
To: Javeed, Ashraf, Gao, Liming, Liu, Zhiguang, Kinney, Michael D
Cc: devel@edk2.groups.io
I am sorry I just noticed this patch.
Is it better to have "DesignatedVendorSpecific[0]"?
This will make the sizeof (structure) more accurate.
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Javeed,
> Ashraf
> Sent: Tuesday, March 17, 2020 4:04 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition
> missing
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598
>
> All registers definition of DVSEC are defined as per the PCI Express Base
> Specification 4.0 chapter 7.9.6.
>
> Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>
> V2: fixed the comment section description for DVSEC definitions
> ---
> MdePkg/Include/IndustryStandard/PciExpress40.h | 28
> ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/PciExpress40.h
> b/MdePkg/Include/IndustryStandard/PciExpress40.h
> index 9d9b272546..0564d72861 100644
> --- a/MdePkg/Include/IndustryStandard/PciExpress40.h
> +++ b/MdePkg/Include/IndustryStandard/PciExpress40.h
> @@ -4,6 +4,7 @@ Support for the PCI Express 4.0 standard.
> This header file may not define all structures. Please extend as required.
>
> Copyright (c) 2018, American Megatrends, Inc. All rights reserved.<BR>
> +Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -78,6 +79,33 @@ typedef struct {
> } PCI_EXPRESS_EXTENDED_CAPABILITIES_PHYSICAL_LAYER_16_0;
> ///@}
>
> +/// The Designated Vendor Specific Capability definitions
> +/// Based on section 7.9.6 of PCI Express Base Specification 4.0.
> +///@{
> +typedef union {
> + struct {
> + UINT32 DvsecVendorId : 16; //bit 0..15
> + UINT32 DvsecRevision : 4; //bit 16..19
> + UINT32 DvsecLength : 12; //bit 20..31
> + }Bits;
> + UINT32 Uint32;
> +}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1;
> +
> +typedef union {
> + struct {
> + UINT16 DvsecId : 16; //bit 0..15
> + }Bits;
> + UINT16 Uint16;
> +}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2;
> +
> +typedef struct {
> + PCI_EXPRESS_EXTENDED_CAPABILITIES_HEADER Header;
> + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1
> DesignatedVendorSpecificHeader1;
> + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2
> DesignatedVendorSpecificHeader2;
> + UINT8 DesignatedVendorSpecific[1];
> +}PCI_EXPRESS_EXTENDED_CAPABILITIES_DESIGNATED_VENDOR_SPECIFIC;
> +///@}
> +
> #pragma pack()
>
> #endif
> --
> 2.21.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
2020-03-19 8:59 ` Ni, Ray
@ 2020-03-19 10:00 ` Javeed, Ashraf
2020-03-19 15:07 ` Ni, Ray
0 siblings, 1 reply; 11+ messages in thread
From: Javeed, Ashraf @ 2020-03-19 10:00 UTC (permalink / raw)
To: Ni, Ray, Gao, Liming, Liu, Zhiguang, Kinney, Michael D
Cc: devel@edk2.groups.io
All the PCIe capability structures with the PCI_EXPRESS_EXTENDED_CAPABILITIES_HEADER; that has variable length features have been implemented in this way. I am counting around 12 structures which have been defined in the same way.
> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Thursday, March 19, 2020 2:30 PM
> To: Javeed, Ashraf <ashraf.javeed@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Cc: devel@edk2.groups.io
> Subject: RE: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC
> definition missing
>
> I am sorry I just noticed this patch.
> Is it better to have "DesignatedVendorSpecific[0]"?
> This will make the sizeof (structure) more accurate.
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Javeed,
> > Ashraf
> > Sent: Tuesday, March 17, 2020 4:04 PM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <liming.gao@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>
> > Subject: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC
> > definition missing
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598
> >
> > All registers definition of DVSEC are defined as per the PCI Express
> > Base Specification 4.0 chapter 7.9.6.
> >
> > Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> >
> > V2: fixed the comment section description for DVSEC definitions
> > ---
> > MdePkg/Include/IndustryStandard/PciExpress40.h | 28
> > ++++++++++++++++++++++++++++
> > 1 file changed, 28 insertions(+)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/PciExpress40.h
> > b/MdePkg/Include/IndustryStandard/PciExpress40.h
> > index 9d9b272546..0564d72861 100644
> > --- a/MdePkg/Include/IndustryStandard/PciExpress40.h
> > +++ b/MdePkg/Include/IndustryStandard/PciExpress40.h
> > @@ -4,6 +4,7 @@ Support for the PCI Express 4.0 standard.
> > This header file may not define all structures. Please extend as required.
> >
> > Copyright (c) 2018, American Megatrends, Inc. All rights
> > reserved.<BR>
> > +Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > **/
> > @@ -78,6 +79,33 @@ typedef struct {
> > } PCI_EXPRESS_EXTENDED_CAPABILITIES_PHYSICAL_LAYER_16_0;
> > ///@}
> >
> > +/// The Designated Vendor Specific Capability definitions /// Based
> > +on section 7.9.6 of PCI Express Base Specification 4.0.
> > +///@{
> > +typedef union {
> > + struct {
> > + UINT32 DvsecVendorId : 16; //bit 0..15
> > + UINT32 DvsecRevision : 4; //bit 16..19
> > + UINT32 DvsecLength : 12; //bit 20..31
> > + }Bits;
> > + UINT32 Uint32;
> > +}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1;
> > +
> > +typedef union {
> > + struct {
> > + UINT16 DvsecId : 16; //bit 0..15
> > + }Bits;
> > + UINT16 Uint16;
> > +}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2;
> > +
> > +typedef struct {
> > + PCI_EXPRESS_EXTENDED_CAPABILITIES_HEADER Header;
> > + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1
> > DesignatedVendorSpecificHeader1;
> > + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2
> > DesignatedVendorSpecificHeader2;
> > + UINT8 DesignatedVendorSpecific[1];
> >
> +}PCI_EXPRESS_EXTENDED_CAPABILITIES_DESIGNATED_VENDOR_SPECIFIC;
> > +///@}
> > +
> > #pragma pack()
> >
> > #endif
> > --
> > 2.21.0.windows.1
> >
> >
> >
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
2020-03-19 10:00 ` Javeed, Ashraf
@ 2020-03-19 15:07 ` Ni, Ray
0 siblings, 0 replies; 11+ messages in thread
From: Ni, Ray @ 2020-03-19 15:07 UTC (permalink / raw)
To: Javeed, Ashraf, Gao, Liming, Liu, Zhiguang, Kinney, Michael D
Cc: devel@edk2.groups.io
I agree with you about that fact😊
These "[1]" was added 6 years ago when "[0]" still caused compilation failure.
Later, about 5 years ago, Mike enabled "[0]" with the below change in MdePkg/Include/Base.h:
//
// Disable warning when last field of data structure is a zero sized array.
//
#pragma warning ( disable : 4200 )
We cannot change these "[1]" to "[0]" because that would cause existing code that depends on
sizeof() result fails.
But for new code, it's encouraged to use "[0]".
Thanks,
Ray
> -----Original Message-----
> From: Javeed, Ashraf <ashraf.javeed@intel.com>
> Sent: Thursday, March 19, 2020 6:00 PM
> To: Ni, Ray <ray.ni@intel.com>; Gao, Liming <liming.gao@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Cc: devel@edk2.groups.io
> Subject: RE: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
>
> All the PCIe capability structures with the PCI_EXPRESS_EXTENDED_CAPABILITIES_HEADER; that has variable length
> features have been implemented in this way. I am counting around 12 structures which have been defined in the same
> way.
>
> > -----Original Message-----
> > From: Ni, Ray <ray.ni@intel.com>
> > Sent: Thursday, March 19, 2020 2:30 PM
> > To: Javeed, Ashraf <ashraf.javeed@intel.com>; Gao, Liming
> > <liming.gao@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Kinney,
> > Michael D <michael.d.kinney@intel.com>
> > Cc: devel@edk2.groups.io
> > Subject: RE: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC
> > definition missing
> >
> > I am sorry I just noticed this patch.
> > Is it better to have "DesignatedVendorSpecific[0]"?
> > This will make the sizeof (structure) more accurate.
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Javeed,
> > > Ashraf
> > > Sent: Tuesday, March 17, 2020 4:04 PM
> > > To: devel@edk2.groups.io
> > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > > <liming.gao@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>
> > > Subject: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC
> > > definition missing
> > >
> > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598
> > >
> > > All registers definition of DVSEC are defined as per the PCI Express
> > > Base Specification 4.0 chapter 7.9.6.
> > >
> > > Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <liming.gao@intel.com>
> > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > >
> > > V2: fixed the comment section description for DVSEC definitions
> > > ---
> > > MdePkg/Include/IndustryStandard/PciExpress40.h | 28
> > > ++++++++++++++++++++++++++++
> > > 1 file changed, 28 insertions(+)
> > >
> > > diff --git a/MdePkg/Include/IndustryStandard/PciExpress40.h
> > > b/MdePkg/Include/IndustryStandard/PciExpress40.h
> > > index 9d9b272546..0564d72861 100644
> > > --- a/MdePkg/Include/IndustryStandard/PciExpress40.h
> > > +++ b/MdePkg/Include/IndustryStandard/PciExpress40.h
> > > @@ -4,6 +4,7 @@ Support for the PCI Express 4.0 standard.
> > > This header file may not define all structures. Please extend as required.
> > >
> > > Copyright (c) 2018, American Megatrends, Inc. All rights
> > > reserved.<BR>
> > > +Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> > > SPDX-License-Identifier: BSD-2-Clause-Patent
> > >
> > > **/
> > > @@ -78,6 +79,33 @@ typedef struct {
> > > } PCI_EXPRESS_EXTENDED_CAPABILITIES_PHYSICAL_LAYER_16_0;
> > > ///@}
> > >
> > > +/// The Designated Vendor Specific Capability definitions /// Based
> > > +on section 7.9.6 of PCI Express Base Specification 4.0.
> > > +///@{
> > > +typedef union {
> > > + struct {
> > > + UINT32 DvsecVendorId : 16; //bit 0..15
> > > + UINT32 DvsecRevision : 4; //bit 16..19
> > > + UINT32 DvsecLength : 12; //bit 20..31
> > > + }Bits;
> > > + UINT32 Uint32;
> > > +}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1;
> > > +
> > > +typedef union {
> > > + struct {
> > > + UINT16 DvsecId : 16; //bit 0..15
> > > + }Bits;
> > > + UINT16 Uint16;
> > > +}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2;
> > > +
> > > +typedef struct {
> > > + PCI_EXPRESS_EXTENDED_CAPABILITIES_HEADER Header;
> > > + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1
> > > DesignatedVendorSpecificHeader1;
> > > + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2
> > > DesignatedVendorSpecificHeader2;
> > > + UINT8 DesignatedVendorSpecific[1];
> > >
> > +}PCI_EXPRESS_EXTENDED_CAPABILITIES_DESIGNATED_VENDOR_SPECIFIC;
> > > +///@}
> > > +
> > > #pragma pack()
> > >
> > > #endif
> > > --
> > > 2.21.0.windows.1
> > >
> > >
> > >
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-03-19 15:07 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-17 8:04 [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing Javeed, Ashraf
2020-03-17 8:08 ` Zhiguang Liu
2020-03-18 2:40 ` Liming Gao
2020-03-18 4:51 ` Javeed, Ashraf
2020-03-18 15:51 ` Liming Gao
[not found] ` <15FD70D8928FA969.21252@groups.io>
2020-03-19 2:02 ` [edk2-devel] " Liming Gao
2020-03-19 6:57 ` Javeed, Ashraf
2020-03-19 8:59 ` Ni, Ray
2020-03-19 10:00 ` Javeed, Ashraf
2020-03-19 15:07 ` Ni, Ray
[not found] <15FD081950A8E1F5.25941@groups.io>
2020-03-17 7:56 ` [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: " Javeed, Ashraf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox