From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.128.67; helo=mail-wm1-f67.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 85E5221A00AE6 for ; Wed, 7 Nov 2018 06:05:15 -0800 (PST) Received: by mail-wm1-f67.google.com with SMTP id r11-v6so1453453wmb.2 for ; Wed, 07 Nov 2018 06:05:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/j2ltOzAyif1gxDUWp9zCJjlSRPGsqd4AhM67DZBQ/I=; b=P/+buBPqG3SMhZHJZEYLD2XeKZ+AkcUY+3kcNCqn1dab6grQfkUkZU8S3hktUI/cUm pzZTSzVfaUroN/luHapuEASd/X28B1CxIhGVqmxtsZzVsGueL0AB7qV5imVBb6R9EZZE qpa/dHppst1vcowHCK6BL7mso3em2geRxQx1uqEDAoEpR4NFJnC6sFCOdwxGSbNkO/xj AFkHNtLoGBFQhcupSIuoc/WkwtP2S9793iVd3t1TGCTVk9HKXqZ9UV+sbhHuivH2t+1j 1r3WZYfR76/KO7ftdPqRbrSuKfOj+N/7AIRy3MTPdsxup7ccTWlF6SfChYi7Q+TBOU3W HG0w== X-Gm-Message-State: AGRZ1gIcRpKRdua2kG97bQW1KGmicd8vX9QCUzLBcXB1PxK1wfBPgDW1 bncr+3O4xmzgmSQJUWBnGEZ8fw== X-Google-Smtp-Source: AJdET5etlBSqOZ0mTBEWVRc1m1bfXFgSYffV3RWgT0Jzow6H+MySeJZsvRJgfecwtt3woTUHBYyNiA== X-Received: by 2002:a1c:954b:: with SMTP id x72-v6mr330061wmd.14.1541599513708; Wed, 07 Nov 2018 06:05:13 -0800 (PST) Received: from [10.0.0.124] ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id p17-v6sm584815wmc.16.2018.11.07.06.05.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Nov 2018 06:05:13 -0800 (PST) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: michael.d.kinney@intel.com, eric.jin@intel.com References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> <20181106175833.26964-9-ard.biesheuvel@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <95b45a9a-73b9-4cc4-9a03-eccdb4db148f@redhat.com> Date: Wed, 7 Nov 2018 15:05:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181106175833.26964-9-ard.biesheuvel@linaro.org> Subject: Re: [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 14:05:15 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 6/11/18 18:58, Ard Biesheuvel wrote: > Unlike Visual Studio, GCC does not permit implicit conversion between > a pointer-to-void-pointer and pointer to a typed pointer. So add the > explicit casts where necessary. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daudé > --- > IntelUndiPkg/GigUndiDxe/Hii.c | 8 ++++---- > IntelUndiPkg/GigUndiDxe/Init.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c > index 43c184cb03c8..a5d8ae207819 100644 > --- a/IntelUndiPkg/GigUndiDxe/Hii.c > +++ b/IntelUndiPkg/GigUndiDxe/Hii.c > @@ -459,7 +459,7 @@ HiiOpenProtocol ( > Status = gBS->LocateProtocol ( > &gEfiHiiDatabaseProtocolGuid, > NULL, > - &UndiPrivateData->HiiDatabase > + (VOID **)&UndiPrivateData->HiiDatabase > ); > if (EFI_ERROR (Status)) { > DEBUGPRINT (CRITICAL, ("Error finding HII protocol: %r\n", Status)); > @@ -472,7 +472,7 @@ HiiOpenProtocol ( > Status = gBS->LocateProtocol ( > &gEfiHiiStringProtocolGuid, > NULL, > - &UndiPrivateData->HiiString > + (VOID **)&UndiPrivateData->HiiString > ); > if (EFI_ERROR (Status)) { > DEBUGPRINT (CRITICAL, ("Error finding HII String protocol: %r\n", Status)); > @@ -485,7 +485,7 @@ HiiOpenProtocol ( > Status = gBS->LocateProtocol ( > &gEfiFormBrowser2ProtocolGuid, > NULL, > - &UndiPrivateData->FormBrowser2 > + (VOID **)&UndiPrivateData->FormBrowser2 > ); > if (EFI_ERROR (Status)) { > DEBUGPRINT (CRITICAL, ("Error finding HII form browser protocol: %r\n", Status)); > @@ -498,7 +498,7 @@ HiiOpenProtocol ( > Status = gBS->LocateProtocol ( > &gEfiHiiConfigRoutingProtocolGuid, > NULL, > - &UndiPrivateData->HiiConfigRouting > + (VOID **)&UndiPrivateData->HiiConfigRouting > ); > if (EFI_ERROR (Status)) { > DEBUGPRINT (CRITICAL, ("Error finding HII ConfigRouting protocol: %r\n", Status)); > diff --git a/IntelUndiPkg/GigUndiDxe/Init.c b/IntelUndiPkg/GigUndiDxe/Init.c > index f99734d72823..1de424c26fe2 100644 > --- a/IntelUndiPkg/GigUndiDxe/Init.c > +++ b/IntelUndiPkg/GigUndiDxe/Init.c > @@ -177,7 +177,7 @@ GigAppendMac2DevPath ( > Status = gBS->AllocatePool ( > EfiBootServicesData, // EfiRuntimeServicesData, > TotalPathLen, > - &DevicePtr > + (VOID **)&DevicePtr > ); > > if (Status != EFI_SUCCESS) { >