Re: [PATCH 22/22] .mailmap: add entries for Rebecca Cran

["Laszlo Ersek" <lersek@redhat.com>]

Hello Rebecca,

On 09/08/20 00:15, Rebecca Cran wrote:
> On 9/7/20 1:31 PM, Laszlo Ersek wrote:
>> ... for git-shortlog purposes.
>>
>> NOTE: this patch does not introduce a cross-domain mapping; it only
>> maps both email addresses of Rebecca to the full name "Rebecca Cran".
>
> I'm no longer using the bluestop.org email address for EDK2 mail,

That's irrelevant for the purpose of this patch series -- it targets
commits that you contributed in the past. When checking a git-shortlog
for a particular commit range, if you have contributed during that time
from multiple email addresses, it's strongly preferable to collect them
all under your real name Rebecca Cran.

Consider the following command:

$ git shortlog edk2-stable201905..edk2-stable202008

Without this patch (set), it prints (excerpt):

> Rebecca Cran (15):
>       OvmfPkg/build.sh: enable multitheaded build by default
>       OvmfPkg/build.sh: remove $ADD_QEMU_HDA
>       OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu
>       OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones
>       OvmfPkg: Add bhyve support into AcpiTimerLib
>       OvmfPkg: Add VBE2 mode info structure to LegacyVgaBios.h
>       OvmfPkg: Add QemuFwCfgLibNull
>       OvmfPkg: Add BaseResetSystemLibBhyve
>       BaseTools: add repo name option to SetupGit.py
>       ShellPkg: smbiosview - print field values as unsigned integers
>       BaseTools: Update ReadMe.txt to match current functionality
>       BaseTools: rename ReadMe.txt to ReadMe.rst
>       Add BhyvePkg, to support the bhyve hypervisor
>       Maintainers.txt: Add bhyve reviewers
>       OvmfPkg/Bhyve: rename files to remove 'Pkg' infix
>
> rebecca@bluestop.org (1):
>       Fix indentation in edksetup.sh SetupPython3
>
> rebecca@bsdio.com (5):
>       edksetup.sh: Use bash variable $PWD instead of executing pwd command
>       edksetup.sh: Use $SCRIPTNAME consistently instead of 'edksetup.sh'
>       edksetup.sh: when executing arithmetic commands, $ isn't needed
>       edksetup.sh: remove redundant -?, -h and --help in options parsing
>       OvmfPkg/build.sh: remove literal carriage return

With this patch, it prints:

> Rebecca Cran (21):
>       Fix indentation in edksetup.sh SetupPython3
>       edksetup.sh: Use bash variable $PWD instead of executing pwd command
>       edksetup.sh: Use $SCRIPTNAME consistently instead of 'edksetup.sh'
>       edksetup.sh: when executing arithmetic commands, $ isn't needed
>       edksetup.sh: remove redundant -?, -h and --help in options parsing
>       OvmfPkg/build.sh: enable multitheaded build by default
>       OvmfPkg/build.sh: remove literal carriage return
>       OvmfPkg/build.sh: remove $ADD_QEMU_HDA
>       OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu
>       OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones
>       OvmfPkg: Add bhyve support into AcpiTimerLib
>       OvmfPkg: Add VBE2 mode info structure to LegacyVgaBios.h
>       OvmfPkg: Add QemuFwCfgLibNull
>       OvmfPkg: Add BaseResetSystemLibBhyve
>       BaseTools: add repo name option to SetupGit.py
>       ShellPkg: smbiosview - print field values as unsigned integers
>       BaseTools: Update ReadMe.txt to match current functionality
>       BaseTools: rename ReadMe.txt to ReadMe.rst
>       Add BhyvePkg, to support the bhyve hypervisor
>       Maintainers.txt: Add bhyve reviewers
>       OvmfPkg/Bhyve: rename files to remove 'Pkg' infix

Unless you prefer the former output, please ACK this patch.

(Note that this mapping is not cross-domain, as it simply maps different
(possibly historical) email addresses of yours to your real name.
Cross-domain mapping would be if we replaced an *email address* with
another, when displaying the commit log (such as "git-log
--use-mailmap"). That is also possible  with mailmap, but not what we're
doing here.)

> but since I'll be working on UEFI for my new job, it might be worth
> adding it instead:
>
>
> rebecca@nuviainc.com

This is certainly useful -- in addition to the present patch.

I can respin this one patch later, or we can add your @nuviainc.com
email address separately, later on.

(NB your entry in Maintainers.txt still says <rebecca@bsdio.com>; please
consider updating that if necessary.)

Thanks!
Laszlo