From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 13 Jun 2019 07:17:17 -0700 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B03F07F746; Thu, 13 Jun 2019 14:17:11 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-127.ams2.redhat.com [10.36.117.127]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D4AF2B443; Thu, 13 Jun 2019 14:17:08 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 09/10] OvmfPkg/Csm/LegacyBootManagerLib: Update to make it build for OVMF To: devel@edk2.groups.io, hao.a.wu@intel.com Cc: David Woodhouse , Ray Ni , Jordan Justen , Ard Biesheuvel References: <20190527030350.11996-1-hao.a.wu@intel.com> <20190527030350.11996-10-hao.a.wu@intel.com> From: "Laszlo Ersek" Message-ID: <95ce5dad-94f9-cf7f-714a-dbf87879ca6e@redhat.com> Date: Thu, 13 Jun 2019 16:17:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190527030350.11996-10-hao.a.wu@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 13 Jun 2019 14:17:11 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/27/19 05:03, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811 > > This commit will update the library's INF file to: > > A) Assign a new file GUID; > B) Remove the IntelFramework[Module]Pkg DEC file dependency. > > Please note that a subsequent commit (final patch of the series) will: > > Replace the use of LegacyBootManagerLib in IntelFrameworkModulePkg with > the one copied in OvmfPkg within DSC files. > > Cc: David Woodhouse > Cc: Ray Ni > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Hao A Wu > --- > OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.inf | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.inf b/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.inf > index eaf7b7235d..e43351cf95 100644 > --- a/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.inf > +++ b/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.inf > @@ -1,7 +1,7 @@ > ## @file > # Legacy Boot Manager module is library for BDS phase. > # > -# Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.
> +# Copyright (c) 2011 - 2019, Intel Corporation. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## > @@ -10,7 +10,7 @@ [Defines] > INF_VERSION = 0x00010005 > BASE_NAME = LegacyBootManagerLib > MODULE_UNI_FILE = LegacyBootManagerLib.uni > - FILE_GUID = F1B87BE4-0ACC-409A-A52B-7BFFABCC96A0 > + FILE_GUID = D1BBB810-6A9E-40E0-87CB-65EAD2AA2A09 > MODULE_TYPE = DXE_DRIVER > VERSION_STRING = 1.0 > LIBRARY_CLASS = NULL|DXE_DRIVER UEFI_APPLICATION > @@ -29,8 +29,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > - IntelFrameworkPkg/IntelFrameworkPkg.dec > - IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec > + OvmfPkg/OvmfPkg.dec > > [LibraryClasses] > BaseLib > Reviewed-by: Laszlo Ersek