From: "Laszlo Ersek" <lersek@redhat.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Andrew Fish <afish@apple.com>, Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [edk2-devel] [WebSite Patch] Change preferred license of EDK II to BSD+Patent
Date: Fri, 19 Apr 2019 00:43:28 +0200 [thread overview]
Message-ID: <95d27d3d-7f35-cabb-997f-638ccc441e77@redhat.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9C9AF3E@ORSMSX113.amr.corp.intel.com>
On 04/18/19 22:27, Kinney, Michael D wrote:
>
>
>> -----Original Message-----
>> From: devel@edk2.groups.io
>> [mailto:devel@edk2.groups.io] On Behalf Of Laszlo Ersek
>> Sent: Thursday, April 18, 2019 2:14 AM
>> To: Kinney, Michael D <michael.d.kinney@intel.com>;
>> devel@edk2.groups.io
>> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm
>> <leif.lindholm@linaro.org>
>> Subject: Re: [edk2-devel] [WebSite Patch] Change
>> preferred license of EDK II to BSD+Patent
>>
>> On 04/18/19 05:31, Kinney, Michael D wrote:
>>> Laszlo,
>>>
>>> I am still working on how to pre-view these changes
>> as they
>>> would appear on the website once checked in.
>>
>> That's OK -- in this case I'm fine if I can only look
>> at the pre-patch
>> rendering. But those rendered pages, I would like to
>> see.
>>
>>> There are 4 files patched. Only the following one is
>>> accessible from GitHub pages.
>>>
>>> https://www.tianocore.org/legalese.html
>>>
>>> The other three files appear to be old information
>> that
>>> needs to be deleted. The links for these details now
>> point
>>> to a wiki page instead of a web site page.
>>>
>>> > > edk2/index.md | 3 +--
>>> > > ovmf/index.md | 2 +-
>>> > > site/index.md | 2 +-
>>
>> Yes, this was my experience exactly -- from the
>> filenames in the patch,
>> I tried to construct the URLs manually, and all except
>> one redirected me
>> to the wiki.
>>
>> So we're updating dead pages too, in this patch. Should
>> we replace those
>> hunks with the removals of the dead pages instad? (I
>> presume the dead
>> pages do not participate in the redirection actions.)
>
> I did the patch based on the content from the git repo
> for the web site. I did not realize that three of them
> appear to be unreachable content.
>
> I would prefer to have this patch series go through, and I
> will open a new BZ to remove dead pages.
OK, I'll review the patch right under the thread starter -- the context
has been garbled here, down-thread, by now.
Thanks
Laszlo
next prev parent reply other threads:[~2019-04-18 22:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 20:38 [WebSite Patch] Change preferred license of EDK II to BSD+Patent Michael D Kinney
2019-04-16 12:46 ` Laszlo Ersek
2019-04-18 3:31 ` [edk2-devel] " Michael D Kinney
2019-04-18 9:14 ` Laszlo Ersek
2019-04-18 20:27 ` Michael D Kinney
2019-04-18 22:43 ` Laszlo Ersek [this message]
2019-04-18 22:52 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95d27d3d-7f35-cabb-997f-638ccc441e77@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox