From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mx.groups.io with SMTP id smtpd.web08.360.1616091977806090107 for ; Thu, 18 Mar 2021 11:26:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fD0T3XLy; spf=pass (domain: gmail.com, ip: 209.85.215.169, mailfrom: kuqin12@gmail.com) Received: by mail-pg1-f169.google.com with SMTP id v3so2000359pgq.2 for ; Thu, 18 Mar 2021 11:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oEDOcOzDFWQTGWIXxVpqQFw4SeueGzjGI9FPbd2cadw=; b=fD0T3XLylqs8bFYIcj6JzsKaYTSD+DN/lll/3JzPhNTOpOvoPbOQcP4dvKD/tzkBqC l56bgbrSbDYPRXXd7b7MvDCGBnHivTVrA9IfKaGmIsXMHfl2ggNEPzEpQyN+2kjjFwIx ztFBMttMk6vWeytPSlB729ZjmIcUBza/aGwJ8upzk2EjtxPPVphrMMf3sGv7BxQ2mgpI yFt4fXjeTk47XZg+WWqtQQimMH16/V9X2+BUYfyXRgK6UgFE/GIKuSxQ2rzUZFSt97Gf Dp52QopghK9kVfXZSeiAfOMnf1DQUVUopxwSwIZ7KB7y5JXud0532RVg+seuWo1Rki2s eA/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oEDOcOzDFWQTGWIXxVpqQFw4SeueGzjGI9FPbd2cadw=; b=gVwsgC/0XjVQ0ypZuxRFxeD3/OeLeRN6GBT+I8/sf4OEIEqIciE3gue5x3s+ZT80c5 YXTW74dBzKztH40WuMmDwtCcedhQxM+bPoCEmkVTj1TqCpbWaxRxAJNnAv+o/4Tc1ULl 1jwJAo46s+qt5w7kbaYNdvJEnfNBgFKfQGy/j8mfjlguKGssfWsMEEa03ecKH/QtFmFN CR8O6ohtNOLTa99vrmI0qhC3VkTdwMhBBxY8y2oMvnt7OJyvcDHYtKKuEK/wszHkOfOf wJXVoDHX/+uJc/Wzs1JzHC/N5OSRrEH2x+IOhpBV19NDvOT1NC4p0+U1+ngT1DVrMCBt mAaQ== X-Gm-Message-State: AOAM5304RJ1YzR9+BJy8aae0tg8QY3HTrXv7wbpfN0amGr00275ALW6/ 8LYmOvNHGF+LrEGtPXnJ1aA= X-Google-Smtp-Source: ABdhPJzM9e/Vpa4P9yLsO6r86SWQ9SMeyVSIS4gbX/6WDeRv00r8SiKqSLMlmpJT8rcs+a8QWnb5bg== X-Received: by 2002:a05:6a00:22c6:b029:201:1166:fdad with SMTP id f6-20020a056a0022c6b02902011166fdadmr5344589pfj.58.1616091977184; Thu, 18 Mar 2021 11:26:17 -0700 (PDT) Return-Path: Received: from [192.168.50.18] ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id u79sm2365152pfc.207.2021.03.18.11.26.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Mar 2021 11:26:16 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 5/5] Socionext: DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe To: Ard Biesheuvel Cc: devel@edk2.groups.io, Ard Biesheuvel , Leif Lindholm References: <20210316181038.1413-1-kuqin12@gmail.com> <166CE5173C17A517.7039@groups.io> From: "Kun Qin" Message-ID: <95dbf461-6f84-b3f5-3a49-31bf3d0d6dad@gmail.com> Date: Thu, 18 Mar 2021 11:26:15 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ard, Thanks for providing the tag. For my own learning purpose, could you please let me know how I can get a "reviewed-by" tag for this change? Should I add more reviewers than package maintainers listed on "Maintainers.txt"? Thanks for the help. Regards, Kun On 03/18/2021 11:14, Ard Biesheuvel wrote: > On Thu, 18 Mar 2021 at 19:07, Kun Qin wrote: >> >> Hi Ard/Leif, >> >> Could you please review the change and let me know if you have any >> feedback when there is chance? I can drop the patch if this package is >> not supported/maintained any more. Please let me know how you would like >> to proceed. >> >> Thanks in advance. >> >> Regards, >> Kun >> >> On 03/16/2021 11:10, Kun Qin via groups.io wrote: >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250 >>> >>> This change added NULL MmUnblockMemoryLib instance in DeveloperBox.dsc to >>> resolve new dependency by VariableSmmRuntimeDxe. The library interface >>> is consumed by variable module to better support variable runtime cache >>> feature. >>> >>> Cc: Ard Biesheuvel >>> Cc: Leif Lindholm >>> >>> Signed-off-by: Kun Qin > > Acked-by: Ard Biesheuvel > >>> --- >>> >>> Notes: >>> v2: >>> - No review, no change. >>> >>> Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc >>> index 0a11b796cca5..acaa4cd90fc5 100644 >>> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc >>> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc >>> @@ -49,6 +49,8 @@ [LibraryClasses] >>> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf >>> !endif >>> >>> + MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf >>> + >>> [LibraryClasses.common.SEC] >>> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >>> BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf >>>