From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 14760740046 for ; Mon, 18 Dec 2023 15:12:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QCGGMYfHEoHlvWe192YTQFZxqH8eCrrZ9cYdiORSbVc=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702912351; v=1; b=aHMIHkLQiuMwJVEgf8P9w21lWvwZXXL0up8Ie7+Ey8uKhBAlFjCW9n5VwlzXMdbnNF9ptY/F vk6tX8g/2m6sy/2isvDYIKr2xoZ7Sjdy2C9rqwUz5hK1gPLQen0lkf6km/Lc+lByS7/pbxWXSes dq+mlgs14KTVVTrFr0oiWNyQ= X-Received: by 127.0.0.2 with SMTP id rL2uYY7687511xjirNfT8xSl; Mon, 18 Dec 2023 07:12:31 -0800 X-Received: from EUR02-AM0-obe.outbound.protection.outlook.com (EUR02-AM0-obe.outbound.protection.outlook.com [40.107.247.42]) by mx.groups.io with SMTP id smtpd.web11.46107.1702912350833099536 for ; Mon, 18 Dec 2023 07:12:31 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FWRK1gSJoHxGuzW0JroLMcnP6abT/57pH4WYoau0eh7/5g3pm31eace1Txsm4uq/1HG4bI6y4o7gbt9uq1F1XnxZ0xTk/TdJMUrP0iloYtvH3ZCZpNyDiZiilrvpwEv49W/tNtRrvycQNOe+zVg91aItPTa+cJZg6rHmsPYF3ulHVq446TSp0ItpEysfemjw3xfKcy36iFIfJ8g/65ooiRf7JeHD7SQqAFMaRLwTZaf3Mrsj0VX/RJI5l7xGrUNKY25FR7mCBrcspvAR2wCmRQA/zWAH+MfxJKJkyVAp7FPXKGfFG6hJl7Jy68eioDEw8jx2T043iQ8WwOWZA0lg4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MBauA0V6mLkk8ADPikZGB2UEXlVdH/saYaHGNIOYinc=; b=dGEZe9DNsh5/ThzJOdYlQ/A2rDbi/IMNQX1OuhiS+6NK1VuKfJmhfGTZb7LR67RhqAnjXxdA6MQk+8v30zcAPYT13ddOlZkgtCXkR0b30euj8LdMKUj1undQ24jitu/G7tIm2GLrxXCdzW7bEn4lu3dM+CdHHFM5vddFNGUN1OhDAQv0LtbVW1NW7H2VYcKDhTJ8BnB/eCELptpwvuS3qOrjKvdIDWu2/aQf/zQG83rVqLUvF0Cju6FFipIP0GF83BErzdhwB5R9aT4UPx9mwSpnWWl5PMUr5ZGbA2YKYpzsqZ0D4i9JZ2tlJpI5tPzYcJTf1qsH6IrANmC+x6vS6A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from AM6P192CA0032.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::45) by PAXPR08MB6719.eurprd08.prod.outlook.com (2603:10a6:102:137::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 15:12:26 +0000 X-Received: from AMS0EPF000001B0.eurprd05.prod.outlook.com (2603:10a6:209:83:cafe::7d) by AM6P192CA0032.outlook.office365.com (2603:10a6:209:83::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37 via Frontend Transport; Mon, 18 Dec 2023 15:12:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF000001B0.mail.protection.outlook.com (10.167.16.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.14 via Frontend Transport; Mon, 18 Dec 2023 15:12:25 +0000 X-Received: ("Tessian outbound 26ee1d40577c:v228"); Mon, 18 Dec 2023 15:12:25 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e73934c1000ced71 X-CR-MTA-TID: 64aa7808 X-Received: from 2d02ccb01daf.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A9E53483-B516-4D39-B4A5-4A4510120C9F.1; Mon, 18 Dec 2023 15:12:14 +0000 X-Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2d02ccb01daf.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 18 Dec 2023 15:12:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P8bXIojNGUNgbGuw5SGha5h9m62oV74KSUd+wepMsZXApPekFoe13afNuzfl0oQCYce/QdmCy5xOPLZCtUOmgUYUSTvXGh1iNE5QUdSmol+V3xftxR79NH4GOnm4jfIpMAPRHMh21eDrUKJF3EaYiI46knxHuebnWNZtD7nkmi5lH/wmRD1DCjtzsxcrMj32G/wC04LpTHLoWp+WtbqFWBnvKJOSAp6NlfYsWe7l7hBmUkaFDI83PcYCAcrgCpkQWQrc0zCZF/uJvdo4vWX57M7ffpNgFpfABNhT6aRg9UU0ugN6mFAwFIG1XF623ahCZPW9asR3MfGI2RGfWS+YVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MBauA0V6mLkk8ADPikZGB2UEXlVdH/saYaHGNIOYinc=; b=Bf4mXG+xc9h54g9HFH/eCW9Djtr7Flzh90Hwt16Fv/d5DkpabASvG6/Tk2sYG0n3BHcw6rsxpYzTQ8p+YLCkXA+9qW6pWtwIkz+wznIRc9FanBZ1s14KyiQgy0ObyOiHezZ9/bXqooLqG1QAhA/B7wH8NTSMrIklyjjLc4AEK3VAH4Y8815f5ZeTkDlVzvXpz70w+SFizLFk16TVjfc625N2xGEcW/CX4qEWRQkXpCXfZTDALuLzybsMcvJGmWHJIEUhUkDMnm74rHOQ5kPUWQwBxLZhK60nMt75PQTBvrWbOj5e/MchubjqfFX1Xn4Ck6lTUfHlcsdb2vmH+Jl9vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB8947.eurprd08.prod.outlook.com (2603:10a6:20b:5b3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 15:12:11 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775%4]) with mapi id 15.20.7091.034; Mon, 18 Dec 2023 15:12:10 +0000 Message-ID: <9605d103-25d5-4055-a565-df47c9b3a49e@arm.com> Date: Mon, 18 Dec 2023 15:12:06 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/5] Silicon/ARM/NeoverseN1Soc: Enable SCP QSPI flash region To: devel@edk2.groups.io, sahil@arm.com Cc: Ard Biesheuvel , Leif Lindholm , "nd@arm.com" References: <20231116114554.4055517-1-sahil@arm.com> <20231116114554.4055517-2-sahil@arm.com> From: "Sami Mujawar" In-Reply-To: <20231116114554.4055517-2-sahil@arm.com> X-ClientProxiedBy: LO4P123CA0066.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::17) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|AS8PR08MB8947:EE_|AMS0EPF000001B0:EE_|PAXPR08MB6719:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f54fa4f-3d47-4660-0008-08dbffdbbe67 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: iebZVVWDxXl2DBHPCVlp2TBiQc8Y/jGc69Dj+MvjJCip5B7jo1gSdb67nwXUNHF2jNYydFA4LSE6+XHZqdZFjdb/Tiv8AY0YTn7abbJY1ywLfvhXI+xyLWdRqc6gWaRUrDBRwziNcI0AgDYd/Ev2pt+sPK+D8I5WFilrr7w0ekfArp+Tdnf3zC4p3km6ebIGKSnXv8bEfH/hWf92icXP6x4lqXKvdGjPycRTuGeNw+jSQ5Zl0+oRN6g1zI6274oA0amv2dG/V5P6RO9/kuRv+4ixyQ6vWVDkiwIdPFA31A++vYhPSB3z+jnAEihIoHWf2yLJU2u+47UyGH9AcSxFF5v07Kjuh6Q0WK85QJe55SSUvOXoD54wrXBDjw0mm180UHUn4VzyJTiAh3cUovc2xOhCJ0/Zwg5IJXjtjoavzsWzkqdZZVm0yF0vyZo7m3xPFdbmitJVWWfhZfS/Tk0hWXXaaTd31ytE6OxeKueXQi0lii/6nX0sYcv9vSbFdzKBX1rsVKoG5VWJtBD/m4tUbF/5LkWOvK1pdwW3L3YzK2Mm/Q0smCjYXjG6txQVYXIDt/vy0RkwpM1joduHMQj8/wobfF/LRfCj7G3zli/qDqjPFGp4XIRc2eKKe8mKeCTsu6e3iYoetaXlYF8/EDpVqQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(39860400002)(376002)(396003)(366004)(346002)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(31686004)(26005)(2616005)(2906002)(36756003)(31696002)(86362001)(38100700002)(83380400001)(44832011)(5660300002)(6512007)(53546011)(6506007)(6666004)(8936002)(8676002)(4326008)(66946007)(66556008)(6486002)(54906003)(316002)(6636002)(66476007)(41300700001)(478600001)(19627235002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8947 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF000001B0.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b799e2e2-af77-4a24-d7d4-08dbffdbb3a5 X-Microsoft-Antispam-Message-Info: 0H/QCbpUsP+SHMZV5IWLBX1k268ZIKo6OkmGnBydxC+7UWMywp6DgOOISQCXzklmFjFDhE+SYBZYpTTNE4df7btmrDrmiZMWONi8ep7eLzMGG2TsQ7qum12dMS4Ge46V644bW6zy5YhHEBiCYHn2BZa1Bdwqd3TtkEr4uCATGfkUhaiBnZ4RuSoQx5RDiqvela2+q0n2wzBckaO7M6/nZ8j2BpJRZffBEK0kvyalPca2/JcTRxgaF0gEsSUp3lWJLU8M8OCS7pNeOzPoVQIz+ODtvG9o0Zs3QQn+NH4lLCv7VrgIKBwgWsVbKSm1yMswDraLKthihc1maG2/TLfxGOnzIHtApizU3yq7qb2jXXbpQgUtKVp7P0Dd9/GfBKISQlZyBx8KFgYC5jY7yqeDK0PeM2RylqnBddoNq+d6m1Y3NnQbPz9XuQUkMDI0bkmhY5mMF58USFBnjxUYp0Zp45FmhwlTMpMwTXWLzr3m/CXFKSxrf9B5PtbQBqfU2p4WOnY3qwxl3sFq6gx3Kbdp9DRrhGj+gYBOHkpIetzWmljL/sAu+N7rbjSGhpP591UeWhOehaTN+YcFk5jx6JOu8yBB12o47MSy7h90mDFOtbAhwF1UQioFcR5iELUKXb6OM5rP03x7RYOqyZaqcP83kH3hCp6fRVUds9i+PNhnZBEVpaIkpelqSpU76LfjYpjQygLsU3fRGXEetdRBD/Cm5U5YK5QwZKiZykTHSeXFY/2A/R4hvLgKCvAiwTmJcr55US9QUbDhGwsW51yQQoFudA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 15:12:25.9617 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3f54fa4f-3d47-4660-0008-08dbffdbbe67 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001B0.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6719 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ULiUO4a99PZlF7RTrEvfzLWkx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=aHMIHkLQ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Sahil, Please see my response inline marked [SAMI]. Regards, Sami Mujawar On 16/11/2023 11:45 am, sahil via groups.io wrote: > Enable SCP QSPI flash region access by adding it in the PlatformLibMem > > Signed-off-by: sahil > --- > Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h | 6 +++= ++- > Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c | 10 +++= +++++-- > 2 files changed, 13 insertions(+), 3 deletions(-) > > diff --git a/Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h b/Silicon/= ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h > index 097160c7e2d1..92b8c9c45775 100644 > --- a/Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h > +++ b/Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h > @@ -1,6 +1,6 @@ > /** @file > > * > > -* Copyright (c) 2018 - 2020, ARM Limited. All rights reserved. > > +* Copyright (c) 2018 - 2023, ARM Limited. All rights reserved. > > * > > * SPDX-License-Identifier: BSD-2-Clause-Patent > > * > > @@ -41,6 +41,10 @@ > #define NEOVERSEN1SOC_EXP_PERIPH_BASE0 0x1C000000 > > #define NEOVERSEN1SOC_EXP_PERIPH_BASE0_SZ 0x1300000 > > =20 > > +// SCP QSPI flash device > > +#define NEOVERSEN1SOC_SCP_QSPI_AHB_BASE 0x18000000 > > +#define NEOVERSEN1SOC_SCP_QSPI_AHB_SZ 0x2000000 [SAMI] Can you elaborate what is meant by 'SCP', please? Does this mean=20 the flash is shared by SCP and AP? It would be good to clarify that in=20 the commit message. Also, if you can add a reference to the relevant document in the file=20 header it would be of great help. [/SAMI] > > + > > // Base address to a structure of type NEOVERSEN1SOC_PLAT_INFO which is > > // pre-populated by a earlier boot stage > > #define NEOVERSEN1SOC_PLAT_INFO_STRUCT_BASE (NEOVERSEN1SOC_NON= _SECURE_SRAM_BASE + \ > > diff --git a/Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem= .c b/Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c > index 9e8a1efc557d..eb099953fe29 100644 > --- a/Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c > +++ b/Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c > @@ -1,6 +1,6 @@ > /** @file > > =20 > > - Copyright (c) 2018 - 2021, ARM Limited. All rights reserved.
> > + Copyright (c) 2018 - 2023, ARM Limited. All rights reserved.
> > =20 > > SPDX-License-Identifier: BSD-2-Clause-Patent > > =20 > > @@ -13,7 +13,7 @@ > #include > > =20 > > // The total number of descriptors, including the final "end-of-table" = descriptor. > > -#define MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS 19 > > +#define MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS 20 > > =20 > > /** > > Returns the Virtual Memory Map of the platform. > > @@ -184,6 +184,12 @@ ArmPlatformGetVirtualMemoryMap ( > VirtualMemoryTable[Index].Length =3D NEOVERSEN1SOC_EXP_PERIP= H_BASE0_SZ; > > VirtualMemoryTable[Index].Attributes =3D ARM_MEMORY_REGION_ATTRI= BUTE_DEVICE; > > =20 > > + // SCP QSPI flash device > > + VirtualMemoryTable[++Index].PhysicalBase =3D NEOVERSEN1SOC_SCP_QSPI_A= HB_BASE; > > + VirtualMemoryTable[Index].VirtualBase =3D NEOVERSEN1SOC_SCP_QSPI_A= HB_BASE; > > + VirtualMemoryTable[Index].Length =3D NEOVERSEN1SOC_SCP_QSPI_A= HB_SZ; > > + VirtualMemoryTable[Index].Attributes =3D ARM_MEMORY_REGION_ATTRIB= UTE_DEVICE; > > + > > if (PlatInfo->MultichipMode =3D=3D 1) { > > //Remote DDR (2GB) > > VirtualMemoryTable[++Index].PhysicalBase =3D PcdGet64 (PcdExtMemor= ySpace) + > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112643): https://edk2.groups.io/g/devel/message/112643 Mute This Topic: https://groups.io/mt/102625033/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-