public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] github PRs keep breaking for me
Date: Tue, 9 Jun 2020 23:51:35 +0200	[thread overview]
Message-ID: <96077f44-20b2-93b3-49d1-eddbc72bd793@redhat.com> (raw)
In-Reply-To: <16a59bdb-b24f-b658-d5bf-1711336230ea@redhat.com>

On 06/09/20 23:37, Laszlo Ersek wrote:
> Hi,
> 
> On 03/12/20 22:57, Michael D Kinney wrote:
> 
>> The hub command is very flexible.  What commands did you try?
> 
> github again failed to accept the "push" label when I tried to set it.
> 
> Unlike last time, the push label *is* offered to me in the small widget
> to the right. When I click the label, it even gets a check mark.
> However, the label isn't actually applied to the PR. No comment saying
> "lersek set the 'push' label now" is generated, and the push label is
> not displayed to the right, once the small search widget is closed.
> 
> I tried both the WebUI:
> 
>   https://github.com/tianocore/edk2/pull/672
> 
> and then the "hub" utility (with "--labels push"):
> 
>   https://github.com/tianocore/edk2/pull/673
> 
> In either case, the "push" label didn't take.
> 
> Frustrating.
> 
>> I want to root cause this issue.  I suspect it is more related
>> to Mergify than GitHub or Azure Pipelines.  There is a state 
>> machine that is watching statuses and the sequence of actions
>> you are using must be going into a state I did not test.
>> Are you able to provide the sequences of steps that got the
>> PR into a bad state and the approximate time between steps?
> 
> I'm quite certain this is not related to mergify, as mergify's role
> would be in the end, when all the checks pass. Mergify correctly
> interprets the absence of the "push" label. The problem is that github
> does not add the label, in spite of my actions.

I should note that the "Preview" tab on the PR creation page also
stopped working for me. I click it, and I can see my browser generating
network traffic, and nothing happens.

I'm 100% sure it's a github server side problem, as in the last few
hours, I've successfully merged three other PRs (669 through 671). And,
the Preview tab worked with each one of those fine.

Meanwhile, <https://www.githubstatus.com/> claims everything is "Normal". :/

(I'm not going to file an issue report with github.com, because the last
time I did so, namely ticket 592107 on March 7th, I got a response on
*May* 14th.)

Thanks
Laszlo


  reply	other threads:[~2020-06-09 21:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12 21:06 github PRs keep breaking for me Laszlo Ersek
2020-03-12 21:57 ` [edk2-devel] " Michael D Kinney
2020-03-13 17:27   ` Laszlo Ersek
2020-03-13 18:21     ` Rebecca Cran
2020-06-09 21:37   ` Laszlo Ersek
2020-06-09 21:51     ` Laszlo Ersek [this message]
2020-06-09 21:55       ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96077f44-20b2-93b3-49d1-eddbc72bd793@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox