From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web11.1454.1591739503198468940 for ; Tue, 09 Jun 2020 14:51:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SGTQTNDc; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591739502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S8Y7iluKVZJ/uhjsw4ooY708y0QAuiGVTZAlRJnRoHA=; b=SGTQTNDcYXpb5aQ79Ojzh60QzWB5Kf3YX8UBNXvIAsQIy4T9VwvUDvXejzoz+E4dJR9Ru5 0IvM447t6nmZrXOYeFACAePv/WeVotONNM3TCFUUs398+hV6du121E2y1naOWdX/b7M2aw p15GF/xZjHlhjvJQ46cDalemH904FaM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-403-Ae1_tRC5MwG3L_BN44XFyQ-1; Tue, 09 Jun 2020 17:51:37 -0400 X-MC-Unique: Ae1_tRC5MwG3L_BN44XFyQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D32A8107ACCD; Tue, 9 Jun 2020 21:51:36 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-194.ams2.redhat.com [10.36.112.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0BCC35D9E5; Tue, 9 Jun 2020 21:51:35 +0000 (UTC) Subject: Re: [edk2-devel] github PRs keep breaking for me From: "Laszlo Ersek" To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Sean Brogan References: <16a59bdb-b24f-b658-d5bf-1711336230ea@redhat.com> Message-ID: <96077f44-20b2-93b3-49d1-eddbc72bd793@redhat.com> Date: Tue, 9 Jun 2020 23:51:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <16a59bdb-b24f-b658-d5bf-1711336230ea@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 06/09/20 23:37, Laszlo Ersek wrote: > Hi, > > On 03/12/20 22:57, Michael D Kinney wrote: > >> The hub command is very flexible. What commands did you try? > > github again failed to accept the "push" label when I tried to set it. > > Unlike last time, the push label *is* offered to me in the small widget > to the right. When I click the label, it even gets a check mark. > However, the label isn't actually applied to the PR. No comment saying > "lersek set the 'push' label now" is generated, and the push label is > not displayed to the right, once the small search widget is closed. > > I tried both the WebUI: > > https://github.com/tianocore/edk2/pull/672 > > and then the "hub" utility (with "--labels push"): > > https://github.com/tianocore/edk2/pull/673 > > In either case, the "push" label didn't take. > > Frustrating. > >> I want to root cause this issue. I suspect it is more related >> to Mergify than GitHub or Azure Pipelines. There is a state >> machine that is watching statuses and the sequence of actions >> you are using must be going into a state I did not test. >> Are you able to provide the sequences of steps that got the >> PR into a bad state and the approximate time between steps? > > I'm quite certain this is not related to mergify, as mergify's role > would be in the end, when all the checks pass. Mergify correctly > interprets the absence of the "push" label. The problem is that github > does not add the label, in spite of my actions. I should note that the "Preview" tab on the PR creation page also stopped working for me. I click it, and I can see my browser generating network traffic, and nothing happens. I'm 100% sure it's a github server side problem, as in the last few hours, I've successfully merged three other PRs (669 through 671). And, the Preview tab worked with each one of those fine. Meanwhile, claims everything is "Normal". :/ (I'm not going to file an issue report with github.com, because the last time I did so, namely ticket 592107 on March 7th, I got a response on *May* 14th.) Thanks Laszlo