On Tue, 2019-06-25 at 02:00 +0000, Ni, Ray wrote: > David, > I am afraid it will cause issues when exposing EfiBootManagerGetBootDescription(). > If you check the implementation, this API visits mPlatformBootDescriptionHandlers. > mPlatformBootDescriptionHandlers is modified by another already-exposed API > EfiBootManagerRegisterBootDescriptionHandler(). > > The *Register* API is to provide a capability to PlatformBootManagerLib to create > boot option description for special/platform-specific boot options. > > But the implicit requirement is boot option description can only be retrieved within > BdsDxe driver because only BdsDxe driver links to PlatformBootManagerLib. Hm, I'm not sure I fully understand the reason why the transitive dependency isn't OK, but neither is are the "special/platform-specific" boot options relevant for the CSM boot. So I'm happy to drop that part from the exported EfiBootManagerGetBootDescription() function and do it only in the internal BmGetBootDescription().