public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: devel@edk2.groups.io, sami.mujawar@arm.com
Cc: ardb@kernel.org, leif@nuviainc.com, Matteo.Carlini@arm.com,
	lersek@redhat.com, Andreas.Sandberg@arm.com, joey.gouly@arm.com,
	nd@arm.com
Subject: Re: [edk2-devel] [edk2-devel202105 PATCH v2 1/1] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3
Date: Thu, 27 May 2021 11:38:53 +0200	[thread overview]
Message-ID: <960ba960-a54d-3c60-d1ac-fbc31af7a81a@redhat.com> (raw)
In-Reply-To: <20210524130130.22280-1-sami.mujawar@arm.com>

On 5/24/21 3:01 PM, Sami Mujawar wrote:
> From: Andreas Sandberg <andreas.sandberg@arm.com>
> 
> Bugzilla: 3415 (https://bugzilla.tianocore.org/show_bug.cgi?id=3415)
> 
> The GICv3 architecture supports up to 1020 ordinary interrupt
> lines. The actual number of interrupts supported is described by the
> ITLinesNumber field in the GICD_TYPER register. The total number of
> implemented registers is normally calculated as
> 32*(ITLinesNumber+1). However, maximum value (0x1f) is a special case
> since that would indicate that 1024 interrupts are implemented.
> 
> Add handling for this special case in ArmGicGetMaxNumInterrupts.
> 
> Signed-off-by: Andreas Sandberg <andreas.sandberg@arm.com>
> Signed-off-by: Joey Gouly <joey.gouly@arm.com>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/1396_gic_max_num_intr_v2
> 
> Notes:
>     v2:
>       - Fix comment style.                                   [Laszlo]
>       - Updated comment style.                               [Sami]
> 
>  ArmPkg/Drivers/ArmGic/ArmGicLib.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>


      parent reply	other threads:[~2021-05-27  9:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24 13:01 [edk2-devel202105 PATCH v2 1/1] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3 Sami Mujawar
2021-05-25 11:55 ` [edk2-devel] " Laszlo Ersek
2021-05-26  2:22   ` 回复: " gaoliming
     [not found]   ` <16827C85E5A0E1A5.4904@groups.io>
2021-05-27  2:32     ` gaoliming
2021-05-27  8:50       ` Laszlo Ersek
2021-05-27  9:19         ` Sami Mujawar
     [not found]         ` <1682E1EE63CD4105.7325@groups.io>
2021-05-27 10:12           ` Sami Mujawar
2021-05-27 13:50             ` 回复: " gaoliming
2021-05-27  9:38 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=960ba960-a54d-3c60-d1ac-fbc31af7a81a@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox