From: Laszlo Ersek <lersek@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: edk2-devel@ml01.01.org, Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH] OvmfPkg: Fix typing errors
Date: Sat, 10 Sep 2016 01:02:37 +0200 [thread overview]
Message-ID: <9633703c-b7f4-8ee5-265b-b5f5c7ac4fa8@redhat.com> (raw)
In-Reply-To: <1473453135-22929-1-git-send-email-thuth@redhat.com>
Hi Thomas,
On 09/09/16 22:32, Thomas Huth wrote:
> Correct some typos (discovered with the codespell utility)
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 2 +-
> OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c | 4 ++--
> OvmfPkg/Library/NvVarsFileLib/FsAccess.c | 4 ++--
> OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 8 ++++----
> OvmfPkg/PlatformPei/MemDetect.c | 2 +-
> OvmfPkg/QemuVideoDxe/VbeShim.c | 2 +-
> OvmfPkg/XenBusDxe/EventChannel.c | 2 +-
> OvmfPkg/XenBusDxe/XenStore.c | 2 +-
> OvmfPkg/XenPvBlkDxe/BlockIo.c | 2 +-
> 9 files changed, 14 insertions(+), 14 deletions(-)
thank you for the contribution. The patch is good (I verified it with
"git show --word-diff" as well; that helps a lot).
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
However, applying the patch exposed a preexistent LF/CRLF issue in
"OvmfPkg/Library/NvVarsFileLib/FsAccess.c". So, I will send a
three-patch series in a minute; the first two patches will clean up the
problems I found, and then the third patch will be yours (carrying my R-b).
Thanks!
Laszlo
prev parent reply other threads:[~2016-09-09 23:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 20:32 [PATCH] OvmfPkg: Fix typing errors Thomas Huth
2016-09-09 23:02 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9633703c-b7f4-8ee5-265b-b5f5c7ac4fa8@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox