From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 92DEA1A1DF9
 for <edk2-devel@ml01.01.org>; Fri,  9 Sep 2016 16:02:40 -0700 (PDT)
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
 (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 141A28553F;
 Fri,  9 Sep 2016 23:02:40 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-33.phx2.redhat.com
 [10.3.116.33])
 by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u89N2cqB014961; Fri, 9 Sep 2016 19:02:39 -0400
To: Thomas Huth <thuth@redhat.com>
References: <1473453135-22929-1-git-send-email-thuth@redhat.com>
Cc: edk2-devel@ml01.01.org, Jordan Justen <jordan.l.justen@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <9633703c-b7f4-8ee5-265b-b5f5c7ac4fa8@redhat.com>
Date: Sat, 10 Sep 2016 01:02:37 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1473453135-22929-1-git-send-email-thuth@redhat.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.28]); Fri, 09 Sep 2016 23:02:40 +0000 (UTC)
Subject: Re: [PATCH] OvmfPkg: Fix typing errors
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Sep 2016 23:02:40 -0000
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

Hi Thomas,

On 09/09/16 22:32, Thomas Huth wrote:
> Correct some typos (discovered with the codespell utility)
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c              | 2 +-
>  OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c           | 4 ++--
>  OvmfPkg/Library/NvVarsFileLib/FsAccess.c             | 4 ++--
>  OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 8 ++++----
>  OvmfPkg/PlatformPei/MemDetect.c                      | 2 +-
>  OvmfPkg/QemuVideoDxe/VbeShim.c                       | 2 +-
>  OvmfPkg/XenBusDxe/EventChannel.c                     | 2 +-
>  OvmfPkg/XenBusDxe/XenStore.c                         | 2 +-
>  OvmfPkg/XenPvBlkDxe/BlockIo.c                        | 2 +-
>  9 files changed, 14 insertions(+), 14 deletions(-)

thank you for the contribution. The patch is good (I verified it with
"git show --word-diff" as well; that helps a lot).

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

However, applying the patch exposed a preexistent LF/CRLF issue in
"OvmfPkg/Library/NvVarsFileLib/FsAccess.c". So, I will send a
three-patch series in a minute; the first two patches will clean up the
problems I found, and then the third patch will be yours (carrying my R-b).

Thanks!
Laszlo