From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web10.73593.1669984037388848843 for ; Fri, 02 Dec 2022 04:27:17 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=FXQ1T7yi; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.40, mailfrom: alexey.kardashevskiy@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mtPwpIXt8bPO1+nInbGERT0NgkJadbnc6rbrGtjG7M2uXrFMf292E5LtvO/vj3zvkg/L27FzQAk5pjbMSVp1EedjTv/BU8yHSejSGN/7G6WN0bxpKnrS7b6MZ4jKpzUCwGlwsrwCt7lySxQeO5qab0tHy0SggZ0tHGEyWXdcBd7BTx2M4GJ9P2lcgorMRLP0gZ9taiHrwVLYDCaji6OCaRqZRRVB0TYSfhmHrIeuJ0J58DQQR89gzPkSXM0fOkUqh+XI20X1N6rj3a2T1EpOPFdboU8Ugs04a7AAoaGdO7ajDhbeXVsc/ZXMNAl+JqWxzIqbV0uCVe8ycYJC4zgykA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6LwqJIA7rSVu1RY4hM9Scm2clL7qxoBRzYadiWZRoBk=; b=GnSJ3uNdH87cSgNaushPTnQ0DMNXaz4V8CimDQPymrp13Szu1R3cF3ewge+C8D2NgyshZyaYlf6heTd2DuqnYhDZvipg/ZrETO6+p/OCesE26sbR7zMlwqV9e79basor7f/OE3Ns3fL8Vrg0JFiQT+qd+NWqR5wxr54/vLyRAiX4ZvFeYdR22eofcpu9NOntOc9o8xqKX3hnsWejMBtyjbwATZa5OAzo72pS11OYuR1kngbGTV9anZKA6hXaDvIQ7utKc3mJqvoAQ72iVBZDb1GJurpr+x0tEoAyTQKuxlgRqKrGvJBEBO9Zvo+7UFiGuZixJSayAcf255b/ID8aFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6LwqJIA7rSVu1RY4hM9Scm2clL7qxoBRzYadiWZRoBk=; b=FXQ1T7yiWX9PbZsn/l9qeQhOMUq9FwOVOUjMA/OL3GWaIHHIoO4dpMFy0BOfRQXuCsXX+35rUmK2aeC/mAF/BpXdHrxCSiZHXNAip4GEVNicGi3Levpd8VO2HVUzM92YejpJK012+Sn5cF2ld9bBG9W3/gUwG32wmaT+de2IWI4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB2843.namprd12.prod.outlook.com (2603:10b6:5:48::24) by BY5PR12MB4084.namprd12.prod.outlook.com (2603:10b6:a03:205::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.10; Fri, 2 Dec 2022 12:27:12 +0000 Received: from DM6PR12MB2843.namprd12.prod.outlook.com ([fe80::7dc4:8eb:cc3c:3cd4]) by DM6PR12MB2843.namprd12.prod.outlook.com ([fe80::7dc4:8eb:cc3c:3cd4%6]) with mapi id 15.20.5857.023; Fri, 2 Dec 2022 12:27:06 +0000 Message-ID: <964b4684-3c73-6258-619f-775a953b8498@amd.com> Date: Fri, 2 Dec 2022 23:26:56 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: Subject: [PATCH ovmf 2/5] MdePkg: Add AMD SEV features to PcdConfidentialComputingGuestAttr To: Tom Lendacky , devel@edk2.groups.io CC: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Brijesh Singh , Erdem Aktas , James Bottomley , Min Xu References: <20221201023521.10028-1-aik@amd.com> <20221201023521.10028-3-aik@amd.com> From: "Alexey Kardashevskiy" In-Reply-To: X-ClientProxiedBy: SYBPR01CA0012.ausprd01.prod.outlook.com (2603:10c6:10::24) To DM6PR12MB2843.namprd12.prod.outlook.com (2603:10b6:5:48::24) Return-Path: Alexey.Kardashevskiy@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB2843:EE_|BY5PR12MB4084:EE_ X-MS-Office365-Filtering-Correlation-Id: 53c9f1e4-e8ed-4904-bbce-08dad4608687 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 06/nvxl8Ft+oLQVOAIK2+cD6/ds3VedGQMdopDzhQJxuDCJGK34sS/NvqLmhF+7g35XJV/Hw9O1wEaWO0O05Sfu/mWCahOa88cnfOjp/+JDvIeb33RkiNwwDBDkYt+vo+unmftVTkGEuy7VneAZt8vShtKjDjGEZOThB7VleR7wLXXqJUrYrm75KpGIACWmvy8oqI6UM3iuPm/sugevAtnp0GPr5LZdx1I8ei+NYpIZUAyCsiTLIlklhhrMFrU1w5MJcoojj74XOnI/fCwm6/y+q79P7nsONCi/hOORcNFU9/XBdCRDl4GuqBt/OOAZUXMC+Gug8fS07XScKrH57dpSEhGvzWqEHu7YdlsA8vlXRUWj1HUE8rVhihw2NN3qc3ySZKaiI1Y9XVCTu/kHDnGeN66jR842LH2Dl3f59njyQx1gPwrgeHCxLKR1Nx60WQpp0gpi3kj9iVn8q8l9Ux6NO4UhxWQXPskfeSLOjrcG8imrr+s5rfZGTKBoNnivqm8AMdALYhwRtjWTqRaIBDAxbKHiLHqeVlYYvkPvOuTAm53BY96NhlDfwOw7gq7NxWD6xPvN43O3gWaqZi1Ns/bqIKJSYFdy3yqIIG9hMbzE84f+8KPgwC08BXfouyht1CAHsS8j3UodoAZCCxL3+Et6ZiJMUM/Nq/qT6vGtOc0mszjRPNXVbQMW+rwQhJxj5Of2urKLCeKDzgRUQWF8Td6Rjo/A8FhM0o2X8yXI2ucyfpdF4T/Q6ksuQoB3Hfehz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2843.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(376002)(136003)(39860400002)(396003)(451199015)(6512007)(26005)(6506007)(53546011)(6486002)(6666004)(478600001)(66556008)(4326008)(66946007)(2616005)(5660300002)(41300700001)(66476007)(186003)(8936002)(2906002)(8676002)(83380400001)(36756003)(38100700002)(316002)(54906003)(31686004)(31696002)(213903007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yyj5rOIC4bgecrejvOYtXHnmkh4w6c7KY037ED5L8lYG4cwVRNUtIr6RwPkm?= =?us-ascii?Q?e9sk3vP435tTbBCs6g3/Da76ohQG64Wymm+lnoTR66u/++9gxTphqmEcka6b?= =?us-ascii?Q?47W1G+gWACVkk4FB1qk0hyKzaycD5s5EhnADzkbQ728UrQU9L6F3FmWcfV50?= =?us-ascii?Q?P1E136IqJHPaBODblvcAe3rmRMJrVDPxgwV9UInWpS8tBrR2BcDofZm7Sq35?= =?us-ascii?Q?yYW2WrzwtKhvI3i01eEGDMEEsS8d7jHaD8zr0kOW5aaWhM1GnDR7h5H7fpAM?= =?us-ascii?Q?UwkKyPqnOOcIBynBwgeOMfeyqgFMRCDRcgTyo6BrA+e0x/1WFOnW+0gZFdwA?= =?us-ascii?Q?IDU/7Kz9ZzQdBYQSZFYLqU6gVlnGC67X6q7tOjio8D2B+whBlzezVGPY4iAT?= =?us-ascii?Q?axxbK6x5BVloqxOmZFI05QUYoVPHjsM4+qQUiJRzFtvf/pdNxMYyzmSMNzoT?= =?us-ascii?Q?IMyJq1m2sLy5r6ZEd/oeRpbBLSDtYuM4TJgTH8yNUlvJpS08/2sz+4eRV5EK?= =?us-ascii?Q?j8rHX3GrI0MREjp/+P3HY1Wt65KCGNwxH3eJSmVn2chVcsHaOMsuzMilTTcN?= =?us-ascii?Q?mdz0J9OxzVRGXCOYec02COIUc/gw4+U7iWfwgKRN9rnKeH6ZgWqgE3iy3l6s?= =?us-ascii?Q?KvpTrwgCHhC5IYrlQ8zlMkLaW4fBqXMoz1h3aBjUtAgOtUieFYcmkCB9K1BZ?= =?us-ascii?Q?ovr1sw0p5sxPgD6X9M8qZgsoX+qJf2VcXTVEdhgnmoM1r4ga9d2HRghB86Yc?= =?us-ascii?Q?90LpxAE+PD1jqFexxXKEqYYHqaah5iAz7JjLj0TF2dtcERG/9GahZEGqVt1u?= =?us-ascii?Q?Uz/63ECB3o93X32QwqXEcXU9iMnClo/PTY1Gza1zL3TJUMCfxZfo45ihAF2I?= =?us-ascii?Q?GOGD+wE9R8Gc9Etaw0HPIwCILYJxSRIdDyMJENvz2IHY12SJm0/WoJGNWHxc?= =?us-ascii?Q?f137DKWBk2TPGp0Yf07VR1UeCVbP9jlZZMAY7v1LLwr0CjtKSftx6nBq3RED?= =?us-ascii?Q?JwX8iD1Uhh4l6zjs4QXHPlrIQHGQqEC/MU/VtmifqPSQX8JdXZC2cdtJnSHt?= =?us-ascii?Q?sGcAzSk6ulem2hLpljV3S9AzcwG4G1G2uc1WI2H5UBCDct59mf9OrFX0eGTw?= =?us-ascii?Q?mB7Z10jcflHHo+lVDU0jrLGBif9BZf4h3ltbE8K0kw+CX8ocaxnvRcLFs9lW?= =?us-ascii?Q?KKdHcwRHble/eqCccDwuhWxtaQ6OdKxE6IRQXm9p0g/qP5xZX14EmPZiRf5n?= =?us-ascii?Q?eBm58ix3k238iKd1IA0FJjbNhgury0pMIAMsqyvaCDiFPaZ1yaWqtP+q8avY?= =?us-ascii?Q?eATqPBSB04AGZaL0BET+RQmOauI2dMDe2TXp5LvjR3+c8ROl3AWttIVw/j+A?= =?us-ascii?Q?GdTnG0ZGD2y9tMKOu5dvQEGAH9fRa+u7aK97RS9uJOBfJ+1tyfic6r9WTxj6?= =?us-ascii?Q?8TS+BpqL7w1MHpW5vzmnJsQxMbV7F2yjF1O/tdJBk1D1v/GknF1xoBPqGjJM?= =?us-ascii?Q?LrL0/2dTNsP8JkKpAca7gZvKpkAZ5Q4piBcyaVcnInBGsAkclRcU8YbLrIXS?= =?us-ascii?Q?lvgsyzno1trJ+MtFrHWvSmTDUQYYOd7LhoqAmz/Q?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53c9f1e4-e8ed-4904-bbce-08dad4608687 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2843.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2022 12:27:06.8931 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Sto2n4uAynkuS5xgsNmJ6296oRGrJ0qZQ4UnSlW9ST2DFUQMN4cuzoirCMkNX10zrAJvr25Lt+rKA8ksZrrJLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4084 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 2/12/22 01:47, Tom Lendacky wrote: > Added the subject as somehow it didn't get set. >=20 > On 11/30/22 20:35, Alexey Kardashevskiy wrote: >> Date: Tue, 22 Nov 2022 16:12:55 +1100 >> Subject: [PATCH ovmf 2/5] MdePkg: Add AMD SEV features to >> =C2=A0 PcdConfidentialComputingGuestAttr >> >> PcdConfidentialComputingGuestAttr so far only contained an SEV mode bit >> but there are more other features which do not translate to levels >> such as DebugSwap or SecureTsc. >> >> This adds the features mask and the DebugSwap feature bit to a PCD. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> =C2=A0 MdePkg/Include/ConfidentialComputingGuestAttr.h | 5 ++++- >> =C2=A0 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/MdePkg/Include/ConfidentialComputingGuestAttr.h=20 >> b/MdePkg/Include/ConfidentialComputingGuestAttr.h >> index 44e6df800207..1fd09a51ea52 100644 >> --- a/MdePkg/Include/ConfidentialComputingGuestAttr.h >> +++ b/MdePkg/Include/ConfidentialComputingGuestAttr.h >> @@ -26,12 +26,15 @@ typedef enum { >> =C2=A0=C2=A0=C2=A0 CCAttrAmdSev=C2=A0=C2=A0=C2=A0 =3D 0x100, >> =C2=A0=C2=A0=C2=A0 CCAttrAmdSevEs=C2=A0 =3D 0x101, >> =C2=A0=C2=A0=C2=A0 CCAttrAmdSevSnp =3D 0x102, >> +=C2=A0 CCAttrAmdSevFeatureMask=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D 0xffff= 0000, >=20 > The PCD for this is 64-bits, should this be 0xffffffffffff0000? True but does not that really depend on how greedy I am? :) For now I=20 like 16bits and leave the rest for everyone else. --=20 Alexey