From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Leif Lindholm <leif@nuviainc.com>
Cc: devel@edk2.groups.io
Subject: Re: [PATCH edk2-platforms 02/15] Platform/AMD: add RngLib for Overdriveboard
Date: Wed, 25 Nov 2020 14:22:05 +0100 [thread overview]
Message-ID: <965e1b8d-b799-6792-d60b-b873788b116f@arm.com> (raw)
In-Reply-To: <20201125132002.GS1664@vanye>
On 11/25/20 2:20 PM, Leif Lindholm wrote:
> On Wed, Nov 25, 2020 at 14:09:00 +0100, Ard Biesheuvel wrote:
>> On 11/25/20 1:55 PM, Leif Lindholm wrote:
>>> OpenSSL now requires an RngLib. Add the generic
>>> MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
>>> to fix Overdrive build.
>>>
>>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
>>> ---
>>> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
>>> index 5a38b9dd96ae..bf4d6dd7b804 100644
>>> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
>>> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
>>> @@ -119,6 +119,7 @@ [LibraryClasses.common]
>>> PlatformFlashAccessLib|Silicon/AMD/Styx/Library/StyxPlatformFlashAccessLib/StyxPlatformFlashAccessLib.inf
>>> OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
>>> + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
>>> TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
>>> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
>>>
>>
>> Could we use DxeRngLib here? That will be backed by the h/w RNG instead of
>> the cycle counter.
>
> You mean since we have EFI_RNG_PROTOCOL from StyxRngDxe?
> Good point, had forgotten about that.
> OK to fold in before pushing?
>
Sure
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
next prev parent reply other threads:[~2020-11-25 13:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 12:55 [PATCH edk2-platforms 00/15] arm platform fixes triggered by VariablePolicy Leif Lindholm
2020-11-25 12:55 ` [PATCH edk2-platforms 01/15] Silicon/AMD: update Styx to use PcdSet*S APIs Leif Lindholm
2020-11-25 12:55 ` [PATCH edk2-platforms 02/15] Platform/AMD: add RngLib for Overdriveboard Leif Lindholm
2020-11-25 13:09 ` Ard Biesheuvel
2020-11-25 13:20 ` Leif Lindholm
2020-11-25 13:22 ` Ard Biesheuvel [this message]
2020-11-25 12:55 ` [PATCH edk2-platforms 03/15] Platform,Silicon: fix beagleboard tautological compares Leif Lindholm
2020-11-25 12:55 ` [PATCH edk2-platforms 04/15] Silicon/Hisilicon: add RngLib for Hisilicon Leif Lindholm
2020-11-25 13:12 ` Leif Lindholm
2020-11-25 12:55 ` [PATCH edk2-platforms 05/15] Platform/ARM: VExpressPkg fixes to work with new VariablePolicyLib Leif Lindholm
2020-11-25 12:55 ` [PATCH edk2-platforms 06/15] Platform/AMD: add VariablePolicy library resolutions for Overdrive Leif Lindholm
2020-11-25 12:55 ` [PATCH edk2-platforms 07/15] Platform/SoftIron: add VariablePolicy resolutions for Overdrive1000 Leif Lindholm
2020-11-25 12:55 ` [PATCH edk2-platforms 08/15] Platform/LeMaker: add VariablePolicy resolutions for cello Leif Lindholm
2020-11-25 12:55 ` [PATCH edk2-platforms 09/15] Platform/SiFive: add VariablePolicy resolutions Leif Lindholm
2020-11-26 0:39 ` Abner Chang
2020-11-25 12:55 ` [PATCH edk2-platforms 10/15] Platform/Qemu: " Leif Lindholm
2020-11-25 12:55 ` [PATCH edk2-platforms 11/15] Silicon/Marvell: " Leif Lindholm
2020-11-25 12:55 ` [PATCH edk2-platforms 12/15] Platform/BeagleBoard: " Leif Lindholm
2020-11-25 12:55 ` [PATCH edk2-platforms 13/15] Silicon/NXP: " Leif Lindholm
2020-11-25 12:55 ` [PATCH edk2-platforms 14/15] Platform/SocioNext: " Leif Lindholm
2020-11-25 13:11 ` Ard Biesheuvel
2020-11-25 13:16 ` Leif Lindholm
2020-11-25 13:27 ` Ard Biesheuvel
2020-11-25 12:55 ` [PATCH edk2-platforms 15/15] Silicon/Hisilicon: " Leif Lindholm
2020-11-25 13:13 ` Leif Lindholm
2020-11-25 13:11 ` [PATCH edk2-platforms 00/15] arm platform fixes triggered by VariablePolicy Leif Lindholm
2020-11-26 10:44 ` wenyi,xie
2020-11-26 13:31 ` Leif Lindholm
2020-11-26 13:42 ` wenyi,xie
2020-11-25 13:12 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=965e1b8d-b799-6792-d60b-b873788b116f@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox