From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.6562.1606310528568164768 for ; Wed, 25 Nov 2020 05:22:08 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 352AA31B; Wed, 25 Nov 2020 05:22:08 -0800 (PST) Received: from [192.168.1.81] (unknown [10.37.8.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 90AFE3F70D; Wed, 25 Nov 2020 05:22:07 -0800 (PST) Subject: Re: [PATCH edk2-platforms 02/15] Platform/AMD: add RngLib for Overdriveboard To: Leif Lindholm Cc: devel@edk2.groups.io References: <20201125125559.11631-1-leif@nuviainc.com> <20201125125559.11631-3-leif@nuviainc.com> <20201125132002.GS1664@vanye> From: "Ard Biesheuvel" Message-ID: <965e1b8d-b799-6792-d60b-b873788b116f@arm.com> Date: Wed, 25 Nov 2020 14:22:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201125132002.GS1664@vanye> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/25/20 2:20 PM, Leif Lindholm wrote: > On Wed, Nov 25, 2020 at 14:09:00 +0100, Ard Biesheuvel wrote: >> On 11/25/20 1:55 PM, Leif Lindholm wrote: >>> OpenSSL now requires an RngLib. Add the generic >>> MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf >>> to fix Overdrive build. >>> >>> Cc: Ard Biesheuvel >>> Signed-off-by: Leif Lindholm >>> --- >>> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc >>> index 5a38b9dd96ae..bf4d6dd7b804 100644 >>> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc >>> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc >>> @@ -119,6 +119,7 @@ [LibraryClasses.common] >>> PlatformFlashAccessLib|Silicon/AMD/Styx/Library/StyxPlatformFlashAccessLib/StyxPlatformFlashAccessLib.inf >>> OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf >>> + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf >>> TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf >>> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf >>> >> >> Could we use DxeRngLib here? That will be backed by the h/w RNG instead of >> the cycle counter. > > You mean since we have EFI_RNG_PROTOCOL from StyxRngDxe? > Good point, had forgotten about that. > OK to fold in before pushing? > Sure Acked-by: Ard Biesheuvel