Re: [edk2-devel] [PATCH] ASpeed/ASpeedGopBinPkg: Update X64/AArch64 Gop UEFI Driver

["Leif Lindholm" <quic_llindhol@quicinc.com>]

Thank you.

Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
Pushed as 4e36179c55f4.

/
     Leif

On 2024-06-13 12:07, Tommy Huang via groups.io wrote:
> Hi Leif,
> 
> 	Got it.
> 	I have pushed my patch update into below .git.
> 	You could clone it for further checked.
> 
> 	https://github.com/TommyHuang0527/Gop_test_repo.git
> 
> 	BR,
> 
> 	By Tommy
> 
>> -----Original Message-----
>> From: Leif Lindholm <quic_llindhol@quicinc.com>
>> Sent: Thursday, June 13, 2024 12:03 PM
>> To: Tommy Huang <tommy_huang@aspeedtech.com>; Nhi Pham
>> <nhi@os.amperecomputing.com>; devel@edk2.groups.io
>> Cc: ardb@kernel.org; nathaniel.l.desimone@intel.com;
>> michael.d.kinney@intel.com; Ryan Chen <ryan_chen@aspeedtech.com>;
>> BMC-SW <BMC-SW@aspeedtech.com>
>> Subject: Re: [edk2-devel] [PATCH] ASpeed/ASpeedGopBinPkg: Update
>> X64/AArch64 Gop UEFI Driver
>>
>> On 2024-06-13 09:04, Tommy Huang wrote:
>>> Hi Leif,
>>>
>>> 	Do we need to do more test for this commit?
>>> 	Or include more people for this?
>>
>> Hi Nhi,
>>
>> Apologies, traveling and having patchy access to time to look at things.
>>
>> Tommy, could you push this set to a public branch somwhere I could grab it
>> from?
>>
>> Best Regards,
>>
>> Leif
>>
>>> 	BR,
>>>
>>> 	By Tommy
>>>
>>>> -----Original Message-----
>>>> From: Nhi Pham <nhi@os.amperecomputing.com>
>>>> Sent: Friday, May 31, 2024 8:20 PM
>>>> To: Tommy Huang <tommy_huang@aspeedtech.com>;
>> devel@edk2.groups.io;
>>>> quic_llindhol@quicinc.com
>>>> Cc: ardb@kernel.org; nathaniel.l.desimone@intel.com;
>>>> michael.d.kinney@intel.com; Ryan Chen <ryan_chen@aspeedtech.com>;
>>>> BMC-SW <BMC-SW@aspeedtech.com>
>>>> Subject: Re: [edk2-devel] [PATCH] ASpeed/ASpeedGopBinPkg: Update
>>>> X64/AArch64 Gop UEFI Driver
>>>>
>>>> On 5/30/2024 8:33 AM, Tommy Huang wrote>> On 5/29/2024 8:18 PM, Leif
>>>> Lindholm via groups.io wrote:
>>>>>>> +Nhi,
>>>>>>>
>>>>>>> Could you check/verify these work fine on your systems?
>>>>>>
>>>>>> Yes, I can. Thanks Leif for reaching out to me.
>>>>>>
>>>>>> Hi Tommy Huang - Could you please create a Pull Request (PR) or
>>>>>> share a branch so I can easily apply and test the AArch64 GOP driver?
>>>>>
>>>>> Sorry~ We just release our BIOS / GOP resources on our official website.
>>>>> You could reach it from https://www.aspeedtech.com/support_driver/
>>>>
>>>> Thanks for the link.
>>>>
>>>>> It was located VBIOS/UEFI -> Version 1.13.04 -> 1.13.04 -> UEFI ->
>>>>> AARCH64 -> uefi_arm_2500_800.efi and uefi_arm_2600.efi These two
>>>> binaries have been tested Mt. Collins system. You could double confirm it.
>>>>
>>>> I tested the driver on my __BMC AST2600__ system. It works well. Thanks!
>>>>
>>>>>
>>>>>>
>>>>>> Also, I am never aware of GOP driver with secure boot enabled before.
>>>>>> Is the .efi binary signed with Microsoft's key?
>>>>>
>>>>> Yes. These binaries are all signed with Microsoft's key.
>>>>>
>>>> Tested-by: Nhi Pham <nhi@os.amperecomputing.com>
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119566): https://edk2.groups.io/g/devel/message/119566
Mute This Topic: https://groups.io/mt/106342303/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-