Re: [PATCH edk2-platforms v1 1/1] Platform/Hisilicon: Fix missing dependency on VariableFlashInfoLib

["PierreGondois" <pierre.gondois@arm.com>]

Hi Sami,
I think other platforms have the same library missing:
- Platform/Hisilicon/D03/D03.dsc
- Platform/Hisilicon/D06/D06.dsc
- Platform/Hisilicon/HiKey960/HiKey960.dsc
- Platform/Hisilicon/HiKey/HiKey.dsc

If the library definition is done in Silicon/Hisilicon/Hisilicon.dsc.inc,
I think it solves all the definitions at once,

Regards,
Pierre


On 1/19/23 17:14, Sami Mujawar wrote:
> From: Guillaume Gardet <Guillaume.Gardet@arm.com>
> 
> The Hisilicon/HiKey and Hisilicon/HiKey960 platform firmware builds
> break due to a missing dependency on VariableFlashInfoLib.
> 
> Therefore, include VariableFlashInfoLib in the [LibraryClasses.common]
> section to satisfy the dependency.
> 
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Wenyi Xie <xiewenyi2@huawei.com>
> Cc: Guillaume Gardet <Guillaume.Gardet@arm.com>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>   Platform/Hisilicon/HiKey/HiKey.dsc       | 1 +
>   Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
> index 375b29375d75cec37eb7410a8ea4396b6cdf89a4..c0de67fce8fe3a76cb6eca7f54814d676939f3e9 100644
> --- a/Platform/Hisilicon/HiKey/HiKey.dsc
> +++ b/Platform/Hisilicon/HiKey/HiKey.dsc
> @@ -62,6 +62,7 @@ [LibraryClasses.common]
>     AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>     TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
> +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>   
>   [LibraryClasses.common.SEC]
>     PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> diff --git a/Platform/Hisilicon/HiKey960/HiKey960.dsc b/Platform/Hisilicon/HiKey960/HiKey960.dsc
> index 1d09e3f5da74824af3b988a55c646c1b127a3a93..b821f0be60e31507bee8d4358e15fc5eedaf133e 100644
> --- a/Platform/Hisilicon/HiKey960/HiKey960.dsc
> +++ b/Platform/Hisilicon/HiKey960/HiKey960.dsc
> @@ -63,6 +63,7 @@ [LibraryClasses.common]
>     AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>     TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
> +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>   
>   [LibraryClasses.common.SEC]
>     PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf