From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.37629.1674461324476044994 for ; Mon, 23 Jan 2023 00:08:44 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5B661AD7; Mon, 23 Jan 2023 00:09:25 -0800 (PST) Received: from [10.34.100.128] (pierre123.nice.arm.com [10.34.100.128]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3384F3F71A; Mon, 23 Jan 2023 00:08:42 -0800 (PST) Message-ID: <966d1344-219f-8dc6-03f3-44ea75b61980@arm.com> Date: Mon, 23 Jan 2023 09:08:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH edk2-platforms v1 1/1] Platform/Hisilicon: Fix missing dependency on VariableFlashInfoLib To: Sami Mujawar , devel@edk2.groups.io Cc: ardb+tianocore@kernel.org, quic_llindhol@quicinc.com, xiewenyi2@huawei.com, Guillaume.Gardet@arm.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, nd@arm.com References: <20230119161404.22868-1-sami.mujawar@arm.com> From: "PierreGondois" In-Reply-To: <20230119161404.22868-1-sami.mujawar@arm.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Sami, I think other platforms have the same library missing: - Platform/Hisilicon/D03/D03.dsc - Platform/Hisilicon/D06/D06.dsc - Platform/Hisilicon/HiKey960/HiKey960.dsc - Platform/Hisilicon/HiKey/HiKey.dsc If the library definition is done in Silicon/Hisilicon/Hisilicon.dsc.inc, I think it solves all the definitions at once, Regards, Pierre On 1/19/23 17:14, Sami Mujawar wrote: > From: Guillaume Gardet > > The Hisilicon/HiKey and Hisilicon/HiKey960 platform firmware builds > break due to a missing dependency on VariableFlashInfoLib. > > Therefore, include VariableFlashInfoLib in the [LibraryClasses.common] > section to satisfy the dependency. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Wenyi Xie > Cc: Guillaume Gardet > Cc: Pierre Gondois > Signed-off-by: Sami Mujawar > --- > Platform/Hisilicon/HiKey/HiKey.dsc | 1 + > Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc > index 375b29375d75cec37eb7410a8ea4396b6cdf89a4..c0de67fce8fe3a76cb6eca7f54814d676939f3e9 100644 > --- a/Platform/Hisilicon/HiKey/HiKey.dsc > +++ b/Platform/Hisilicon/HiKey/HiKey.dsc > @@ -62,6 +62,7 @@ [LibraryClasses.common] > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > > [LibraryClasses.common.SEC] > PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > diff --git a/Platform/Hisilicon/HiKey960/HiKey960.dsc b/Platform/Hisilicon/HiKey960/HiKey960.dsc > index 1d09e3f5da74824af3b988a55c646c1b127a3a93..b821f0be60e31507bee8d4358e15fc5eedaf133e 100644 > --- a/Platform/Hisilicon/HiKey960/HiKey960.dsc > +++ b/Platform/Hisilicon/HiKey960/HiKey960.dsc > @@ -63,6 +63,7 @@ [LibraryClasses.common] > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > > [LibraryClasses.common.SEC] > PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf