From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.26.1636558712101895003 for ; Wed, 10 Nov 2021 07:38:32 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=Z2in6wh4; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [10.0.0.19] (c-73-27-179-174.hsd1.fl.comcast.net [73.27.179.174]) by linux.microsoft.com (Postfix) with ESMTPSA id 95B8120B9D55; Wed, 10 Nov 2021 07:38:30 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 95B8120B9D55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1636558711; bh=habfcRzylv43b0oS6gDxECie50iJXj3biwHXFfNKOFo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Z2in6wh4mNbpU7Emcmc+ah/dxeShpAnVWcyEroLtI1J153l6k0bvvR+Hupd2rQdTY ig95WQdpthKOgEELQiV6OWxxo+DfnP8bFBo5BMfTxc1NblkyglyE27suYMk45qouqD XZfdf+b5IL7aDnrJ6Q9W1o2ftxYszkGMrz8nPozI= Message-ID: <966ebf2a-69aa-ac9b-2fbc-7c371909bcba@linux.microsoft.com> Date: Wed, 10 Nov 2021 10:38:28 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2? To: devel@edk2.groups.io, michael.d.kinney@intel.com, "kraxel@redhat.com" , Leif Lindholm Cc: Andrew Fish , =?UTF-8?Q?Marvin_H=c3=a4user?= , Michael Kubacki , "rebecca@nuviainc.com" , Bret Barkelew References: <9fe0f984-db9d-9aec-0b44-5d30791a2855@linux.microsoft.com> <20211007104813.wa4rmfsqgcpvnzwt@leviathan> <07d5c8bc-40b2-4e99-3b3d-4c8ac4e14220@posteo.de> <438B4D66-2CFB-45E3-AF75-42342F0B1E67@apple.com> <20211109084002.wywzc5cnwhhlzktc@sirius.home.kraxel.org> <20211109123630.j7ropheao337m7rf@leviathan> <20211109141007.z5iqvrspuqfleqzj@sirius.home.kraxel.org> From: "Michael Kubacki" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 11/9/2021 10:44 AM, Michael D Kinney wrote: >=20 >=20 >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Gerd Hoff= mann >> Sent: Tuesday, November 9, 2021 6:10 AM >> To: Leif Lindholm >> Cc: devel@edk2.groups.io; Kinney, Michael D = ; Andrew Fish ; Marvin H=C3=A4user >> ; Michael Kubacki ; m= ikuback@linux.microsoft.com; rebecca@nuviainc.com; >> Bret Barkelew >> Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK= 2? >> >> On Tue, Nov 09, 2021 at 12:36:30PM +0000, Leif Lindholm wrote: >>> On Tue, Nov 09, 2021 at 09:40:02 +0100, Gerd Hoffmann wrote: >>>> Hi, >>>> >>>>> 3. Require use of uncrustify tool before submitting patch review = emails or PRs. >>>>> * The required version would be a formally released version = from the fork maintained by Michael Kubacki >> until the changes can be upstreamed. >>>>> * https://dev.azure.com/projectmu/Uncrustify >>>> >>>> Can we please *first* get the changes merged to upstream uncrustify? >>>> >>>> That'll make the whole process much less painful because the usual >>>> software repositories (linux distro packages, macos homebrew, ...) >>>> can be used to install uncrustify then, and it's also less confusing i= f >>>> developers don't have to juggle with different uncrustify variants >>>> (upstream vs. edk2). >>> >>> Whilst I agree in principle... >>> >>> This means postponing automated coding style changes until 2023 >>> (Debian stable), 2025 (Ubuntu LTS), ??? (RHEL10), or even later >>> ... and I'd rather not. >>> >>> I like Marvin's suggestion of a submodule. Which we could drop once >>> no longer needed. >> >> I'm fine with a submodule (temporary & optional) so we don't have to >> wait until all distros (especially the LTS ones which are slower) have >> picked up the latest uncrustify release. >> >> But I still think upstreaming the uncrustify changes should be the first >> step. >=20 > The first step is to review and accept the style of code generated by > the current fork. >=20 I agree. I'm happy to prepare the changes for upstream but I would like=20 to make sure the changes are needed. >> >> take care, >> Gerd >> >> >> >> >> >=20 >=20 >=20 >=20 >=20 >=20