From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.1498.1602096354068842460 for ; Wed, 07 Oct 2020 11:45:54 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AFDDD1063; Wed, 7 Oct 2020 11:45:53 -0700 (PDT) Received: from [192.168.1.81] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 203923F71F; Wed, 7 Oct 2020 11:45:52 -0700 (PDT) Subject: Re: [PATCH v1 1/1] [EmbeddedPkg] TCBZ2381 - roll guid for PrePiHobLib To: matthewfcarlson@gmail.com, devel@edk2.groups.io Cc: Leif Lindholm References: <20201007181618.5176-1-matthewfcarlson@gmail.com> <20201007181618.5176-2-matthewfcarlson@gmail.com> From: "Ard Biesheuvel" Message-ID: <9681dbe5-81eb-33e0-5f68-1d79cf421c55@arm.com> Date: Wed, 7 Oct 2020 20:45:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201007181618.5176-2-matthewfcarlson@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/7/20 8:16 PM, matthewfcarlson@gmail.com wrote: > From: Matthew Carlson > > PrePiHobLib has the same GUID as PrePiLib > This is considered invalid and this seeks to address that. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Matthew Carlson Same comment as before re use of [] in the subject line. Also, what is TCBZ2381? Is that a bugzilla entry? Please use a Link: tag in the commit log instead. > --- > EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf b/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf > index b2c4c04bfd76..55de4511fc98 100644 > --- a/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf > +++ b/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf > @@ -12,7 +12,7 @@ > [Defines] > INF_VERSION = 0x00010005 > BASE_NAME = PrePiHobLib > - FILE_GUID = 1F3A3278-82EB-4C0D-86F1-5BCDA5846CB2 > + FILE_GUID = AEF7D85A-6A91-4ACD-9A28-193DEFB325FB > MODULE_TYPE = BASE > VERSION_STRING = 1.0 > LIBRARY_CLASS = HobLib >